Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-22 Thread Hilmar Preuße

Control: severity -1 important

On 2/16/20 9:34 AM, Tomas Janousek wrote:

> Package: proftpd-basic
> Version: 1.3.6-4+deb10u3
> Severity: normal
> 
> It appears bug #839880 reappeared in current Debian stable:
> 
Set that to important.

H.
-- 
sigfault
#206401 http://counter.li.org



signature.asc
Description: OpenPGP digital signature


Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-21 Thread Tomas Janousek
Hi again,

On Fri, Feb 21, 2020 at 09:07:26PM +, Tomas Janousek wrote:
> I needed amd64 so I grabbed
> https://salsa.debian.org/debian-proftpd-team/proftpd/commit/20c8f39058443bf13afbb4ced069d181bd8d235c
> and built it myself. I can confirm that it does indeed fix the issue. Feel
> free to release to buster.

Oh and I just noticed that you did add amd64 in the meantime. Could've saved
some time. Anyway, what I just built includes
https://salsa.debian.org/debian-proftpd-team/proftpd/commit/f58c0540533cf7173f75e2ab296d263c334cfd2e
as well so if you don't hear back from me in a few days take that as testing
that patch as well. :-))

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/



Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-21 Thread Tomas Janousek
Hi Hilmar,

Thanks for your quick reply and sorry for my late one, I had a busy week. :-(

On Sun, Feb 16, 2020 at 11:25:45PM +0100, Hilmar Preuße wrote:
> >> It appears bug #839880 reappeared in current Debian stable:
> >>
> > I'm unable to reproduce the issue, but it looks similar to
> > 
> > https://github.com/proftpd/proftpd/issues/656
> > 
> > Please read through the issue and report back if it describe your
> > problem. Thanks!
> > 
> I've built fixed(?) packages for this issue and uploaded here [1]. If
> you need packages for other arches, please call back.
> 
> [1] https://freeshell.de/~hille42/proftpd/951412_949622/

I needed amd64 so I grabbed
https://salsa.debian.org/debian-proftpd-team/proftpd/commit/20c8f39058443bf13afbb4ced069d181bd8d235c
and built it myself. I can confirm that it does indeed fix the issue. Feel
free to release to buster.

Thanks a lot!

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/



Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Hilmar Preuße
Am 16.02.2020 um 21:38 teilte Hilmar Preuße mit:
> Am 16.02.2020 um 09:34 teilte Tomas Janousek mit:

Hi Tomas,

>> It appears bug #839880 reappeared in current Debian stable:
>>
> I'm unable to reproduce the issue, but it looks similar to
> 
> https://github.com/proftpd/proftpd/issues/656
> 
> Please read through the issue and report back if it describe your
> problem. Thanks!
> 
I've built fixed(?) packages for this issue and uploaded here [1]. If
you need packages for other arches, please call back.

Hilmar

[1] https://freeshell.de/~hille42/proftpd/951412_949622/
-- 
sigfault
#206401 http://counter.li.org



signature.asc
Description: OpenPGP digital signature


Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Hilmar Preuße
Am 16.02.2020 um 09:34 teilte Tomas Janousek mit:

Hi Tomas,

> It appears bug #839880 reappeared in current Debian stable:
> 
I'm unable to reproduce the issue, but it looks similar to

https://github.com/proftpd/proftpd/issues/656

Please read through the issue and report back if it describe your
problem. Thanks!

Hilmar
-- 
sigfault
#206401 http://counter.li.org



signature.asc
Description: OpenPGP digital signature


Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Bernhard Übelacker
Hello Tomas,

Am 16.02.20 um 17:30 schrieb Tomas Janousek:
> So unless that palloc tries to allocate way more memory than it should,
> I don't think that's the problem.

Unfortunately that allocation seems just "sizeof(pr_response_t)",
so I guess it is not an unusual big allocation.

Kind regards,
Bernhard



Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Tomas Janousek
Hi,

On Sun, Feb 16, 2020 at 05:25:34PM +0100, Bernhard Übelacker wrote:
> Could the call to palloc just before have failed to allocate memory?

If that's a question for me, then: extremely unlikely.

I tried just restarting proftpd, I tried restarting the whole container.
There are no memory limits for the container (I'm a poor admin, I know!).
The host has cca half of its physical memory available, and plenty-ish of swap
on top of that.

So unless that palloc tries to allocate way more memory than it should,
I don't think that's the problem.

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/



Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Bernhard Übelacker
Dear Maintainer,
I just tried to reconstruct the line informations from a
running process with an attached gdb and installed dbgsym package.

0x7f373b3ad458 in __memset_sse2_unaligned at 
../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:120
0x55d7e2f68a64 in pcalloc at pool.c:620
0x55d7e2f8c778 in pr_response_add at response.c:281
0x7f373ab45822 in handle_userauth_req at auth.c:1502
0x7f373ab2de69 in sftp_ssh2_packet_handle at packet.c:1608
0x7f373ab29f12 in sftp_cmd_loop at mod_sftp.c:302
0x55d7e2f65222 in fork_server at main.c:1481
0x55d7e2f65acd in daemon_loop at main.c:1718
0x55d7e2f639bf in standalone_main at main.c:1903
0x7f373b32f09b in __libc_start_main () at ../csu/libc-start.c:308
0x55d7e2f63fca in _start () at main.c:2332

https://sources.debian.org/src/proftpd-dfsg/1.3.6-4+deb10u3/src/pool.c/#L620
https://sources.debian.org/src/proftpd-dfsg/1.3.6-4+deb10u3/src/response.c/#L281

Could the call to palloc just before have failed to allocate memory?

Kind regards,
Bernhard



Bug#951412: proftpd-basic: segfault when logging in through sftp

2020-02-16 Thread Tomas Janousek
Package: proftpd-basic
Version: 1.3.6-4+deb10u3
Severity: normal

It appears bug #839880 reappeared in current Debian stable:

2020-02-16 09:02:15,218  proftpd[114] : ProFTPD 1.3.6 
(stable) (built Tue Dec 31 2019 11:06:17 UTC) standalone mode STARTUP
2020-02-16 09:02:29,812  proftpd[373]  (): 
-BEGIN STACK TRACE-
2020-02-16 09:02:29,812  proftpd[373]  (): 
[0] /lib/x86_64-linux-gnu/libc.so.6(+0xa2458) [0x7ff345701458]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[1] /lib/x86_64-linux-gnu/libc.so.6(+0xa2458) [0x7ff345701458]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[2] proftpd: (authenticating) - (connecting): IDLE(pcalloc+0x24) 
[0x55bc7f1f6a64]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[3] proftpd: (authenticating) - (connecting): IDLE(pr_response_add+0xe8) 
[0x55bc7f21a778]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[4] /usr/lib/proftpd/mod_sftp.so(sftp_auth_handle+0xf12) [0x7ff344a9c822]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[5] /usr/lib/proftpd/mod_sftp.so(sftp_ssh2_packet_handle+0x249) [0x7ff344a84e69]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[6] /usr/lib/proftpd/mod_sftp.so(+0x14f12) [0x7ff344a80f12]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[7] proftpd: (authenticating) - (connecting): IDLE(+0x1d222) [0x55bc7f1f3222]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[8] proftpd: (authenticating) - (connecting): IDLE(+0x1dacd) [0x55bc7f1f3acd]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[9] proftpd: (authenticating) - (connecting): IDLE(main+0x59f) [0x55bc7f1f19bf]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[10] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7ff34568309b]
2020-02-16 09:02:29,812  proftpd[373]  (): 
[11] proftpd: (authenticating) - (connecting): IDLE(_start+0x2a) 
[0x55bc7f1f1fca]
2020-02-16 09:02:29,812  proftpd[373]  (): 
-END STACK TRACE-
2020-02-16 09:02:29,812  proftpd[373]  (): 
ProFTPD terminating (signal 11)
2020-02-16 09:19:06,514  proftpd[114] : ProFTPD killed 
(signal 15)
2020-02-16 09:19:06,541  proftpd[114] : ProFTPD 1.3.6 
standalone mode SHUTDOWN

I tried upgrading to 1.3.6b-3 from testing/unstable and that version works
like a charm, but I'd prefer not having to use libc and proftpd from unstable
on this particular box. :-/

(the following is edited manually as I'm reporting the bug from my laptop, not
from the LXC container that runs this)

-- System Information:
Debian Release: buster/stable
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable')
Architecture: amd64 (x86_64)

Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- 
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, http://work.lisk.in/