Bug#951984: tree-puzzle: FTBFS: mpi.h:322:57: error: static assertion failed: "MPI_Address was removed in MPI-3.0. Use MPI_Get_address instead."
Control: tags -1 pending Hi Alberto, On Sun, Apr 19, 2020 at 03:43:04PM +0200, Alberto Garcia wrote: > On Sun, Apr 05, 2020 at 07:37:28PM +0200, Alberto Garcia wrote: > > The attached patch fixes the build. The latest upstream release > > candidate still uses the old symbol btw. > > I'm also attaching the full debdiff. I commited your patch to Git. However, I delayed the upload a bit since I'd like to switch to the latest upstream release candidate. Unfortunately the build time tests are not working - which is the same for the current version ... these were just not run in previous builds. :-( I'll ping others for investigating into this issue. Thanks a lot so far, Andreas. -- http://fam-tille.de
Bug#951984: tree-puzzle: FTBFS: mpi.h:322:57: error: static assertion failed: "MPI_Address was removed in MPI-3.0. Use MPI_Get_address instead."
On Sun, Apr 05, 2020 at 07:37:28PM +0200, Alberto Garcia wrote: > The attached patch fixes the build. The latest upstream release > candidate still uses the old symbol btw. I'm also attaching the full debdiff. Berto diff -Nru tree-puzzle-5.2/debian/changelog tree-puzzle-5.2/debian/changelog --- tree-puzzle-5.2/debian/changelog 2018-10-16 11:06:43.0 +0200 +++ tree-puzzle-5.2/debian/changelog 2020-04-19 15:29:52.0 +0200 @@ -1,3 +1,11 @@ +tree-puzzle (5.2-11.1) unstable; urgency=medium + + * Non-maintainer upload. + * debian/patches/fix-mpi3-build.patch: +- Fix FTBFS due to the new MPI-3.0 API (Closes: #951984). + + -- Alberto Garcia Sun, 19 Apr 2020 15:29:52 +0200 + tree-puzzle (5.2-11) unstable; urgency=medium * debhelper 11 diff -Nru tree-puzzle-5.2/debian/patches/fix-mpi3-build.patch tree-puzzle-5.2/debian/patches/fix-mpi3-build.patch --- tree-puzzle-5.2/debian/patches/fix-mpi3-build.patch 1970-01-01 01:00:00.0 +0100 +++ tree-puzzle-5.2/debian/patches/fix-mpi3-build.patch 2020-04-19 15:26:28.0 +0200 @@ -0,0 +1,22 @@ +From: Alberto Garcia +Subject: Replace obsolete MPI-2.0 API with their MPI-3.0 equivalents +Bug-Debian: https://bugs.debian.org/951984 +Index: tree-puzzle-5.2/src/ppuzzle.c +=== +--- tree-puzzle-5.2.orig/src/ppuzzle.c tree-puzzle-5.2/src/ppuzzle.c +@@ -21,11 +21,14 @@ + #endif + + #define EXTERN extern ++#define OMPI_OMIT_MPI1_COMPAT_DECLS 1 + + #include + #include + #include "ppuzzle.h" + ++#define MPI_Address MPI_Get_address ++#define MPI_Type_struct MPI_Type_create_struct + + int PP_IamMaster; + int PP_IamSlave; diff -Nru tree-puzzle-5.2/debian/patches/series tree-puzzle-5.2/debian/patches/series --- tree-puzzle-5.2/debian/patches/series 2018-10-16 11:06:43.0 +0200 +++ tree-puzzle-5.2/debian/patches/series 2020-04-19 15:26:28.0 +0200 @@ -1,3 +1,4 @@ 20_no_copy_of_sprng.patch tests-need-bash.patch spelling.patch +fix-mpi3-build.patch
Bug#951984: tree-puzzle: FTBFS: mpi.h:322:57: error: static assertion failed: "MPI_Address was removed in MPI-3.0. Use MPI_Get_address instead."
Control: tags -1 patch On Sun, Feb 23, 2020 at 08:39:23AM +0100, Lucas Nussbaum wrote: > > 2842 | #define MPI_Address(...) > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_Address, MPI_Get_address) > > 2850 | #define MPI_Type_struct(...) > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_Type_struct, MPI_Type_create_struct) So tree-puzzle uses two symbols from MPI-2.0 that have been deprecated in MPI-3.0. Fortunately in both cases the only change is the name of the symbol, and it's not necessary to do anything else. See here for details: https://www.open-mpi.org/faq/?category=mpi-removed The attached patch fixes the build. The latest upstream release candidate still uses the old symbol btw. Berto From: Alberto Garcia Subject: Replace obsolete MPI-2.0 API with their MPI-3.0 equivalents Bug-Debian: https://bugs.debian.org/951984 Index: tree-puzzle-5.2/src/ppuzzle.c === --- tree-puzzle-5.2.orig/src/ppuzzle.c +++ tree-puzzle-5.2/src/ppuzzle.c @@ -21,11 +21,14 @@ #endif #define EXTERN extern +#define OMPI_OMIT_MPI1_COMPAT_DECLS 1 #include #include #include "ppuzzle.h" +#define MPI_Address MPI_Get_address +#define MPI_Type_struct MPI_Type_create_struct int PP_IamMaster; int PP_IamSlave;
Bug#951984: tree-puzzle: FTBFS: mpi.h:322:57: error: static assertion failed: "MPI_Address was removed in MPI-3.0. Use MPI_Get_address instead."
Source: tree-puzzle
Version: 5.2-11
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20200222 ftbfs-buster
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> gcc -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now sgamma.o sml1.o
> sml2.o smlparam.o smodel1.o smodel2.o spuzzle1.o spuzzle2.o spstep.o sutil.o
> sconsensus.o streesort.o streetest.o -lsprng -lm -o puzzle
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./gamma.c && mv
> gamma.o pgamma.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./ml1.c && mv
> ml1.o pml1.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./ml2.c && mv
> ml2.o pml2.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./mlparam.c &&
> mv mlparam.o pmlparam.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./model1.c &&
> mv model1.o pmodel1.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./model2.c &&
> mv model2.o pmodel2.o
> /usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I. -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -c ./puzzle1.c &&
> mv puzzle1.o ppuzzle1.o
> ./puzzle1.c: In function ‘readallquarts’:
> ./puzzle1.c:294:3: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 294 | fscanf(ifp, "TREE-PUZZLE\n");
> | ^~~~
> ./puzzle1.c:295:3: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 295 | fscanf(ifp, "%s\n\n", dummyversion);
> | ^~~
> ./puzzle1.c:297:3: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 297 | fscanf(ifp, "species: %d\n", );
> | ^~~
> ./puzzle1.c:298:3: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 298 | fscanf(ifp, "quartets: %lu\n", );
> | ^~~~
> ./puzzle1.c:299:3: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 299 | fscanf(ifp, "bytes: %lu\n\n", );
> | ^~
> ./puzzle1.c:322:6: warning: ignoring return value of ‘fscanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 322 | fscanf(ifp, "%s\n", dummyname);
> | ^~
> ./puzzle1.c:335:3: warning: ignoring return value of ‘fread’, declared with
> attribute warn_unused_result [-Wunused-result]
> 335 | fread(&(quartetinfo[0]), sizeof(char), blocklen, ifp);
> | ^
> ./puzzle1.c: In function ‘setoptions’:
> ./puzzle1.c:718:8: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 718 |scanf("%d", );
> |^
> ./puzzle1.c:776:8: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 776 |scanf("%lf", );
> |^~
> ./puzzle1.c:795:8: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 795 |scanf("%lf", );
> |^~~
> ./puzzle1.c:813:8: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 813 |scanf("%d", );
> |^
> ./puzzle1.c:915:9: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 915 | scanf("%d", );
> | ^~
> ./puzzle1.c:1115:9: warning: ignoring return value of ‘scanf’, declared with
> attribute warn_unused_result [-Wunused-result]
> 1115 |
