Bug#952657: Document OpenSSL linking exception

2020-02-27 Thread Bastian Germann
Am 27.02.20 um 06:48 schrieb Pino Toscano:
> In data mercoledì 26 febbraio 2020 23:40:52 CET, Bastian Germann ha
> scritto:
>> Package: libqt5network5 Severity: normal
>>
>> This package links to libssl.
>
> No, it does not.
>
> ...
>
> QtNetwork can be built to link against OpenSSL, and we built it to
> dlopen it instead, exactly for the reasons mentioned. The
> dependency of the libqt5network5 package is added with a trivial
> test program at build time, so installing libqt5network5 pulls the
> OpenSSL library it was built against (easier to track & rebuild on
> OpenSSL SONAME bumps).
>

You are right. Sorry about that. Adding the license exception in
debian/copyright would still benefit reverse dependent GPL packages
that want to add a dependency on OpenSSL themselves and have to look
this up in the source otherwise.



Bug#952657: Document OpenSSL linking exception

2020-02-26 Thread Bastian Germann
Package: libqt5network5
Severity: normal

This package links to libssl. An OpenSSL linking exception is included
in src/network/doc/src/qtnetwork.qdoc and files in src/network/ssl but
it is not documented in debian/copyright. Please include it there.

Please also have a look at #924937. libqt5network5 has many GPL licensed
reverse dependencies, similar to libpq5, some of which do not have this
exception. Please consider configuring with -openssl-runtime because
that would make this issue less important for these reverse dependencies
Then one could install them without libssl, which would not make them a
derivative work of OpenSSL.