Bug#955501: yaz: please make the build reproducible
On Thu, Apr 2, 2020 at 1:13 PM Chris Lamb wrote: > Hi Adam, > > > > > We are using yaz-config for side-by-side builds which means we > can't > > > > apply that patch as is. > > > > > > What do you mean by side-by-side build? I have not come across this > > > > Probably a bad term, that I invented. It just means that we can use > > yaz-config from another tree without installing yaz. > > > > cd yaz > > ./configure && make > > cd ../idzebra > > ./configure # looks in ../yaz for yaz-config > > make > > Ah, I see. > > > Anyway the issue is now fixed in upstream, as follows: > > > > > https://github.com/indexdata/yaz/commit/370dece3e9cb2fe4feb8c6e1780b46de8bc7fa9d > > Hm, I am not quite sure how this will help — @abs_top_srcdir@ will > still be interpolated and therefore will vary across builds... just in > a different place. > yaz-config in root will have it. But that's not installed. util/yaz-config is going to be in /usr/bin or other.. That does not have build stuff in it. / Adam > > > Best wishes, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org 🍥 chris-lamb.co.uk >`- >
Bug#955501: yaz: please make the build reproducible
Hi Adam, > > > We are using yaz-config for side-by-side builds which means we can't > > > apply that patch as is. > > > > What do you mean by side-by-side build? I have not come across this > > Probably a bad term, that I invented. It just means that we can use > yaz-config from another tree without installing yaz. > > cd yaz > ./configure && make > cd ../idzebra > ./configure # looks in ../yaz for yaz-config > make Ah, I see. > Anyway the issue is now fixed in upstream, as follows: > > https://github.com/indexdata/yaz/commit/370dece3e9cb2fe4feb8c6e1780b46de8bc7fa9d Hm, I am not quite sure how this will help — @abs_top_srcdir@ will still be interpolated and therefore will vary across builds... just in a different place. Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Bug#955501: yaz: please make the build reproducible
On Thu, Apr 2, 2020 at 12:58 AM Chris Lamb wrote: > Hi Adam, > > > We are using yaz-config for side-by-side builds which means we can't > > apply that patch as is. > > What do you mean by side-by-side build? I have not come across this > Probably a bad term, that I invented. It just means that we can use yaz-config from another tree without installing yaz. cd yaz ./configure && make cd ../idzebra ./configure # looks in ../yaz for yaz-config make Anyway the issue is now fixed in upstream, as follows: https://github.com/indexdata/yaz/commit/370dece3e9cb2fe4feb8c6e1780b46de8bc7fa9d / Adam > term before. (Do you mean you are Build-Depending on yaz from another > package?) > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org 🍥 chris-lamb.co.uk >`- >
Bug#955501: yaz: please make the build reproducible
Hi Adam, > We are using yaz-config for side-by-side builds which means we can't > apply that patch as is. What do you mean by side-by-side build? I have not come across this term before. (Do you mean you are Build-Depending on yaz from another package?) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Bug#955501: yaz: please make the build reproducible
Thanks for the patch. We are using yaz-config for side-by-side builds which means we can't apply that patch as is.. the echo_source definition.. We will have to make two yaz-config's .. One for the side-by-side build which obviously will have those build directories and another one to be installed in /usr/bin without those. / Adam On Wed, Apr 1, 2020 at 7:33 PM Chris Lamb wrote: > Source: yaz > Version: 5.29.0-2 > Severity: wishlist > Tags: patch > User: reproducible-bui...@lists.alioth.debian.org > Usertags: buildpath > X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org > > Hi, > > Whilst working on the Reproducible Builds effort [0] we noticed that > yaz could not be built reproducibly. > > This is because it embeds the absolute build path into the /usr/bin/ > yaz-config file. > > A patch is attached. As this path will not exist at runtime, assuming > that yaz works today (!), then the application of this patch could be > reasoned to therefore be harmless. > > [0] https://reproducible-builds.org/ > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`- >
Bug#955501: yaz: please make the build reproducible
Source: yaz Version: 5.29.0-2 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: buildpath X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0] we noticed that yaz could not be built reproducibly. This is because it embeds the absolute build path into the /usr/bin/ yaz-config file. A patch is attached. As this path will not exist at runtime, assuming that yaz works today (!), then the application of this patch could be reasoned to therefore be harmless. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.0 +0100 --- b/debian/patches/reproducible-build.patch 2020-04-01 18:15:31.120487468 +0100 @@ -0,0 +1,17 @@ +Description: Make the build reproducible +Author: Chris Lamb +Last-Update: 2020-04-01 + +--- yaz-5.29.0.orig/yaz-config.in yaz-5.29.0/yaz-config.in +@@ -14,8 +14,8 @@ echo_include=no + echo_source=yes + echo_lalibs=no + echo_comp=no +-src_root="@abs_top_srcdir@" +-build_root="@abs_top_builddir@" ++src_root="/nonexistent" ++build_root="/nonexistent" + ICU_LIBS="@ICU_LIBS@" + ICU_CPPFLAGS="@ICU_CPPFLAGS@" + SSL_LIBS="@SSL_LIBS@" --- a/debian/patches/series 2020-04-01 18:10:23.033987972 +0100 --- b/debian/patches/series 2020-04-01 18:15:30.084479062 +0100 @@ -1 +1,2 @@ yaz_diag_to_str.patch +reproducible-build.patch
