Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
Package: wnpp Severity: wishlist Owner: Raphael Medaer * Package name: vim-gitgutter Version : 20200414 Upstream Author : Andrew Stewart * URL : https://github.com/airblade/vim-gitgutter * License : MIT Programming Lang: vim Description : A Vim plugin which shows a git diff in the sign column This Vim plugin shows a git diff in the 'gutter' (sign column). It shows which lines have been added, modified, or removed. You can also preview, stage, and undo individual hunks; and stage partial hunks. The plugin also provides a hunk text object. FYI There is a (less popular) alternative: vim-signify I would enjoy to maintain this package. Maybe in PkgVim team ? I'm not looking for co-maintainer, but a mentor/sponsor for sure. I already created the Debian package. I'll complete it with changelog referencing this bug id.
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
On Sat, Apr 18, 2020 at 10:24:28PM +0200, Raphael Medaer wrote: > This Vim plugin shows a git diff in the 'gutter' (sign column). It shows > which lines have been added, modified, or removed. You can also preview, > stage, and undo individual hunks; and stage partial hunks. The plugin also > provides a hunk text object. > > FYI There is a (less popular) alternative: vim-signify > > I would enjoy to maintain this package. Maybe in PkgVim team ? Sure, I can add you to vim-team. > I'm not looking for co-maintainer, but a mentor/sponsor for sure. > I already created the Debian package. I can try to answer questions, although there may be delays. I have limited time for Debian. On Sun, Apr 19, 2020 at 01:22:53PM +0200, Raphael Medaer wrote: > I pushed a first version of the package here: > https://salsa.debian.org/rmedaer/vim-gitgutter >From a (very quick) initial look, I would highly suggest dropping the use of vim-addon-manager and using dh-vim-addon instead. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
Hi James, I did the changes you suggested (https://salsa.debian.org/rmedaer/vim-gitgutter/-/commit/8e9bd0944c7a9edb91dc7056996c8d16446a93fd) The vim plugin is "optional". It means that users will have to add `packadd gitgutter` in their vimrc. Should I document that somewhere ? I also created a project in vim-team group (https://salsa.debian.org/vim-team/vim-gitgutter) however I don't have permissions to create branches. Could you change my role for this project ? I guess it's better to put it in vim-team group (instead of my own namespace). Kind regards, -- Raphaël Medaer
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
On Tue, Apr 21, 2020 at 11:01:00AM +0200, Raphael Medaer wrote: > Hi James, > > I did the changes you suggested > (https://salsa.debian.org/rmedaer/vim-gitgutter > /-/commit/8e9bd0944c7a9edb91dc7056996c8d16446a93fd) > The vim plugin is "optional". It means that users will have to add `packadd > gitgutter` in their vimrc. Should I document that somewhere ? If gitgutter is unintrusive by default and respects the normal conventions to disable the plugin (i.e., "let g:loaded_gitgutter = 1" in the vimrc will stop it from doing anything), then it may be better to just enable it by default. Then there aren't any instructions required after installing the package. Is there a particular reason it isn't enabled for neovim? > I also created a project in vim-team group (https://salsa.debian.org/vim-team/ > vim-gitgutter) however I don't have permissions to create branches. > Could you change my role for this project ? You're maintainer for the repo. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
Hi James, > If gitgutter is unintrusive by default and respects the normal > conventions to disable the plugin (i.e., "let g:loaded_gitgutter = 1" in > the vimrc will stop it from doing anything), then it may be better to > just enable it by default. Then there aren't any instructions required > after installing the package. Done. (see https://salsa.debian.org/vim-team/vim-gitgutter/-/commit/632d7276c14098e49df8464e7caafa7637537b79) > Is there a particular reason it isn't enabled for neovim? No. I added neovim support. (see https://salsa.debian.org/vim-team/vim-gitgutter/-/commit/86a755dc29484aaa0d2a27b74ea0384a242a8a71) > You're maintainer for the repo. Many thanks. Let me know if there is still something to change. Otherwise I'm ready to push on `https://mentors.debian.net`. Btw, here is my GPG fingerprint: 4096R/D4D7 6442 3DCE A9FC 9032 7C78 FE29 1960 52B4 7DF1 Kind regards, -- Raphaël Medaer
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
On Wed, Apr 22, 2020 at 02:26:54PM +0200, Raphael Medaer wrote: > Let me know if there is still something to change. For a brand new package, it's probably best to go with the current stable debhelper version (12). Similarly, it would be a good idea to ensure you're abiding by current Policy and indicate such in Standards-Version. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
> For a brand new package, it's probably best to go with the current > stable debhelper version (12). Done (see https://salsa.debian.org/vim-team/vim-gitgutter/-/commit/eb379b663099d62e9195cadc64edec5b4fc42fdf) > Similarly, it would be a good idea to > ensure you're abiding by current Policy and indicate such in > Standards-Version. Done (see https://salsa.debian.org/vim-team/vim-gitgutter/-/commit/96c98f20716343cf8e1b316249f7f0eb105b5274) After reviewing the last Debian policy I figured out that the package version was not good. I prefixed the date with `0~` to avoid bug if the upstream do a release. Btw, I checked with the author his intentions on this topic. See link in commit https://salsa.debian.org/vim-team/vim-gitgutter/-/commit/612eca0beb955d4eef0800d7cab4788abd2c4003 Many thanks James for helping me with your reviews. -- Raphaël Medaer
Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column
Hi James, I uploaded a first version on mentors (https://mentors.debian.net/package/vim-gitgutter). I'm wondering if I have to create another bug (RFS + ITP) ? Would you accept to follow up this package as sponsor ? Or would you prefer that I look for another sponsor ? Kind regards, -- Raphaël Medaer
Bug#958139: Info received (Bug#958139: ITP: vim-gitgutter -- A Vim plugin which shows a git diff in the sign column)
Transferred the project in vim-team group: https://salsa.debian.org/vim-team/vim-gitgutter -- Raphaël Medaer