Bug#960804: buster-pu: package pdfchain/pdfchain/1:0.4.4.2-1+deb10u1

2020-05-17 Thread Adam D. Barratt
Control: tags -1 + confirmed

On Sat, 2020-05-16 at 22:36 +0200, Johann Felix Soden wrote:
> To fix a severe bug that leads to application crashes,
> I would like to upload pdfchain (debdiff attached)
> 
> The used patch is tested in testing & sid with pdfchain/1:0.4.4.2-2
> and confirmed by users to fix the bug [1]. It is part of the
> OpenSuse's pdfchain package [2].
> 

Please go ahead.

Regards,

Adam



Bug#960804: buster-pu: package pdfchain/pdfchain/1:0.4.4.2-1+deb10u1

2020-05-16 Thread Johann Felix Soden
Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello!

To fix a severe bug that leads to application crashes,
I would like to upload pdfchain (debdiff attached)

The used patch is tested in testing & sid with pdfchain/1:0.4.4.2-2 and
confirmed by users to fix the bug [1]. It is part of the OpenSuse's pdfchain
package [2].

Thanks in advance!


[1] cf.https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=%23725859#37
[2] https://build.opensuse.org/request/show/369684
diff -Nru pdfchain-0.4.4.2/debian/changelog pdfchain-0.4.4.2/debian/changelog
--- pdfchain-0.4.4.2/debian/changelog   2016-12-31 16:19:18.0 +0100
+++ pdfchain-0.4.4.2/debian/changelog   2020-05-16 22:27:33.0 +0200
@@ -1,3 +1,9 @@
+pdfchain (1:0.4.4.2-1+deb10u1) buster; urgency=medium
+
+  * Fix crash at startup. (LP: #1685778) (Closes: #725859)
+
+ -- Johann Felix Soden   Sat, 16 May 2020 22:27:33 +0200
+
 pdfchain (1:0.4.4.2-1) unstable; urgency=medium
 
   * New upstream version.
diff -Nru pdfchain-0.4.4.2/debian/patches/fix_crash_on_startup 
pdfchain-0.4.4.2/debian/patches/fix_crash_on_startup
--- pdfchain-0.4.4.2/debian/patches/fix_crash_on_startup1970-01-01 
01:00:00.0 +0100
+++ pdfchain-0.4.4.2/debian/patches/fix_crash_on_startup2020-05-08 
22:39:55.0 +0200
@@ -0,0 +1,130 @@
+From: =?utf-8?q?Hubert_Figui=C3=A8re?= 
+Date: Wed, 9 Mar 2016 14:49:58 -0500
+Subject: Fix crash because the RadioButtonGroup was contructed AFTER the
+ RadioButton.
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 8bit
+
+Description: Fix crash
+ because the RadioButtonGroup was contructed AFTER the RadioButton.
+Author: Hubert Figuière 
+Bug-Debian: https://bugs.debian.org/725859
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/pdfchain/+bug/1685778
+Bug-openSUSE: https://bugzilla.suse.com/show_bug.cgi?id=970530
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+---
+ src/window_main_bgst.cc  | 1 -
+ src/window_main_bgst.h   | 8 
+ src/window_main_burst.cc | 1 -
+ src/window_main_burst.h  | 8 
+ src/window_main_tool.cc  | 2 --
+ src/window_main_tool.h   | 6 +++---
+ 6 files changed, 11 insertions(+), 15 deletions(-)
+
+diff --git a/src/window_main_bgst.cc b/src/window_main_bgst.cc
+index a2c1270..cfe9025 100644
+--- a/src/window_main_bgst.cc
 b/src/window_main_bgst.cc
+@@ -37,7 +37,6 @@ cSection_BgSt::cSection_BgSt( Gtk::Window& ref_window )
+   mLabel_SourceFile( _("Document:"), Gtk::ALIGN_END , 
Gtk::ALIGN_CENTER , false ) ,   // label , xalign , yalign , mnemonic
+   mLabel_BgStFile(   _("Layer (PDF):") , Gtk::ALIGN_END , 
Gtk::ALIGN_CENTER , false ) ,
+ 
+-  mRBGroup_BgSt( mRButton_Background.get_group() ) ,
+   mRButton_Background(mRBGroup_BgSt , _("Background") , false ) , 
// group , label , mnemonic
+   mRButton_Stamp( mRBGroup_BgSt , _("Stamp")  
, false ) ,
+ 
+diff --git a/src/window_main_bgst.h b/src/window_main_bgst.h
+index a965291..c49082b 100644
+--- a/src/window_main_bgst.h
 b/src/window_main_bgst.h
+@@ -64,13 +64,13 @@ cSection_BgSt : public Gtk::VBox
+   Gtk::CheckButton
+   mCButton_Multiple;
+ 
+-  Gtk::RadioButton// Declaration of 
Gtk::RadioButton before Gtk::RadioButtonGroup!!!
++  Gtk::RadioButtonGroup
++  mRBGroup_BgSt;
++
++  Gtk::RadioButton
+   mRButton_Background ,
+   mRButton_Stamp;
+ 
+-  Gtk::RadioButtonGroup   // Declaration of 
Gtk::RadioButtonGroup behind Gtk::RadioButton!!!
+-  mRBGroup_BgSt;
+-
+   // Derived Widgets
+   cFCButton_Pdf
+   mFCButton_SourceFile ,
+diff --git a/src/window_main_burst.cc b/src/window_main_burst.cc
+index dd3ded3..88a6484 100644
+--- a/src/window_main_burst.cc
 b/src/window_main_burst.cc
+@@ -62,7 +62,6 @@ cSection_Burst::cSection_Burst( Gtk::Window& ref_window )
+   mLabel_Digits( _("Digits:")   , Gtk::ALIGN_END , Gtk::ALIGN_CENTER 
, false ),
+   mLabel_Suffix( _("Suffix:")   , Gtk::ALIGN_END , Gtk::ALIGN_CENTER 
, false ),
+ 
+-  mRBGroup_CounterDigits( mRButton_Auto.get_group() ),
+   mRButton_Auto(   mRBGroup_CounterDigits , _("Auto"), false ),   
// group , label , mnemonic
+   mRButton_Manual( mRBGroup_CounterDigits , _("Manual:") , false ),
+ 
+diff --git a/src/window_main_burst.h b/src/window_main_burst.h
+index e6dabd7..eae679d 100644
+--- a/src/window_main_burst.h
 b/src/window_main_burst.h
+@@ -118,13 +118,13 @@ cSection_Burst : public Gtk::VBox
+   Gtk::SpinButton // Declaration 
of Gtk::SpinButton behind Glib::RefPtr!!!
+   mSButton_Digits;
+ 
+-  Gtk::RadioButton