Bug#963244: mozc FTBFS with Protobuf 3.12.3

2020-07-10 Thread Benjamin Poirier
Source: mozc
Version: 2.23.2815.102+dfsg-9
Followup-For: Bug #963244

FYI, the following patch fixes the build failure,
https://github.com/google/mozc/issues/460#issuecomment-489511210



Bug#963244: mozc FTBFS with Protobuf 3.12.3

2020-06-21 Thread GCS
Source: mozc
Severity: normal
Justification: fails to build from source (but built successfully in the past)
Tags: upstream ftbfs

Hi,

Soon the Protobuf transition will start. Your package FTBFS with the Protobuf
3.12.3-1 version, currently in experimental. The relevant lines hopefully:
/usr/bin/g++ -MMD -MF
obj/dictionary/user_dictionary.user_dictionary.o.d -DOS_LINUX
-DMOZC_BUILD -DCHANNEL_DEV -DENABLE_GTK_RENDERER -DNDEBUG
-DQT_NO_DEBUG -DNO_LOGGING -DIGNORE_HELP_FLAG -DIGNORE_INVALID_FLAG
'-I/build/mozc-2.23.2815.102+dfsg/src' -Igen -Igen/proto_out -Wall
-Wno-char-subscripts -Wno-sign-compare -Wno-deprecated-declarations
-Wwrite-strings -Wno-unknown-warning-option
-Wno-inconsistent-missing-override -fPIC -fno-exceptions
-fmessage-length=0 -fno-strict-aliasing -funsigned-char -pipe -pthread
-fno-omit-frame-pointer -fstack-protector --param=ssp-buffer-size=4
-O2 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/build/mozc-2.23.2815.102+dfsg=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-deprecated  -c
../../dictionary/user_dictionary.cc -o
obj/dictionary/user_dictionary.user_dictionary.o
In file included from ../../dictionary/user_dictionary.cc:51:
/build/mozc-2.23.2815.102+dfsg/src/dictionary/user_dictionary_storage.h:77:7:
error: cannot derive from 'final' base
'mozc::user_dictionary::UserDictionaryStorage' in derived type
'mozc::UserDictionaryStorage'
   77 | class UserDictionaryStorage : public
user_dictionary::UserDictionaryStorage {
  |   ^

Please contact your upstream or try to fix yourself.

Thanks,
Laszlo/GCS