Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Control: forwarded -1 https://github.com/lodash-archive/lodash-cli/pull/141 On Sun, Jul 26, 2020 at 16:12, Nicolas Mora wrote: I'm not sure yet if this would fix the bug but in all the build log errors, I see that the file /usr/share/nodejs/lodash/_baseOrderBy.js is always the source of the error. The file _baseOrderBy.js in the package seems buggy for an unresolved reson. File in node-lodash unstable package: 4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/ File in node-lodash bullseye package 4.17.15+dfsg-2 _baseOrderBy.js https://paste.debian.net/1157887/ In the unstable version, the call to isArray line 24 is the root of errors. Also, I see that the upstream version 4.17.19 isn't tagged as latest release, 4.17.16 is, maybe it's worth a try to package 4.17.16 instead? I think I found the correct way, https://github.com/lodash-archive/lodash-cli/pull/141 and now node-babel7 built fine. I'll upload both now.
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Le 26/07/2020 à 18:54, Pirate Praveen a écrit : > > > On Sun, Jul 26, 2020 at 19:35, Adrian Bunk wrote: >> On Sun, Jul 26, 2020 at 09:55:47PM +0530, Pirate Praveen wrote: >>> I'm wondering if this will require another bootstraping cycle as >>> node-babel7 >>> autopkgtest is also broken and it depends on itself. >> >> If the problem is in node-lodash and gets fixed there, >> shouldn't this fix everything? > > I don't think the problem is in lodash as I can see babel upstream is > already using lodash 4.17.19 in their yarn.lock > https://github.com/babel/babel/blob/f7964a9ac51356f7df6404a25b27ba1cffba1ba7/yarn.lock#L7114 Hi, our lodash build does not provide the same result than npm package. > I think babel needs to use the same version of lodash it was built with > and a breaking change in lodash was released as a minor/patch > release/security release. > > I think it is becoming more and more common to break API during security > releases (we had to face this in rack/rails in ruby team). > > Babel build situation is indeed a mess. the problem is in lodash. > They are dicussing removing lodash from babel though see > https://github.com/babel/babel/pull/11789
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Le 20-07-26 à 18 h 01, Pirate Praveen a écrit :
>
>>
>> File in node-lodash unstable package:
>> 4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/
>>
I made a dirty hack to check my theory and it looks like if I patch this
file by replacing 'isArray' with 'Array.IsArray' or if I append 'isArray
= require('./isArray')', I'm able to build broken packages like
node-babel7 or glewlwyd.
The only way I found to patch the package node-lodash is to manually
change the file lodash.js here:
https://salsa.debian.org/js-team/node-lodash/-/blob/master/lodash.js#L3724
and replacing 'isArray' with 'Array.IsArray'.
/Nicolas
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Quoting Pirate Praveen (2020-07-26 21:07:19) > Control: reopen -1 > > On Mon, Jul 27, 2020 at 00:32, Pirate Praveen > wrote: > > This did not fix the issue :( So we have to reopen this bug once the > > upload reaches the archive (which will close this bug as fixed). > > Thanks to the brave new world of embedding eveything and reducing the > number of js packages. Complicated build systems in favor of reducing > the metadata size, ftw! Only the package uploader can be blamed for embedding _everything_! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
On 2020, ജൂലൈ 27 1:42:32 AM IST, Nicolas Mora wrote: >I'm not sure yet if this would fix the bug but in all the build log >errors, I see that the file /usr/share/nodejs/lodash/_baseOrderBy.js is >always the source of the error. > >The file _baseOrderBy.js in the package seems buggy for an unresolved reson. > >File in node-lodash unstable package: >4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/ > >File in node-lodash bullseye package >4.17.15+dfsg-2 _baseOrderBy.js https://paste.debian.net/1157887/ > >In the unstable version, the call to isArray line 24 is the root of errors. This is possibly introduced by the security fix, but I can't be sure. Hope someone else can clarify. >Also, I see that the upstream version 4.17.19 isn't tagged as latest >release, 4.17.16 is, maybe it's worth a try to package 4.17.16 instead? > >https://github.com/lodash/lodash/releases 4.17.19 is correct as per https://github.com/lodash/lodash/issues/4837#issuecomment-655648024 -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
I'm not sure yet if this would fix the bug but in all the build log errors, I see that the file /usr/share/nodejs/lodash/_baseOrderBy.js is always the source of the error. The file _baseOrderBy.js in the package seems buggy for an unresolved reson. File in node-lodash unstable package: 4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/ File in node-lodash bullseye package 4.17.15+dfsg-2 _baseOrderBy.js https://paste.debian.net/1157887/ In the unstable version, the call to isArray line 24 is the root of errors. Also, I see that the upstream version 4.17.19 isn't tagged as latest release, 4.17.16 is, maybe it's worth a try to package 4.17.16 instead? https://github.com/lodash/lodash/releases
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Control: reopen -1 On Mon, Jul 27, 2020 at 00:32, Pirate Praveen wrote: This did not fix the issue :( So we have to reopen this bug once the upload reaches the archive (which will close this bug as fixed). Thanks to the brave new world of embedding eveything and reducing the number of js packages. Complicated build systems in favor of reducing the metadata size, ftw!
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
On Sun, Jul 26, 2020 at 22:43, Pirate Praveen wrote: On Sun, Jul 26, 2020 at 22:24, Pirate Praveen wrote: Babel build situation is indeed a mess. It is even worse than I estimated. We can no longer build it with npm DEB_BUILD_PROFILES=pkg.node-babel7.npm sbuild ... HOME=`pwd` npm i npm ERR! code EUNSUPPORTEDPROTOCOL npm ERR! Unsupported URL Type "link:": link:./eslint/babel-eslint-config-internal we have to change it to yarn. This did not fix the issue :( So we have to reopen this bug once the upload reaches the archive (which will close this bug as fixed).
Bug#965353: [Pkg-javascript-devel] Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
On Sun, Jul 26, 2020 at 22:24, Pirate Praveen wrote: Babel build situation is indeed a mess. It is even worse than I estimated. We can no longer build it with npm DEB_BUILD_PROFILES=pkg.node-babel7.npm sbuild ... HOME=`pwd` npm i npm ERR! code EUNSUPPORTEDPROTOCOL npm ERR! Unsupported URL Type "link:": link:./eslint/babel-eslint-config-internal we have to change it to yarn.
Bug#965353: [Pkg-javascript-devel] Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
On Sun, Jul 26, 2020 at 19:35, Adrian Bunk wrote: On Sun, Jul 26, 2020 at 09:55:47PM +0530, Pirate Praveen wrote: I'm wondering if this will require another bootstraping cycle as node-babel7 autopkgtest is also broken and it depends on itself. If the problem is in node-lodash and gets fixed there, shouldn't this fix everything? I don't think the problem is in lodash as I can see babel upstream is already using lodash 4.17.19 in their yarn.lock https://github.com/babel/babel/blob/f7964a9ac51356f7df6404a25b27ba1cffba1ba7/yarn.lock#L7114 I think babel needs to use the same version of lodash it was built with and a breaking change in lodash was released as a minor/patch release/security release. I think it is becoming more and more common to break API during security releases (we had to face this in rack/rails in ruby team). Babel build situation is indeed a mess. They are dicussing removing lodash from babel though see https://github.com/babel/babel/pull/11789
Bug#965353: [Pkg-javascript-devel] Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
On Sun, Jul 26, 2020 at 09:55:47PM +0530, Pirate Praveen wrote: > I'm wondering if this will require another bootstraping cycle as node-babel7 > autopkgtest is also broken and it depends on itself. If the problem is in node-lodash and gets fixed there, shouldn't this fix everything? cu Adrian
Bug#965353: [Pkg-javascript-devel] Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
I'm wondering if this will require another bootstraping cycle as node-babel7 autopkgtest is also broken and it depends on itself.
Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined
Source: node-babel7
Version: 7.10.5+~cs65.71.38-2
Severity: serious
Tags: ftbfs
https://buildd.debian.org/status/fetch.php?pkg=node-babel7&arch=all&ver=7.10.5%2B~cs65.71.38-2&stamp=1595148206&raw=0
...
debian/rules override_dh_auto_build
make[1]: Entering directory '/<>'
rm -f node_modules/@babel/code-frame
cd babel-plugin-dynamic-import-node && babeljs-7 src --out-dir lib
ReferenceError: /<>/babel-plugin-dynamic-import-node/src/index.js:
isArray is not defined
at /usr/share/nodejs/lodash/_baseOrderBy.js:24:7
at arrayMap (/usr/share/nodejs/lodash/_arrayMap.js:19:21)
at baseOrderBy (/usr/share/nodejs/lodash/_baseOrderBy.js:23:17)
at /usr/share/nodejs/lodash/sortBy.js:48:10
at apply (/usr/share/nodejs/lodash/_apply.js:18:25)
at /usr/share/nodejs/lodash/_overRest.js:35:12
at PluginPass.exit
(/usr/share/nodejs/@babel/core/lib/transformation/block-hoist-plugin.js:58:43)
at newFn (/usr/share/nodejs/@babel/traverse/lib/visitors.js:175:21)
at NodePath._call
(/usr/share/nodejs/@babel/traverse/lib/path/context.js:55:20)
at NodePath.call
(/usr/share/nodejs/@babel/traverse/lib/path/context.js:42:17) {
code: 'BABEL_TRANSFORM_ERROR'
}
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 1
