Bug#968004: Should Build-depends on tzdata

2020-08-06 Thread Sebastien Bacher 
Le 06/08/2020 à 15:31, David Bremner a écrit :
> It would be better to add the test only dependency with . If
> you do respin the patch, please add Closes, now that the bug exists.

Thanks,  that makes sense, new patch attached

diff -Nru ledger-3.2.1/debian/changelog ledger-3.2.1/debian/changelog
--- ledger-3.2.1/debian/changelog	2020-08-05 12:46:45.0 +0200
+++ ledger-3.2.1/debian/changelog	2020-08-06 15:01:32.0 +0200
@@ -1,3 +1,11 @@
+ledger (3.2.1-3) unstable; urgency=medium
+
+  * debian/control: 
+- Build-Depends on tzdata , it's needed for the tests
+  (Closes: #968004)
+
+ -- Sebastien Bacher   Thu, 06 Aug 2020 15:01:32 +0200
+
 ledger (3.2.1-2) unstable; urgency=medium
 
   * Bug fix: "Unversioned Python removal in sid/bullseye", thanks to
diff -Nru ledger-3.2.1/debian/control ledger-3.2.1/debian/control
--- ledger-3.2.1/debian/control	2020-08-05 12:46:45.0 +0200
+++ ledger-3.2.1/debian/control	2020-08-06 15:01:32.0 +0200
@@ -8,7 +8,7 @@
 	libboost-date-time-dev, libboost-filesystem-dev,
 	libboost-iostreams-dev, libboost-serialization-dev,
 	libboost-test-dev, man2html-base, python3-dev, texinfo, texlive,
-	libutfcpp-dev, libboost-python-dev, dh-python
+	libutfcpp-dev, libboost-python-dev, dh-python, tzdata 
 Standards-Version: 4.4.1
 Homepage: http://ledger-cli.org
 Vcs-Git: https://salsa.debian.org/debian/ledger.git

Bug#968004: Should Build-depends on tzdata

2020-08-06 Thread David Bremner 
Sebastien Bacher  writes:

> - libutfcpp-dev, libboost-python-dev, dh-python
> + libutfcpp-dev, libboost-python-dev, dh-python, tzdata
>  Standards-Version: 4.4.1
>  Homepage: http://ledger-cli.org
>  Vcs-Git: https://salsa.debian.org/debian/ledger.git

It would be better to add the test only dependency with . If
you do respin the patch, please add Closes, now that the bug exists.

d

Bug#968004: Should Build-depends on tzdata

2020-08-06 Thread Sebastien Bacher 
Package: ledger
Version: 3.2.1-2
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Trying to build on a machine without tzdata the build fail on a test
error [1]

1057 fails with

  -(("/<>/test/regress/1057.test" 1 (21308 60112 0) nil
"www.amazon.fr"
  +(("/<>/test/regress/1057.test" 1 (21308 42112 0) nil
"www.amazon.fr"

The issue has been reported and fixed upstream there
https://github.com/ledger/ledger/commit/d967c348

Even if tzdata is installed by default on the builders it still makes
sense to have in the Build-Depends


Thanks,

[1]
https://launchpadlibrarian.net/492137498/buildlog_ubuntu-groovy-riscv64.ledger_3.2.1-2_BUILDING.txt.gz

diff -Nru ledger-3.2.1/debian/changelog ledger-3.2.1/debian/changelog
--- ledger-3.2.1/debian/changelog	2020-08-05 12:46:45.0 +0200
+++ ledger-3.2.1/debian/changelog	2020-08-06 15:01:32.0 +0200
@@ -1,3 +1,9 @@
+ledger (3.2.1-3) unstable; urgency=medium
+
+  * debian/control: Build-Depends on tzdata, it's needed for the tests
+
+ -- Sebastien Bacher   Thu, 06 Aug 2020 15:01:32 +0200
+
 ledger (3.2.1-2) unstable; urgency=medium
 
   * Bug fix: "Unversioned Python removal in sid/bullseye", thanks to
diff -Nru ledger-3.2.1/debian/control ledger-3.2.1/debian/control
--- ledger-3.2.1/debian/control	2020-08-05 12:46:45.0 +0200
+++ ledger-3.2.1/debian/control	2020-08-06 15:01:32.0 +0200
@@ -8,7 +8,7 @@
 	libboost-date-time-dev, libboost-filesystem-dev,
 	libboost-iostreams-dev, libboost-serialization-dev,
 	libboost-test-dev, man2html-base, python3-dev, texinfo, texlive,
-	libutfcpp-dev, libboost-python-dev, dh-python
+	libutfcpp-dev, libboost-python-dev, dh-python, tzdata
 Standards-Version: 4.4.1
 Homepage: http://ledger-cli.org
 Vcs-Git: https://salsa.debian.org/debian/ledger.git