Bug#968246: dnstwist: Autopkgtest failure due to depgrecation warning with dnspython 2.0.0

2020-08-11 Thread Scott Kitterman
On Tuesday, August 11, 2020 1:38:52 PM EDT Peter Wienemann wrote:
> Hi Scott,
> 
> On 11.08.20 17:54, Scott Kitterman wrote:
> > Unless you object, I'll probably do an NMU to do that since this will
> > block dnspython testing migration.  I'll post a diff to the bug before I
> > do.
> 
> that is fine with me.
> 
> @Security tools team: I requested a review/upload of a new version of
> dnstwist last week [0]. Given Scott's planned NMU it might be good to
> hold off the upload of the new version until the NMU is acknowledged.
> 
> Best regards,
> 
> Peter
> 
> [0] https://lists.debian.org/debian-security-tools/2020/08/msg0.html

Now that you can upload it yourself, how do you want to handle this?

Scott K

signature.asc
Description: This is a digitally signed message part.


Bug#968246: dnstwist: Autopkgtest failure due to depgrecation warning with dnspython 2.0.0

2020-08-11 Thread Samuel Henrique
Hello,

> On Tuesday, August 11, 2020 1:38:52 PM EDT Peter Wienemann wrote:
> > @Security tools team: I requested a review/upload of a new version of
> > dnstwist last week [0]. Given Scott's planned NMU it might be good to
> > hold off the upload of the new version until the NMU is acknowledged.

I'm sorry for that, your request skipped my TODO list, please feel
free to ping me directly on the future:

dcut ftp-master dm --uid "foss...@posteo.de>"  --allow dnstwist
Uploading commands file to ftp.upload.debian.org (incoming: /pub/UploadQueue/)
Picking DM Peter Wienemann  with fingerprint
7F44F1E078290D700045BC275D5F6C020398A60A
Uploading samueloph-1597179981.dak-commands to ftp-master

You should be good to perform the uploads for dnstwist now :)

Regards,

-- 
Samuel Henrique 



Bug#968246: dnstwist: Autopkgtest failure due to depgrecation warning with dnspython 2.0.0

2020-08-11 Thread Scott Kitterman
On Tuesday, August 11, 2020 1:38:52 PM EDT Peter Wienemann wrote:
> Hi Scott,
> 
> On 11.08.20 17:54, Scott Kitterman wrote:
> > Unless you object, I'll probably do an NMU to do that since this will
> > block dnspython testing migration.  I'll post a diff to the bug before I
> > do.
> 
> that is fine with me.
> 
> @Security tools team: I requested a review/upload of a new version of
> dnstwist last week [0]. Given Scott's planned NMU it might be good to
> hold off the upload of the new version until the NMU is acknowledged.
> 
> Best regards,
> 
> Peter
> 
> [0] https://lists.debian.org/debian-security-tools/2020/08/msg0.html

That or you could just add:

Restrictions: allow-stderr

to debian/tests/control in your upload and close the bug in debian/changelog.  
No real need for two uploads.

Scott K

signature.asc
Description: This is a digitally signed message part.


Bug#968246: dnstwist: Autopkgtest failure due to depgrecation warning with dnspython 2.0.0

2020-08-11 Thread Peter Wienemann
Hi Scott,

On 11.08.20 17:54, Scott Kitterman wrote:
> Unless you object, I'll probably do an NMU to do that since this will block 
> dnspython testing migration.  I'll
> post a diff to the bug before I do.

that is fine with me.

@Security tools team: I requested a review/upload of a new version of
dnstwist last week [0]. Given Scott's planned NMU it might be good to
hold off the upload of the new version until the NMU is acknowledged.

Best regards,

Peter

[0] https://lists.debian.org/debian-security-tools/2020/08/msg0.html



Bug#968246: dnstwist: Autopkgtest failure due to depgrecation warning with dnspython 2.0.0

2020-08-11 Thread Scott Kitterman
Package: dnstwist
Version: 0~20200424-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Note: Using FTBTS tag since it's the closest thing we have to this
(since autopkgtest failures block testing migration).

>From the autopkgtest log with python3-dnspython 2.0.0-1:

autopkgtest [11:09:49]: test testdebiandomain:  - - - - - - - - - - results - - 
- - - - - - - -
testdebiandomain FAIL stderr: /usr/bin/dnstwist:618: DeprecationWarning: 
please use dns.resolver.Resolver.resolve() instead
autopkgtest [11:09:49]: test testdebiandomain:  - - - - - - - - - - stderr - - 
- - - - - - - -
/usr/bin/dnstwist:618: DeprecationWarning: please use 
dns.resolver.Resolver.resolve() instead
  domain['dns-ns'] = self.answer_to_list(resolv.query(domain['domain-name'], 
'NS'))
/usr/bin/dnstwist:630: DeprecationWarning: please use 
dns.resolver.Resolver.resolve() instead
  domain['dns-a'] = self.answer_to_list(resolv.query(domain['domain-name'], 
'A'))
/usr/bin/dnstwist:638: DeprecationWarning: please use 
dns.resolver.Resolver.resolve() instead
  domain['dns-'] = self.answer_to_list(resolv.query(domain['domain-name'], 
''))
/usr/bin/dnstwist:647: DeprecationWarning: please use 
dns.resolver.Resolver.resolve() instead
  domain['dns-mx'] = self.answer_to_list(resolv.query(domain['domain-name'], 
'MX'))
autopkgtest [11:09:49]:  summary
testdebiandomain FAIL stderr: /usr/bin/dnstwist:618: DeprecationWarning: 
please use dns.resolver.Resolver.resolve() instead

Since it's just a warning, this could be worked around by allowing
stderr output during the test.  Unless you object, I'll probably do an
NMU to do that since this will block dnspython testing migration.  I'll
post a diff to the bug before I do.

In the longer run, porting to the new .resolve class is a better
solution and is usually pretty trivial (s/query/resolve//).

Scott K

-- System Information:
Debian Release: 10.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-10-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled