Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Le 15/09/2020 à 18:31, Tobias Frost a écrit : > I wouldn't consider use case not using official debian packages too much… > Instead, lets look what policy says on Depends (omitting non relevant > paragraphs) > > The Depends field should be used if the depended-on package is required for > the depending package to provide a significant amount of functionality. > > (I can't judge because I don't know aqemu, but my feeling is Recommends would > be too weak) Ok I think Depends is the right thing too, indeed. >> >> Thanks for your review :) > > To avoid a dead-lock, you say when you're ready? (by removing the moreinfo > tag) > Yes, in fact I was refering to your first mail :) (so not asking for a new review (yet)). -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F| signature.asc Description: OpenPGP digital signature
Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
On Sun, Sep 13, 2020 at 04:33:01PM +0200, Alexis Murzeau wrote: > Hi, > > Thanks for your review :) > > Le 26/08/2020 à 12:39, Tobias Frost a écrit : > > Control: tags -1 moreinfo > > > > Hi Alexis, > > > > this is an incomplete review, 'cause I ran out of time, lunch break was not > > long > > enough :-( > > > > - This should be not an NMU but an QA-Upload so you need to Set the > > maintainer > > to the QA group, as explained here: > > https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning-a-package > > > > [...] > Ok, I've put sources with imported debsnap history in > https://salsa.debian.org/debian/aqemu. > > > > - "(For: #957003)" > > Please close the bug in the changelog; it can always be reopened if it fails > > again…) > > Ok > > > > > - I'm not sure about dropping the Depends on qemu entirely. Does aqemu work > > without qemu installed? If not, you probably need to follow the > > recommendation > > in #966261 > > and add a Depend on qemu-system-XXX | qemu-system-XXX | … (listing all > > archs). > > > > I'm wondering if I should put these as a Recommends instead. > I'm thinking about cases where someone would want to use a different qemu not > packaged, > like a custom one or a manually compiled one. > > But I'm not sure I should handle these cases, what do you think ? I wouldn't consider use case not using official debian packages too much… Instead, lets look what policy says on Depends (omitting non relevant paragraphs) The Depends field should be used if the depended-on package is required for the depending package to provide a significant amount of functionality. (I can't judge because I don't know aqemu, but my feeling is Recommends would be too weak) > > > > > There were other bugs on the packages too. Did you try to triage them? > > (It would be nice to at least report them to upstream, but that's not a show > > stopper for the sponsoring) > > I'm not using aqemu myself, but some of them or probably upstream, and maybe > fixed > since they were reported, but newer versions (0.9.6+) are qualified as not yet > stable by upstream. > I will see if they were already reported or still relevant > (some of them were created in 2012). Cool, thanks for your help here > > > > Many thanks for contributing to Debian! > > > > Thanks for your review :) To avoid a dead-lock, you say when you're ready? (by removing the moreinfo tag) -- tobi
Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Hi, Thanks for your review :) Le 26/08/2020 à 12:39, Tobias Frost a écrit : > Control: tags -1 moreinfo > > Hi Alexis, > > this is an incomplete review, 'cause I ran out of time, lunch break was not > long > enough :-( > > - This should be not an NMU but an QA-Upload so you need to Set the maintainer > to the QA group, as explained here: > https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning-a-package > > [...] Ok, I've put sources with imported debsnap history in https://salsa.debian.org/debian/aqemu. > > - "(For: #957003)" > Please close the bug in the changelog; it can always be reopened if it fails > again…) Ok > > - I'm not sure about dropping the Depends on qemu entirely. Does aqemu work > without qemu installed? If not, you probably need to follow the recommendation > in #966261 > and add a Depend on qemu-system-XXX | qemu-system-XXX | … (listing all archs). > I'm wondering if I should put these as a Recommends instead. I'm thinking about cases where someone would want to use a different qemu not packaged, like a custom one or a manually compiled one. But I'm not sure I should handle these cases, what do you think ? > > There were other bugs on the packages too. Did you try to triage them? > (It would be nice to at least report them to upstream, but that's not a show > stopper for the sponsoring) I'm not using aqemu myself, but some of them or probably upstream, and maybe fixed since they were reported, but newer versions (0.9.6+) are qualified as not yet stable by upstream. I will see if they were already reported or still relevant (some of them were created in 2012). > > Many thanks for contributing to Debian! > Thanks for your review :) -- Alexis Murzeau PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F
Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Control: tags -1 moreinfo Hi Alexis, this is an incomplete review, 'cause I ran out of time, lunch break was not long enough :-( - This should be not an NMU but an QA-Upload so you need to Set the maintainer to the QA group, as explained here: https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning-a-package As this is a QA upload, you can also fix other stuff in the package more freely, like the quite outdated standards version, compat level and other stuff lintian complains about. (This would be at least nice to have, its no show stopper for the sponsoring.) It would be also cool to have this package in git on salsa.debian.org. I can create a repo for you and give you access to it, if you want, just give me your salsa username and I'll do the clicking… (I'll populate the repo using gbp import-dscs --debsnap so that the history of the package is somehow retained.) - "(For: #957003)" Please close the bug in the changelog; it can always be reopened if it fails again…) - I'm not sure about dropping the Depends on qemu entirely. Does aqemu work without qemu installed? If not, you probably need to follow the recommendation in #966261 and add a Depend on qemu-system-XXX | qemu-system-XXX | … (listing all archs). There were other bugs on the packages too. Did you try to triage them? (It would be nice to at least report them to upstream, but that's not a show stopper for the sponsoring) Many thanks for contributing to Debian! Cheers, tobi On Sun, 16 Aug 2020 16:13:29 +0200 Alexis Murzeau wrote: > Package: sponsorship-requests > Severity: important > X-Debbugs-CC: Ignace Mouzannar > > Dear mentors, > > I am looking for a sponsor for a NMU of "aqemu" to fix this RC bug: > #957003 - aqemu: ftbfs with GCC-10 [0] > > And these additional bugs: > #966261 - please drop `qemu' from Depends [1] > #874050 - aqemu depends on meta-package qemu, which pulls in all supported emulation architectures [2] > > The maintainer has not responded to this bug, nor other bugs on > this package and orphaned the package in #955988. > > This NMU : > - Add a patch to fix the build issue with GCC 10 > - Remove the dependency on "qemu" dummy package to let it be removed. >- This is not a RC bug, but I deemed the ratio usefulness/impact > to be high enough to include it with the fact that the package is orphaned. > Let me know if this should be avoided anyway. > > I'm in the process to try to put this package under the Debian group on Salsa when > I will be able to retrieve all available VCS histories from Ignace to keep them on Salsa. > But that's not ready yet. > > > > * Package name: aqemu >Version : 0.9.2-2.4 >Upstream Author : Andrey Rijov, Tobias Gläßer > * URL : https://sourceforge.net/projects/aqemu/, > https://github.com/tobimensch/aqemu > * License : GPL-2+, BSD-3-clause >Section : x11 > > It builds those binary packages: > > aqemu - Qt5 front-end for QEMU and KVM > > To access further information about this package, please visit the > following URL: > https://mentors.debian.net/package/aqemu > > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.9.2-2.4.dsc > > Changes since the last upload to unstable: > aqemu (0.9.2-2.4) unstable; urgency=medium > > * Non-maintainer upload. > * debian/patches/0003-Fix-build-with-GCC-10.patch: > - Fix build with GCC 10 (For: #957003) > * debian/control: > - Drop qemu dummy package from Depends (Closes: 966261, 874050) >
Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Package: sponsorship-requests
Severity: important
X-Debbugs-CC: Ignace Mouzannar
Dear mentors,
I am looking for a sponsor for a NMU of "aqemu" to fix this RC bug:
#957003 - aqemu: ftbfs with GCC-10 [0]
And these additional bugs:
#966261 - please drop `qemu' from Depends [1]
#874050 - aqemu depends on meta-package qemu, which pulls in all supported
emulation architectures [2]
The maintainer has not responded to this bug, nor other bugs on
this package and orphaned the package in #955988.
This NMU :
- Add a patch to fix the build issue with GCC 10
- Remove the dependency on "qemu" dummy package to let it be removed.
- This is not a RC bug, but I deemed the ratio usefulness/impact
to be high enough to include it with the fact that the package is orphaned.
Let me know if this should be avoided anyway.
I'm in the process to try to put this package under the Debian group on Salsa
when
I will be able to retrieve all available VCS histories from Ignace to keep them
on Salsa.
But that's not ready yet.
* Package name: aqemu
Version : 0.9.2-2.4
Upstream Author : Andrey Rijov, Tobias Gläßer
* URL : https://sourceforge.net/projects/aqemu/,
https://github.com/tobimensch/aqemu
* License : GPL-2+, BSD-3-clause
Section : x11
It builds those binary packages:
aqemu - Qt5 front-end for QEMU and KVM
To access further information about this package, please visit the
following URL:
https://mentors.debian.net/package/aqemu
Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.9.2-2.4.dsc
Changes since the last upload to unstable:
aqemu (0.9.2-2.4) unstable; urgency=medium
* Non-maintainer upload.
* debian/patches/0003-Fix-build-with-GCC-10.patch:
- Fix build with GCC 10 (For: #957003)
* debian/control:
- Drop qemu dummy package from Depends (Closes: 966261, 874050)
-- Alexis Murzeau Sun, 16 Aug 2020 15:12:30 +0200
Note: the "For: #957003" is intended to not close the bug automatically as
requested in the
bug description. The bug will be closed only after a successful build.
Source packages diff is in attachment and can be viewed here:
https://salsa.debian.org/amurzeau-guest/aqemu/compare/debian%2F0.9.2-2.3...debian%2F0.9.2-2.4
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=957003
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966261
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874050
Regards,
--
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F
diff --git a/debian/changelog b/debian/changelog
index 24da78a..549387f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+aqemu (0.9.2-2.4) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/0003-Fix-build-with-GCC-10.patch:
+- Fix build with GCC 10 (For: #957003)
+ * debian/control:
+- Drop qemu dummy package from Depends (Closes: 966261, 874050)
+
+ -- Alexis Murzeau Sun, 16 Aug 2020 15:12:30 +0200
+
aqemu (0.9.2-2.3) unstable; urgency=medium
* Non-maintainer upload.
diff --git a/debian/control b/debian/control
index 1c0d123..fb685cb 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,7 @@ Homepage: http://aqemu.sourceforge.net/
Package: aqemu
Architecture: amd64 arm arm64 armel armhf hppa i386 ia64 kfreebsd-amd64
kfreebsd-i386 mips mipsel powerpc powerpcspe ppc64 ppc64el s390x sparc sparc64
x32
-Depends: qemu, ${shlibs:Depends}, ${misc:Depends}, libqt5dbus5
+Depends: ${shlibs:Depends}, ${misc:Depends}, libqt5dbus5
Recommends: qemu-kvm
Description: Qt5 front-end for QEMU and KVM
aqemu is a Qt5 graphical interface used to manage QEMU and KVM virtual
diff --git a/debian/patches/0003-Fix-build-with-GCC-10.patch
b/debian/patches/0003-Fix-build-with-GCC-10.patch
new file mode 100644
index 000..ef15057
--- /dev/null
+++ b/debian/patches/0003-Fix-build-with-GCC-10.patch
@@ -0,0 +1,21 @@
+From: Alexis Murzeau
+Date: Sat, 15 Aug 2020 15:39:47 +0200
+Subject: Fix build with GCC 10 (Closes: #957003)
+
+Forwarded: https://github.com/tobimensch/aqemu/issues/74
+---
+ src/docopt/docopt_value.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/docopt/docopt_value.h b/src/docopt/docopt_value.h
+index 8f32778..bc2b029 100644
+--- a/src/docopt/docopt_value.h
b/src/docopt/docopt_value.h
+@@ -13,6 +13,7 @@
+ #include
+ #include // std::hash
+ #include
++#include
+
+ namespace docopt {
+
diff --git a/debian/patches/series b/debian/patches/series
index 4b5ddb7..5e05242 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
01_qemu_parallel_typo.diff
0002-Remove-VLAN-stuff-QEMU-doesn-t-support-it-anymore.patch
+0003-Fix-build-with-GCC-10.patch
signature.asc
Description: OpenPGP digital signature
