Package: openstack-pkg-tools Version: 116 Severity: important Tags: patch X-Debbugs-Cc: plore...@disroot.org
Dear Maintainers, bumping the Dh_compat level to 13 of opentmpfiles causes FTBFS with the following $ dpkg-buildpackage -us -uc dpkg-buildpackage: info: source package opentmpfiles dpkg-buildpackage: info: source version 0.2+2019.05.21.git.44a55796ba-3 dpkg-buildpackage: info: source distribution unstable dpkg-buildpackage: info: source changed by Lorenzo Puliti <plore...@disroot.org> dpkg-buildpackage: info: host architecture amd64 dpkg-source --before-build . fakeroot debian/rules clean pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions pyversions: missing debian/pyversions file, fall back to supported versions py3versions: no X-Python3-Version in control file, using supported versions debian/rules:16: warning: overriding recipe for target 'override_dh_installinit' /usr/share/openstack-pkg-tools/pkgos.make:43: warning: ignoring old recipe for target 'override_dh_installinit' dh clean dh: warning: The target override_dh_systemd_enable references a now obsolete command and will not be run! dh: error: Aborting due to left over override/hook targets for now removed commands. make: *** [debian/rules:7: clean] Error 255 dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit status 2 dh_systemd_enable is discouraged and in dh compat 13 causes an error, this is documented in Debhelper manpage (section describing Compat level 13) "- The dh command will now error if an override or hook target for an obsolete command are present in debian/rules (e.g. override_dh_systemd_enable:)." The attached patch fix the issue for me but be aware that i'm building on a non standard system, I have a poor knowledge about systemd and its dh tools, and I have not serched for other occurrencies of dh_systemd_enable in this package, so it could be wise to seek help from the systemd team before applying the patch Best Regards, Lorenzo -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads) Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en Shell: /bin/sh linked to /bin/dash Init: runit (via /run/runit.stopit) Versions of packages openstack-pkg-tools depends on: ii gettext 0.19.8.1-10 ii jq 1.6-1 ii po-debconf 1.0.21 ii python3-pip 20.1.1-2 Versions of packages openstack-pkg-tools recommends: ii autopkgtest 5.15 ii madison-lite 0.26 ii pristine-tar 1.49 openstack-pkg-tools suggests no packages. -- no debconf information -- debsums errors found: debsums: changed file /usr/share/openstack-pkg-tools/pkgos.make (from openstack-pkg-tools package)
--- pkgos.make.now 2020-11-15 22:59:21.000000000 +0100 +++ pkgos.make.patched 2020-11-28 16:23:29.562425427 +0100 @@ -36,8 +36,8 @@ fi \ done -override_dh_systemd_enable: gen-init-configurations - dh_systemd_enable +override_dh_installsystemd: gen-init-configurations + dh_installsystemd override_dh_installinit: gen-init-configurations dh_installinit --error-handler=true