Bug#976445: libjs-qunit: please make the build reproducible

[Vagrant Cascadian]

Control: tags 976445 pending

On 2020-12-05, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> libjs-qunit could not be built reproducibly.
>
> This is because it includes the current date in some generated files.
> I tried to use SOURCE_DATE_EPOCH in the Gruntfile.js but I couldn't
> access process.env (I'm not a JS expert, alas).

I have uploaded an NMU to DELAYED/10 fixing this issue:

diff -Nru libjs-qunit-1.23.1~dfsg/debian/changelog 
libjs-qunit-1.23.1~dfsg/debian/changelog
--- libjs-qunit-1.23.1~dfsg/debian/changelog2022-12-06 06:09:01.0 
-0800
+++ libjs-qunit-1.23.1~dfsg/debian/changelog2022-12-08 14:00:56.0 
-0800
@@ -1,3 +1,12 @@
+libjs-qunit (1.23.1~dfsg-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Make the build reproducible (Closes: #976445)
+
+ -- Vagrant Cascadian   Thu, 08 Dec 2022 
14:00:56 -0800
+
 libjs-qunit (1.23.1~dfsg-3) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru libjs-qunit-1.23.1~dfsg/debian/rules 
libjs-qunit-1.23.1~dfsg/debian/rules
--- libjs-qunit-1.23.1~dfsg/debian/rules2022-12-06 06:09:01.0 
-0800
+++ libjs-qunit-1.23.1~dfsg/debian/rules2022-12-08 14:00:56.0 
-0800
@@ -34,6 +34,7 @@
$(GRUNT) concat:src-js concat:src-css
 
 override_dh_auto_build: $(DOCS) $(CHANGELOGS) dist/qunit.min.js.gz
+   sed -i '/ Date: /d' dist/qunit.*
 
 override_dh_auto_test:
$(GRUNT) test-on-node


signature.asc
Description: PGP signature

Bug#976445: libjs-qunit: please make the build reproducible

[Chris Lamb]

Source: libjs-qunit
Version: 1.23.1~dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
libjs-qunit could not be built reproducibly.

This is because it includes the current date in some generated files.
I tried to use SOURCE_DATE_EPOCH in the Gruntfile.js but I couldn't
access process.env (I'm not a JS expert, alas).

Patch attached that at least strips these dates out in debian/rules.

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/rules  2020-12-05 10:10:21.424292462 +
--- b/debian/rules  2020-12-05 10:30:12.446707700 +
@@ -34,6 +34,7 @@
$(GRUNT) concat:src-js concat:src-css
 
 override_dh_auto_build: $(DOCS) $(CHANGELOGS) dist/qunit.min.js.gz
+   sed -i '/ Date: /d' dist/qunit.*
 
 override_dh_auto_test:
$(GRUNT) test-on-node