Bug#976716: jbbp: please make the build reproducible

2020-12-07 Thread Emmanuel Bourg
Le 07/12/2020 à 11:48, Chris Lamb a écrit :

> Whilst working on the Reproducible Builds effort [0] we noticed that
> jbbp could not be built reproducibly.
> 
> This is because the pom.xml embeds the absolute build path.

It looks like the ${basedir} variable was substituted by the uber-pom
plugin (from libuber-pom-java). This issue may occur again if this
plugin is used to build other packages, in which case it would be better
to fix the issue directly at the plugin level.

Emmanuel Bourg



Bug#976716: jbbp: please make the build reproducible

2020-12-07 Thread Chris Lamb
Source: jbbp
Version: 2.0.2-2
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
jbbp could not be built reproducibly.

This is because the pom.xml embeds the absolute build path.

Patch attached that removes this part of the file; it cannot relate
to anything at runtime (and I can't see how/where the runtime code
uses this path) so it feels safe to remove.

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/03-drop-basedir.patch  1970-01-01 01:00:00.0 
+0100
--- b/debian/patches/03-drop-basedir.patch  2020-12-07 10:42:16.102990199 
+
@@ -0,0 +1,18 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2020-12-07
+
+--- jbbp-2.0.2.orig/pom.xml
 jbbp-2.0.2/pom.xml
+@@ -123,11 +123,6 @@
+ 
+ 
+ bundle
+-
+-
+-${basedir}/src/assemble
+-
+-
+ 
+ 
+ 
--- a/debian/patches/series 2020-12-07 10:38:49.463599264 +
--- b/debian/patches/series 2020-12-07 10:42:15.134974974 +
@@ -1,2 +1,3 @@
 01-updated.patch
 02-updated.patch
+03-drop-basedir.patch