Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2021-01-17 Thread Wang Shanker
Dear Maintainers,

I wonder if the two patches to debian-installer can be applied to 
stable-pu, so that users (especially those who are using arm64 
platforms) installing the latest stable debian version will get
a working console on screen.

Also, it will be nice if my name can be corrected as ``Miao Wang"
in the changelog of rootskel. :-)

Cheers,

Miao Wang


Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Samuel Thibault
Re,

Alper Nebi Yasak, le mar. 15 déc. 2020 23:42:16 +0300, a ecrit:
> I've tested with this and the patch for rootskel, and in the text-based
> installer on the framebuffer the black boxes are replaced with actual
> characters (arm64 QEMU, with console=ttyAMA0 console=tty0).
> 
> Can you apply that and do a release for rootskel if that's fine?
> (also see: a small fix for the changelog [1])

I applied it, thanks!

Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Alper Nebi Yasak
On 15/12/2020 20:17, Samuel Thibault wrote:
> Wang Shanker, le mer. 16 déc. 2020 01:05:58 +0800, a ecrit:
>> I carried out a simple test by limiting memory of my qemu machine
>> and appending `lowmem=2` to the kernel command line. I can confirm
>> that btrem and its font file get deleted.
> 
> Ok, good!
> 
> Thanks for testing, I have uploaded the fix to lowmem.
> 
> Samuel
> 

I've tested with this and the patch for rootskel, and in the text-based
installer on the framebuffer the black boxes are replaced with actual
characters (arm64 QEMU, with console=ttyAMA0 console=tty0).

Can you apply that and do a release for rootskel if that's fine?
(also see: a small fix for the changelog [1])

[1] https://salsa.debian.org/installer-team/rootskel/-/merge_requests/4



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Samuel Thibault
Wang Shanker, le mer. 16 déc. 2020 01:05:58 +0800, a ecrit:
> I carried out a simple test by limiting memory of my qemu machine
> and appending `lowmem=2` to the kernel command line. I can confirm
> that btrem and its font file get deleted.

Ok, good!

Thanks for testing, I have uploaded the fix to lowmem.

Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Wang Shanker
Hi,

I carried out a simple test by limiting memory of my qemu machine
and appending `lowmem=2` to the kernel command line. I can confirm
that btrem and its font file get deleted.

I wonder if I could have more information on testing it, or shall I
provide some test cases?

Cheers,

Miao Wang

> 2020年12月16日 00:56,Samuel Thibault  写道:
> 
> Hello,
> 
> Wang Shanker, le mer. 16 déc. 2020 00:53:27 +0800, a ecrit:
>> Then I believe the following patch will remove unnecessary files when the
>> memory is not enough.
> 
> Thanks!
> 
> But "believe" is not enough, we need someone to actually test it :)
> 
> Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Samuel Thibault
Hello,

Wang Shanker, le mer. 16 déc. 2020 00:53:27 +0800, a ecrit:
> Then I believe the following patch will remove unnecessary files when the
> memory is not enough.

Thanks!

But "believe" is not enough, we need someone to actually test it :)

Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Wang Shanker
Control: clone -1 -2
Control: reassign -2 lowmem
Control: retitle -2 lowmem: delete graphical terminal related files in lawmen 
state
Control: merge -1 -2

Hi,

Then I believe the following patch will remove unnecessary files when the
memory is not enough.

From 87f728f9abe07bae1586a5815c7dcda407035c83 Mon Sep 17 00:00:00 2001
From: Miao Wang 
Date: Wed, 16 Dec 2020 00:46:35 +0800
Subject: [PATCH] Delete graphical terminal related files when mem is low

We delete those files here because lowmem_debconf is invoked in
debian-installer-startup and only one instance of it is started,
preventing any race conditions where multiple instances of
debian-installer are started on multiple consoles.
---
 lowmem_debconf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lowmem_debconf b/lowmem_debconf
index 54b9c6e..36b6f0d 100755
--- a/lowmem_debconf
+++ b/lowmem_debconf
@@ -17,3 +17,6 @@ done
 db_set debian-installer/framebuffer false || true
 db_set debian-installer/locale "C" || true
 db_fset debian-installer/locale seen true
+
+rm -f /usr/bin/bterm
+rm -f /lib/unifont.bgf
-- 
2.20.1


> 2020年12月15日 23:04,Samuel Thibault  写道:
> 
> Wang Shanker, le mar. 15 déc. 2020 22:59:52 +0800, a ecrit:
>> Thanks for your response. In `S15lowmem`, I can see the limit for the
>> memory is around tens or hundreds of megabytes. The font file, however,
>> is only around 200K. I doubt the necessity of removing it. 
> 
> 200K+200K+200K+... in various packages, ends up getting a few
> megabytes. So yes, it does make a difference in the end.
> 
>> Just to confirm, if the font must be deleted, shall we add the rm into
>> https://salsa.debian.org/installer-team/lowmem/-/blob/master/lowmem_debconf ?
> 
> Yes (it seems I pointed you at the installed path instead of the source,
> indeed :) )
> 
> Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Samuel Thibault
Wang Shanker, le mar. 15 déc. 2020 22:59:52 +0800, a ecrit:
> Thanks for your response. In `S15lowmem`, I can see the limit for the
> memory is around tens or hundreds of megabytes. The font file, however,
> is only around 200K. I doubt the necessity of removing it. 

200K+200K+200K+... in various packages, ends up getting a few
megabytes. So yes, it does make a difference in the end.

> Just to confirm, if the font must be deleted, shall we add the rm into
> https://salsa.debian.org/installer-team/lowmem/-/blob/master/lowmem_debconf ?

Yes (it seems I pointed you at the installed path instead of the source,
indeed :) )

Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Wang Shanker
Hi,

Thanks for your response. In `S15lowmem`, I can see the limit for the
memory is around tens or hundreds of megabytes. The font file, however,
is only around 200K. I doubt the necessity of removing it. 

Just to confirm, if the font must be deleted, shall we add the rm into
https://salsa.debian.org/installer-team/lowmem/-/blob/master/lowmem_debconf ?

Cheers,

Miao Wang

> 2020年12月15日 20:40,Samuel Thibault  写道:
> 
> Wang Shanker, le mar. 15 déc. 2020 20:17:50 +0800, a ecrit:
>> The cause of the probem is in the `S70menu` script, where the font file
>> get deleted when bterm is not used.
> 
> Ok but this is done on purpose for the lowmem case. We probably need to
> put that rm back into the lowmem package then, I guess it would be in
> ./debian/lowmemcheck/bin/lowmem_debconf along disabling the framebuffer.
> 
> Samuel



Bug#977466: rootskel: bterm cannot start when requesting graphical console and serial console at the same time

2020-12-15 Thread Samuel Thibault
Wang Shanker, le mar. 15 déc. 2020 20:17:50 +0800, a ecrit:
> The cause of the probem is in the `S70menu` script, where the font file
> get deleted when bterm is not used.

Ok but this is done on purpose for the lowmem case. We probably need to
put that rm back into the lowmem package then, I guess it would be in
./debian/lowmemcheck/bin/lowmem_debconf along disabling the framebuffer.

Samuel