Bug#977701: gitlab: Missing assets, breaking some functionalities
On Fri, 22 Jan 2021 21:00:52 +0100 Antoine Le Gonidec wrote: As I am affected too I am going to give it a try, and report the result here. After a couple days using the packaged 13.5.7-1~fto+1 version of GitLab, I have no issue to report. None of the bugs I initially reported are still happening. Thanks for the good work fixing this ;) OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Thu, 21 Jan 2021 20:21:38 +0100 Maximilian Stein wrote: My broken pages are actually fixed with Gitlab 13.5.7-1. So for my side, this issue can be closed. Great news! As I am affected too I am going to give it a try, and report the result here. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
Someone affected should confirm it, I confirmed issue pages that was broken is fixed. My broken pages are actually fixed with Gitlab 13.5.7-1. So for my side, this issue can be closed. Thanks a lot for debugging & fixing! Best Maximilian OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On 2021, ജനുവരി 20 2:17:50 AM IST, Maximilian Stein wrote: > >> Someone else reported the artifacts issue was resolved in 13.5.6. See >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968626#40 >> >Oh, sorry, i didn't mean artifact upload (bug 968626), but the Gitlab >internal artifacts that are missing from bug 977701 and break some pages. > Someone affected should confirm it, I confirmed issue pages that was broken is fixed. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Bug#977701: gitlab: Missing assets, breaking some functionalities
Someone else reported the artifacts issue was resolved in 13.5.6. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968626#40 Oh, sorry, i didn't mean artifact upload (bug 968626), but the Gitlab internal artifacts that are missing from bug 977701 and break some pages. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Tue, Jan 19, 2021 at 7:52 pm, Maximilian Stein wrote: Some good news finally. After I switched to using only yarn for all modules (use unpatched package.json) webpack is working fine. Now I will try to add back the packaged modules one by one so we can know which module broke it. This is indeed great news! I will upload 13.5.7 to fasttrack now. So, just to clarify, this version will still have the artifact issues? Someone else reported the artifacts issue was resolved in 13.5.6. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968626#40
Bug#977701: gitlab: Missing assets, breaking some functionalities
Some good news finally. After I switched to using only yarn for all modules (use unpatched package.json) webpack is working fine. Now I will try to add back the packaged modules one by one so we can know which module broke it. This is indeed great news! I will upload 13.5.7 to fasttrack now. So, just to clarify, this version will still have the artifact issues? OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
Some good news finally. After I switched to using only yarn for all modules (use unpatched package.json) webpack is working fine. Now I will try to add back the packaged modules one by one so we can know which module broke it. I will upload 13.5.7 to fasttrack now.
Bug#977701: gitlab: Missing assets, breaking some functionalities
Just to put some info in the bug: I have upgraded my gitlab installation to 13.5.6-1~fto10+2. I have follow wiki instructions but there are missing dependencies: ruby-charlock-holmes ruby-mini-magick node-katex must be backported if not, there are error because katex.min.css is missing. A possible workaround is to drop the references in the directory /usr/share/gitlab/app/assets/javascripts the files: behaviors/markdown/render_math.js: // import(/* webpackChunkName: 'katex' */ 'katex/dist/katex.min.css'), notebook/cells/markdown.vue:/* @import '~katex/dist/katex.min.css'; */ After that seem that gitlab is working ... I hope. -- -- Linux User 152692 GPG: 05F4A7A949A2D9AA Catalonia - A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Bug#977701: gitlab: Missing assets, breaking some functionalities
> Try copying that directory from older versions ? I tried copying from 13.4.7-1, unfortunately without success. The issue boards and other resources stay empty. I guess that older versions won't work because the database might have been changed incompatibly, or? OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On 2021, ജനുവരി 11 12:17:15 AM IST, Antoine Le Gonidec wrote: >I see a new update (13.5.6) is available through fasttrack-staging. Is it >supposed to include a fix for the missing assets issue discussed here, or >would it probably still trigger it? It still has that bug, but includes some security fixes. >I should be able to give it a try on my server, reverting to a snapshot >afterwards if the issue is not fixed yet. > But more testing is always welcome. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Bug#977701: gitlab: Missing assets, breaking some functionalities
Oops, sorry for the extra messages quoting the opening message of this thread, Thunderbird decided to act funny. They can be discarded, the message about the upcoming 13.5.6 package was the only one that was supposed to be sent. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec wrote: > Package: gitlab > Version: 13.4.7-2~fto10+1 > Severity: important > > On a Debian Buster using the buster-fasttracks, the update from > 13.4.7-1~fto10+1 to 13.4.7-2~fto10+1 included some changes in the assets > generation process, that broke some parts of the JavaScript interactions with > GitLab. > > Two examples allowing to observe this issue: > - From a merge request edition form, the target branch can not be changed > - From the list of merge requests in a user dashboard, the top right green > menu supposed to allow the creation of a new merge request show an ininfinite > spinning animation instead > > I suspect this is related to a 404 error I get when trying to fetch > /assets/webpack/components/app.vue > There is indeed no such file generated in /usr/share/gitlab/public > > Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. I > have yet to try a full update of the update I did that included this package, > here are the details according to APT history: > > Start-Date: 2020-12-18 22:00:20 > Commandline: apt install gitlab node-autosize/buster-backports > fonts-font-awesome/buster-backports node-uuid/buster-backports > node-request/buster-backports > Install: fonts-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), > node-match-at:amd64 (0.1.1-1, automatic), katex:amd64 (0.10.2+dfsg-4~bpo10+1, > automatic), libjs-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), > node-mermaid:amd64 (8.7.0+ds+~cs27.17.17-2~bpo10+1, automatic) > > Upgrade: fonts-font-awesome:amd64 (5.0.10+really4.7.0~dfsg-1, > 5.0.10+really4.7.0~dfsg-4~bpo10+1), node-autosize:amd64 (4.0.2~dfsg1-3, > 4.0.2~dfsg1-5~bpo10+1), node-request:amd64 (2.88.1-2, 2.88.1-5~bpo10+1), > gitlab:amd64 (13.4.7-1~fto10+1, 13.4.7-2~fto10+1), node-uuid:amd64 (3.3.2-2, > 8.3.2+~8.3.0-1~bpo10+1) > Error: Sub-process /usr/bin/dpkg returned an error code (1) > End-Date: 2020-12-18 22:21:04 > > The dpkg error code is actually a recurring issue I have that does not seem > to be related to the issue at hand, and is always fixed by running `dpkg > --configure -a`. > > -- System Information: > Debian Release: 10.7 > APT prefers stable-updates > APT policy: (500, 'stable-updates'), (500, 'stable'), (150, > 'buster-fasttrack'), (150, 'buster-backports'), (110, 'testing'), (100, > 'unstable') > Architecture: amd64 (x86_64) > > Kernel: Linux 4.19.0-13-amd64 (SMP w/4 CPU cores) > Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), > LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /usr/bin/dash > Init: systemd (via /run/systemd/system) > > Versions of packages gitlab depends on: > ii asciidoctor 2.0.10-2~bpo10+1 > ii bc1.07.1-2+b1 > ii bundler 2.1.4-2~bpo10+1 > ii bzip2 1.0.6-9.2~deb10u1 > ii dbconfig-pgsql2.0.11+deb10u1 > ii debconf [debconf-2.0] 1.5.71 > ii fonts-font-awesome [node-font-awesome] > 5.0.10+really4.7.0~dfsg-4~bpo10+1 > ii gitlab-common 13.4.6+dfsg1-2~fto10+1 > ii gitlab-workhorse 8.46.0+debian-1~bpo10+1 > ii katex [node-katex]0.10.2+dfsg-4~bpo10+1 > ii libjs-bootstrap4 [node-bootstrap] 4.3.1+dfsg2-1 > ii libjs-codemirror [node-codemirror]5.54.0-2~bpo10+1 > ii libjs-pdf [node-pdfjs-dist] 2.6.347+dfsg-3~bpo10+1 > ii libjs-popper.js [node-popper.js] 1.14.6+ds2-1 > ii libjs-uglify 2.8.29-6 > ii libruby2.7 [ruby-json]2.7.1-3+fto10+2 > ii lsb-base 10.2019051400 > ii nginx 1.14.2-2+deb10u3 > ii nginx-full [nginx]1.14.2-2+deb10u3 > ii node-autosize 4.0.2~dfsg1-5~bpo10+1 > ii node-axios0.17.1+dfsg-2 > ii node-babel-loader 8.2.2-1~bpo10+1 > ii node-babel7 7.4.5+~cs7.3.8-1~bpo10+1 > ii node-brace-expansion 1.1.8-1
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec wrote: > Package: gitlab > Version: 13.4.7-2~fto10+1 > Severity: important > > On a Debian Buster using the buster-fasttracks, the update from > 13.4.7-1~fto10+1 to 13.4.7-2~fto10+1 included some changes in the assets > generation process, that broke some parts of the JavaScript interactions with > GitLab. > > Two examples allowing to observe this issue: > - From a merge request edition form, the target branch can not be changed > - From the list of merge requests in a user dashboard, the top right green > menu supposed to allow the creation of a new merge request show an ininfinite > spinning animation instead > > I suspect this is related to a 404 error I get when trying to fetch > /assets/webpack/components/app.vue > There is indeed no such file generated in /usr/share/gitlab/public > > Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. I > have yet to try a full update of the update I did that included this package, > here are the details according to APT history: > > Start-Date: 2020-12-18 22:00:20 > Commandline: apt install gitlab node-autosize/buster-backports > fonts-font-awesome/buster-backports node-uuid/buster-backports > node-request/buster-backports > Install: fonts-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), > node-match-at:amd64 (0.1.1-1, automatic), katex:amd64 (0.10.2+dfsg-4~bpo10+1, > automatic), libjs-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), > node-mermaid:amd64 (8.7.0+ds+~cs27.17.17-2~bpo10+1, automatic) > > Upgrade: fonts-font-awesome:amd64 (5.0.10+really4.7.0~dfsg-1, > 5.0.10+really4.7.0~dfsg-4~bpo10+1), node-autosize:amd64 (4.0.2~dfsg1-3, > 4.0.2~dfsg1-5~bpo10+1), node-request:amd64 (2.88.1-2, 2.88.1-5~bpo10+1), > gitlab:amd64 (13.4.7-1~fto10+1, 13.4.7-2~fto10+1), node-uuid:amd64 (3.3.2-2, > 8.3.2+~8.3.0-1~bpo10+1) > Error: Sub-process /usr/bin/dpkg returned an error code (1) > End-Date: 2020-12-18 22:21:04 > > The dpkg error code is actually a recurring issue I have that does not seem > to be related to the issue at hand, and is always fixed by running `dpkg > --configure -a`. > > -- System Information: > Debian Release: 10.7 > APT prefers stable-updates > APT policy: (500, 'stable-updates'), (500, 'stable'), (150, > 'buster-fasttrack'), (150, 'buster-backports'), (110, 'testing'), (100, > 'unstable') > Architecture: amd64 (x86_64) > > Kernel: Linux 4.19.0-13-amd64 (SMP w/4 CPU cores) > Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), > LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /usr/bin/dash > Init: systemd (via /run/systemd/system) > > Versions of packages gitlab depends on: > ii asciidoctor 2.0.10-2~bpo10+1 > ii bc1.07.1-2+b1 > ii bundler 2.1.4-2~bpo10+1 > ii bzip2 1.0.6-9.2~deb10u1 > ii dbconfig-pgsql2.0.11+deb10u1 > ii debconf [debconf-2.0] 1.5.71 > ii fonts-font-awesome [node-font-awesome] > 5.0.10+really4.7.0~dfsg-4~bpo10+1 > ii gitlab-common 13.4.6+dfsg1-2~fto10+1 > ii gitlab-workhorse 8.46.0+debian-1~bpo10+1 > ii katex [node-katex]0.10.2+dfsg-4~bpo10+1 > ii libjs-bootstrap4 [node-bootstrap] 4.3.1+dfsg2-1 > ii libjs-codemirror [node-codemirror]5.54.0-2~bpo10+1 > ii libjs-pdf [node-pdfjs-dist] 2.6.347+dfsg-3~bpo10+1 > ii libjs-popper.js [node-popper.js] 1.14.6+ds2-1 > ii libjs-uglify 2.8.29-6 > ii libruby2.7 [ruby-json]2.7.1-3+fto10+2 > ii lsb-base 10.2019051400 > ii nginx 1.14.2-2+deb10u3 > ii nginx-full [nginx]1.14.2-2+deb10u3 > ii node-autosize 4.0.2~dfsg1-5~bpo10+1 > ii node-axios0.17.1+dfsg-2 > ii node-babel-loader 8.2.2-1~bpo10+1 > ii node-babel7 7.4.5+~cs7.3.8-1~bpo10+1 > ii node-brace-expansion 1.1.8-1
Bug#977701: gitlab: Missing assets, breaking some functionalities
I see a new update (13.5.6) is available through fasttrack-staging. Is it supposed to include a fix for the missing assets issue discussed here, or would it probably still trigger it? I should be able to give it a try on my server, reverting to a snapshot afterwards if the issue is not fixed yet. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On 2021, ജനുവരി 10 10:45:45 PM IST, Maximilian Stein wrote: >Is there anything else that we could try to workaround the issues? > Try copying that directory from older versions ? -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Bug#977701: gitlab: Missing assets, breaking some functionalities
Is there anything else that we could try to workaround the issues? OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
>I tried the same and this does not fix the bug either. Same here, just finished testing.
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Thu, Jan 7, 2021 at 6:55 pm, Pirate Praveen
wrote:
I found another error while trying to update to gitlab 13.5 which I
think could be an issue here.
You can try to build from master-13.5 branch of gitlab. Or probably
try this patch in master branch or current version in unstable (or I
will get to trying it eventually).
https://salsa.debian.org/ruby-team/gitlab/-/blob/f9af389e35d0cadfa6c2e95387d09ec97418397d/debian/patches/0740-use-packaged-modules.patch#L43
ie, add 'node_modules' as first entry in config/webpack.config.js
resolve and resolveLoader options.
You can modify /usr/share/gitlab/config/webpack.config.js and run
webpack directly from /usr/share/gitlab directory.
runuser -u ${gitlab_user} -- sh -c 'NODE_ENV="production"
NODE_PATH="node_modules" NODE_OPTIONS="--max-old-space-size=4096"
webpack --config config/webpack.config.js'
with gitlab_user variable set to your gitlab user.
I tried the same and this does not fix the bug either.
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Wed, Jan 6, 2021 at 4:04 pm, Maximilian Stein wrote:
So, I got the asset compilation running, but I had to workaround some
issues, including broken symlinks to js
libs:_
cd /usr/share/gitlab
# move locale.static elsewhere
mv app/assets/javascripts/locale.static .
mv app/assets/javascripts/locale/index.js{,.bak}
ln -s /usr/share/gitlab/locale.static/index.js
app/assets/javascripts/locale/index.js
# remove broken symlinks
mkdir /root/vendor_assets_javascripts
cd vendor/assets/javascripts/
mv -t /root/vendor_assets_javascripts chart-lib.min.js clipboard.js
fuzzaldrin-plus.js g.bar-min.js g.raphael-min.js
jquery.nicescroll.min.js
cd -
# create hash file
touch assets-hash.txt
chown git:git assets-hash.txt
# provide webpack
ln -s /usr/bin/webpack node_modules/.bin/webpack
# compile all assets
gitlab-rake
gitlab:assets:compile_
Thanks, I will try to update the package to include this, just be on
the safer side.
However, this unfortunately didn't resolve the issues.
I found another error while trying to update to gitlab 13.5 which I
think could be an issue here.
You can try to build from master-13.5 branch of gitlab. Or probably try
this patch in master branch or current version in unstable (or I will
get to trying it eventually).
https://salsa.debian.org/ruby-team/gitlab/-/blob/f9af389e35d0cadfa6c2e95387d09ec97418397d/debian/patches/0740-use-packaged-modules.patch#L43
ie, add 'node_modules' as first entry in config/webpack.config.js
resolve and resolveLoader options.
You can modify /usr/share/gitlab/config/webpack.config.js and run
webpack directly from /usr/share/gitlab directory.
runuser -u ${gitlab_user} -- sh -c 'NODE_ENV="production"
NODE_PATH="node_modules" NODE_OPTIONS="--max-old-space-size=4096"
webpack --config config/webpack.config.js'
with gitlab_user variable set to your gitlab user.
ERROR in
/environments/components/environments_table.vue?vue=script=js&
(/usr/share/nodejs/babel-loader/lib??ref--1!/var/lib/gitlab/node_modules/vue-loader/lib??vue-loader-options!./environments/components/environments_table.vue?vue=script=js&)
Module build failed (from /usr/share/nodejs/babel-loader/lib/index.js):
SyntaxError:
/usr/share/gitlab/app/assets/javascripts/environments/components/environments_table.vue:
The 'lodash' method `flow` is not a known module.
Please report bugs to
https://github.com/lodash/babel-plugin-lodash/issues.
132 | * 5. Put folders first.
133 | */
> 134 | return flow(
|
135 | sortBy(env => (env.isFolder ? env.folderName : env.name)),
136 | reverse,
137 | sortBy(env => (env.last_deployment ?
env.last_deployment.created_at : '')),
at File.buildCodeFrameError
(/usr/share/nodejs/@babel/core/lib/transformation/file/file.js:250:12)
at NodePath.buildCodeFrameError
(/usr/share/nodejs/@babel/traverse/lib/path/index.js:138:21)
at resolvePath
(/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/importModule.js:28:18)
at importModule
(/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/importModule.js:36:53)
at memoized
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/memoize.js:62:23)
at
/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/index.js:203:62
at arrayEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/_arrayEach.js:15:9)
at forEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/forEach.js:38:10)
at
/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/index.js:193:30
at arrayEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/_arrayEach.js:15:9)
at forEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/forEach.js:38:10)
at
/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/index.js:181:28
at arrayEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/_arrayEach.js:15:9)
at forEach
(/var/lib/gitlab/node_modules/babel-plugin-lodash/node_modules/lodash/forEach.js:38:10)
at PluginPass.Program
(/var/lib/gitlab/node_modules/babel-plugin-lodash/lib/index.js:170:26)
at newFn (/usr/share/nodejs/@babel/traverse/lib/visitors.js:175:21)
at NodePath._call
(/usr/share/nodejs/@babel/traverse/lib/path/context.js:55:20)
at NodePath.call
(/usr/share/nodejs/@babel/traverse/lib/path/context.js:42:17)
at NodePath.visit
(/usr/share/nodejs/@babel/traverse/lib/path/context.js:92:31)
at TraversalContext.visitQueue
(/usr/share/nodejs/@babel/traverse/lib/context.js:115:16)
at TraversalContext.visitSingle
(/usr/share/nodejs/@babel/traverse/lib/context.js:84:19)
at TraversalContext.visit
(/usr/share/nodejs/@babel/traverse/lib/context.js:143:19)
at Function.traverse.node
(/usr/share/nodejs/@babel/traverse/lib/index.js:82:17)
at traverse (/usr/share/nodejs/@babel/traverse/lib/index.js:64:12)
at transformFile
Bug#977701: gitlab: Missing assets, breaking some functionalities
So, I got the asset compilation running, but I had to workaround some issues,
including broken symlinks to js
libs:_
cd /usr/share/gitlab
# move locale.static elsewhere
mv app/assets/javascripts/locale.static .
mv app/assets/javascripts/locale/index.js{,.bak}
ln -s /usr/share/gitlab/locale.static/index.js
app/assets/javascripts/locale/index.js
# remove broken symlinks
mkdir /root/vendor_assets_javascripts
cd vendor/assets/javascripts/
mv -t /root/vendor_assets_javascripts chart-lib.min.js clipboard.js
fuzzaldrin-plus.js g.bar-min.js g.raphael-min.js jquery.nicescroll.min.js
cd -
# create hash file
touch assets-hash.txt
chown git:git assets-hash.txt
# provide webpack
ln -s /usr/bin/webpack node_modules/.bin/webpack
# compile all assets
gitlab-rake gitlab:assets:compile_
However, this unfortunately didn't resolve the issues.
Best,
Maximilian
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Wed, Jan 6, 2021 at 10:24 am, Maximilian Stein wrote: >Unfortunately updating css-loader and postcss did not fix this issue :( Can I somehow help to untangle this issue? Are there any workarounds maybe? One things I can think of is to get gitlab-rake gitlab:assets:compile working (we run only part of it in rake-tasks.sh, I'm not sure if the steps we don't run is causing the issues). Another possibility is to include gitaly-git2go binary in the gitaly package. gitaly now seems to be using its own version of git2go for merges. Best, Maximilian
Bug#977701: gitlab: Missing assets, breaking some functionalities
>Unfortunately updating css-loader and postcss did not fix this issue :( Can I somehow help to untangle this issue? Are there any workarounds maybe? Best, Maximilian
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, 19 Dec 2020 21:10:09 +0530 Pirate Praveen wrote: > Some dependencies of node-css-loader need node-postcss 8 where as > node-css-loader itself need an update to use node-postcss 8. So it will > take a while to untangle this mess. Unfortunately updating css-loader and postcss did not fix this issue :(
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, Dec 19, 2020 at 8:08 pm, Pirate Praveen wrote: I think the issue is likely caused by incompatible version of postcss. I'm trying if updating postcss fixes the issue. Some dependencies of node-css-loader need node-postcss 8 where as node-css-loader itself need an update to use node-postcss 8. So it will take a while to untangle this mess. On the brighter side, we have jest packaged so in future we can detect such problems before they are uploaded (we did not have tests enabled in these pckages because jest was not packaged).
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, Dec 19, 2020 at 7:39 pm, Pirate Praveen wrote: On Sat, Dec 19, 2020 at 5:32 pm, Pirate Praveen wrote: On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec wrote: > I suspect this is related to a 404 error I get when trying to fetch /assets/webpack/components/app.vue > There is indeed no such file generated in /usr/share/gitlab/public > > Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. We have started using the following native packages in this update. katex and mermaid change could be the reason, others seem simple. I can also confirm reverting to 13.4.7-1~fto10+1 did not fix the issue. I think the issue is likely caused by incompatible version of postcss. I'm trying if updating postcss fixes the issue.
Bug#977701: gitlab: Missing assets, breaking some functionalities
I tried to revert the webpack.config.js and the package.json to the version from 13.4.7-1 and re-ran postinst, but with no success either. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, Dec 19, 2020 at 5:32 pm, Pirate Praveen wrote: On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec wrote: > I suspect this is related to a 404 error I get when trying to fetch /assets/webpack/components/app.vue > There is indeed no such file generated in /usr/share/gitlab/public > > Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. We have started using the following native packages in this update. katex and mermaid change could be the reason, others seem simple. I can also confirm reverting to 13.4.7-1~fto10+1 did not fix the issue.
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec wrote: Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. I have yet to try a full update of the update I did that included this package, here are the details according to APT history: Start-Date: 2020-12-18 22:00:20 Commandline: apt install gitlab node-autosize/buster-backports fonts-font-awesome/buster-backports node-uuid/buster-backports node-request/buster-backports Install: fonts-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), node-match-at:amd64 (0.1.1-1, automatic), katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), libjs-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), node-mermaid:amd64 (8.7.0+ds+~cs27.17.17-2~bpo10+1, automatic) Upgrade: fonts-font-awesome:amd64 (5.0.10+really4.7.0~dfsg-1, 5.0.10+really4.7.0~dfsg-4~bpo10+1), node-autosize:amd64 (4.0.2~dfsg1-3, 4.0.2~dfsg1-5~bpo10+1), node-request:amd64 (2.88.1-2, 2.88.1-5~bpo10+1), gitlab:amd64 (13.4.7-1~fto10+1, 13.4.7-2~fto10+1), node-uuid:amd64 (3.3.2-2, 8.3.2+~8.3.0-1~bpo10+1) Error: Sub-process /usr/bin/dpkg returned an error code (1) End-Date: 2020-12-18 22:21:04 Reverting this update did not fix the issue, I ended up restoring a server backup prior to it. This update is the only difference I can see between the restored backup and the situation triggering the JavaScript-related issues, so I guess it applies some change than is not reverted by going back to the previous package versions. OpenPGP_signature Description: OpenPGP digital signature
Bug#977701: gitlab: Missing assets, breaking some functionalities
On Sat, 19 Dec 2020 07:03:18 +0100 Antoine Le Gonidec
wrote:
> I suspect this is related to a 404 error I get when trying to fetch
/assets/webpack/components/app.vue
> There is indeed no such file generated in /usr/share/gitlab/public
>
> Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the
issue.
We have started using the following native packages in this update.
katex and mermaid change could be the reason, others seem simple.
diff --git a/debian/control b/debian/control
index 3c4b7f7a6..2aefd4a1f 100644
--- a/debian/control
+++ b/debian/control
@@ -357,7 +357,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends},
ruby-yajl (>= 1.4.1~),
ruby-webauthn (>= 2.3~),
# packaged node modules - all node packages are not packaged yet
- node-autosize (>= 4.0~),
+ node-autosize (>= 4.0.2~dfsg1-5~),
node-axios (>= 0.17.1~),
node-babel7,
node-babel-loader (>= 8.0~),
@@ -380,6 +380,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends},
node-exports-loader (>= 0.7~),
node-imports-loader (>= 0.8~),
node-file-loader (>= 5.0~),
+ node-font-awesome,
node-fuzzaldrin-plus (>= 0.5~),
node-glob (>= 7.1.6~),
node-jed,
@@ -388,10 +389,14 @@ Depends: ${shlibs:Depends}, ${misc:Depends},
# Broken
# node-jquery.waitforimages,
node-js-cookie,
+ node-js-yaml (>= 3.13.1~),
node-jszip,
node-jszip-utils,
+ node-katex,
node-lodash (>= 4.17.15~),
node-marked (>= 0.3~),
+ node-mermaid,
+ node-minimatch,
node-mousetrap,
node-pdfjs-dist,
# Include node-pikaday only after @gitlab/ui is accepted
@@ -408,6 +413,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends},
node-timeago.js (>= 4.0~),
node-underscore (>= 1.9~),
node-url-loader (>= 3.0~),
+ node-uuid (>= 8.1~),
node-vue (>= 2.6.10~),
node-vue-resource (>= 1.5.1~),
# Blocked by #927254
Bug#977701: gitlab: Missing assets, breaking some functionalities
Indeed, I also notices some minor issues like that one after I upgraded to 13.4.7-2~fto10+1. For me, e.g., the issue boards stay empty. In my browser's web console I see two error messages among many warnings: Loading module from “https://git.example.org/group/project/-/boards/shortcuts/shortcuts” was blocked because of a disallowed MIME type (“text/html”). Loading module from “https://git.example.org/group/project/-/boards/components/app.vue” was blocked because of a disallowed MIME type (“text/html”). My browser added an explanation link to these error messages pointing to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Content-Type-Options. Most notably, while the message about "app.vue" apparently appears on all of my Gitlab pages, the messages about "shortcuts" is only present at the issue board site.
Bug#977701: gitlab: Missing assets, breaking some functionalities
Package: gitlab Version: 13.4.7-2~fto10+1 Severity: important On a Debian Buster using the buster-fasttracks, the update from 13.4.7-1~fto10+1 to 13.4.7-2~fto10+1 included some changes in the assets generation process, that broke some parts of the JavaScript interactions with GitLab. Two examples allowing to observe this issue: - From a merge request edition form, the target branch can not be changed - From the list of merge requests in a user dashboard, the top right green menu supposed to allow the creation of a new merge request show an ininfinite spinning animation instead I suspect this is related to a 404 error I get when trying to fetch /assets/webpack/components/app.vue There is indeed no such file generated in /usr/share/gitlab/public Reverting the gitlab package to 13.4.7-1~fto10+1 did not fix the issue. I have yet to try a full update of the update I did that included this package, here are the details according to APT history: Start-Date: 2020-12-18 22:00:20 Commandline: apt install gitlab node-autosize/buster-backports fonts-font-awesome/buster-backports node-uuid/buster-backports node-request/buster-backports Install: fonts-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), node-match-at:amd64 (0.1.1-1, automatic), katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), libjs-katex:amd64 (0.10.2+dfsg-4~bpo10+1, automatic), node-mermaid:amd64 (8.7.0+ds+~cs27.17.17-2~bpo10+1, automatic) Upgrade: fonts-font-awesome:amd64 (5.0.10+really4.7.0~dfsg-1, 5.0.10+really4.7.0~dfsg-4~bpo10+1), node-autosize:amd64 (4.0.2~dfsg1-3, 4.0.2~dfsg1-5~bpo10+1), node-request:amd64 (2.88.1-2, 2.88.1-5~bpo10+1), gitlab:amd64 (13.4.7-1~fto10+1, 13.4.7-2~fto10+1), node-uuid:amd64 (3.3.2-2, 8.3.2+~8.3.0-1~bpo10+1) Error: Sub-process /usr/bin/dpkg returned an error code (1) End-Date: 2020-12-18 22:21:04 The dpkg error code is actually a recurring issue I have that does not seem to be related to the issue at hand, and is always fixed by running `dpkg --configure -a`. -- System Information: Debian Release: 10.7 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable'), (150, 'buster-fasttrack'), (150, 'buster-backports'), (110, 'testing'), (100, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-13-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) Versions of packages gitlab depends on: ii asciidoctor 2.0.10-2~bpo10+1 ii bc1.07.1-2+b1 ii bundler 2.1.4-2~bpo10+1 ii bzip2 1.0.6-9.2~deb10u1 ii dbconfig-pgsql2.0.11+deb10u1 ii debconf [debconf-2.0] 1.5.71 ii fonts-font-awesome [node-font-awesome]5.0.10+really4.7.0~dfsg-4~bpo10+1 ii gitlab-common 13.4.6+dfsg1-2~fto10+1 ii gitlab-workhorse 8.46.0+debian-1~bpo10+1 ii katex [node-katex]0.10.2+dfsg-4~bpo10+1 ii libjs-bootstrap4 [node-bootstrap] 4.3.1+dfsg2-1 ii libjs-codemirror [node-codemirror]5.54.0-2~bpo10+1 ii libjs-pdf [node-pdfjs-dist] 2.6.347+dfsg-3~bpo10+1 ii libjs-popper.js [node-popper.js] 1.14.6+ds2-1 ii libjs-uglify 2.8.29-6 ii libruby2.7 [ruby-json]2.7.1-3+fto10+2 ii lsb-base 10.2019051400 ii nginx 1.14.2-2+deb10u3 ii nginx-full [nginx]1.14.2-2+deb10u3 ii node-autosize 4.0.2~dfsg1-5~bpo10+1 ii node-axios0.17.1+dfsg-2 ii node-babel-loader 8.2.2-1~bpo10+1 ii node-babel7 7.4.5+~cs7.3.8-1~bpo10+1 ii node-brace-expansion 1.1.8-1 ii node-cache-loader 4.1.0-6~bpo10+1 ii node-chart.js 2.7.3+dfsg-5 ii node-clipboard2.0.6+ds-1~bpo10+1 ii node-compression-webpack-plugin 3.0.1-4~bpo10+1 ii node-copy-webpack-plugin 5.1.2+~cs9.0.2-4~bpo10+1 ii node-core-js 3.6.1-2~bpo10+2 ii node-css-loader 3.2.1+~cs21.3.8.1-2~bpo10+1 ii node-d3 5.16.0-1~bpo10+1 ii node-d3-scale 2.2.2-2~bpo10+1 ii node-d3-selection 1.4.0-3~bpo10+1 ii node-dateformat 3.0.0-1 ii node-exports-loader 0.7.0-2~bpo10+1 ii node-file-loader 6.2.0-2~bpo10+1 ii node-fuzzaldrin-plus 0.5.0+dfsg-1 ii node-glob
