Bug#978070: [Pkg-roundcube-maintainers] Bug#978070: src:roundcube: LESS-generated code installed only compressed, unlike other CSS code

[Guilhem Moulin]

On Fri, 25 Dec 2020 at 16:00:09 +0100, Jonas Smedegaard wrote:
> I would expect upstream instructions to be irrelevant for the serving of 
> minified files: That's something a frontend web server can be configured 
> to favor instead of on-the-fly compression (or no compression) 
> independent of the backend web application.

What I meant is that IIRC the PHP has a preference list for which file
to load (say [.min.css, .css] or just [.css] or just [.min.css]), and
uses the first one present as resource.  So if .min.css is not in that
preference list it's never gonna be served unless a dedicated rule is
added on the HTTPd which is arguably a regression.

Shipping pre-compressed (gzip, brotli, whatever) resources is not a
problem as long as the deflated version is also present: roundcube will
choose the later in the generated HTML, and as you wrote the HTTPd can
be configured to serve the pre-compressed version.

-- 
Guilhem.


signature.asc
Description: PGP signature

Bug#978070: [Pkg-roundcube-maintainers] Bug#978070: src:roundcube: LESS-generated code installed only compressed, unlike other CSS code

[Jonas Smedegaard]

Quoting Guilhem Moulin (2020-12-25 15:51:01)
> On Fri, 25 Dec 2020 at 14:00:56 +0100, Jonas Smedegaard wrote:
> > During install, all CSS code gets compressed using yui-compressor, 
> > and then compressed CSS code is generated from LESS code.
> > 
> > As a result, some CSS is installed both uncompressed and compressed, 
> > while some is installed only compressed.
> 
> This is deliberate: we ship the source (LESS or un-minified CSS) and 
> the generated minified CSS.  Also IIRC Roundcube won't prefer the 
> .min.css over the .css in this case, and only load the .css.  Was a 
> while since I looked at this and it might have changed meanwhile, but 
> upstream's installations instructions haven't changed: they still make 
> no mention of .min.css and only talk about generating .css from LESS 
> sources.

Please reconsider:

I would expect upstream instructions to be irrelevant for the serving of 
minified files: That's something a frontend web server can be configured 
to favor instead of on-the-fly compression (or no compression) 
independent of the backend web application.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature