Bug#978219: libfm-qt: FTBFS: gioptrs.h:75:26: error: ‘QString::QString(const char*)’ is private within this context

[plugwash]

tags 978219 +fixed-upstream
thanks

The immediate cause of this bug, is the addition of 
-DQT_NO_CAST_FROM_ASCII to the compiler flags.
Doing some grepping, this appears like it was caused by the update of 
lxqt-buildtools, and appears

to be intentional rather than a leak.

Doing some digging in the upstream source, it looks like this was fixed 
upstream in

https://github.com/lxqt/libfm-qt/commit/1baee3ed83b94aaf2f811e76a9fe789dc1695b3d
I have not checked if the fix can be applied to the version currently in 
Debian though.

Bug#978219: libfm-qt: FTBFS: gioptrs.h:75:26: error: ‘QString::QString(const char*)’ is private within this context

[Lucas Nussbaum]

Source: libfm-qt
Version: 0.14.1-12.2
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20201226 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> cd /<>/obj-x86_64-linux-gnu/src && /usr/bin/c++ 
> -DGETTEXT_PACKAGE=\"\" -DLIBFM_QT_DATA_DIR=\"/usr/share/libfm-qt\" 
> -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_CAST_FROM_ASCII 
> -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG 
> -DQT_NO_FOREACH -DQT_NO_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING 
> -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -Dfm_qt_EXPORTS 
> -I/<>/obj-x86_64-linux-gnu/src -I/<>/src 
> -I/<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/include 
> -I/usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.2 
> -I/usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.2/QtGui 
> -I/usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.2 
> -I/usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.2/QtCore 
> -I/<>/src/core/legacy -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gio-unix-2.0 
> -I/usr/include/menu-cache -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem 
> /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtX11Extras -g -O2 
> -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fno-exceptions -Wall 
> -Wextra -Wchar-subscripts -Wno-long-long -Wpointer-arith -Wundef 
> -Wformat-security -Wnon-virtual-dtor -Woverloaded-virtual -Wpedantic -O2 -g 
> -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC 
> -std=c++14 -o CMakeFiles/fm-qt.dir/core/mimetype.cpp.o -c 
> /<>/src/core/mimetype.cpp
> In file included from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/core/iconinfo.h:30,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/core/mimetype.h:40,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/appchoosercombobox.h:28,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/moc_appchoosercombobox.cpp:10,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/mocs_compilation.cpp:2:
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/core/gioptrs.h:
>  In member function ‘QString Fm::GErrorPtr::message() const’:
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/core/gioptrs.h:75:26:
>  error: ‘QString::QString(const char*)’ is private within this context
>75 | return err_->message;
>   |  ^~~
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
>  from 
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:45,
>  from 
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qcombobox.h:44,
>  from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QComboBox:1,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/appchoosercombobox.h:24,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/moc_appchoosercombobox.cpp:10,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/mocs_compilation.cpp:2:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:973:5: note: declared 
> private here
>   973 | QString(const char *ch);
>   | ^~~
> In file included from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/moc_appchooserdialog.cpp:10,
>  from 
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/mocs_compilation.cpp:3:
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/appchooserdialog.h:
>  At global scope:
> /<>/obj-x86_64-linux-gnu/src/fm-qt_autogen/EWIEGA46WW/../../../../src/appchooserdialog.h:39:124:
>  warning: ‘constexpr QFlags::QFlags(QFlags::Zero) [with Enum = 
> Qt::WindowType; QFlags::Zero = int QFlags::Private::*]’ is 
> deprecated: Use default constructor instead [-Wdeprecated-declarations]
>39 | explicit AppChooserDialog(std::shared_ptr 
> mimeType, QWidget* parent = nullptr, Qt::WindowFlags f = 0);
>   |   
>  ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:1304,
>  from 
> /usr/include/x86_64-linux-gnu/qt5/QtGui/qtguiglobal.h:43,
>  from 
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qtwidgetsglobal.h:43,
>  from 
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qcombobox.h:43,
>  from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QComboBox:1,
>