Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
I can't help but feel this needs to be rethought. If I install the current Debian 12 via netinst and choose not to install 'standard system utilities'... a choice many people take if they prefer to install their own set of utilities instead... and a choice which doesn't advertise any negative connotations for unchecking it... Then it means the debootstrap process that debian-installer did... won't install dbus (as it's only a recommends of systemd)... and dbus won't be installed from 'standard system utilities' either. From this point, there are two scenarios... If you've got recommends enabled on your system... Installing the fwupd package will automatically try to start the fwupmgr service and fail because the dbus package it just installed (because dbus is a recommends of fwupd) won't automatically start and stays inactive unless you active it or reboot. This gives you an ugly **red error message** in the apt-get output of... "dbus.service is not active, cannot reload." If you've got recommends disabled on your system... (a perfectly valid scenario, but there are haters of this!)... Installing the fwupd package will automatically try to start the fwupmgr service and fail because dbus isn't installed. This gives you an ugly **red error message** in the apt-get output of... "Failed to reload dbus.service: Unit dbus.service not found." I know that some people just install fwupd to use the fwuptool manually which works just fine without fwupdmgr... But unless this package is split into two (one for the fwupmgr service, one for fwupdtool), or unless it is reconfigured so it doesn't try to automatically start fwupmgr... then I can't see how dbus shouldn't be considered a depend for fwupd. It literally can't perform one of its main functions, a function that is automatically started, and shows an error!.. without it!
Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
> -Original Message- > From: Lukas Pirl > Sent: Wednesday, January 13, 2021 13:51 > To: Limonciello, Mario > Cc: 980...@bugs.debian.org > Subject: Re: Bug#980049: fwupd: Should fwupd specify dbus as a dependency? > > Thanks for your quick reply, Mario. > > On Wed, 2021-01-13 16:10 +, Limonciello, Mario wrote as excerpted: > > I don't think it's a true dependency. You can use fwupdtool without it. > > It's only needed for fwupdmgr. > > Perhaps a Recommends would be better? > > I didn't know if fwupd is really useful without fwupdmgr. If using fwupd > without fwupdmgr is a common use case then yes, listing dbus as recommended > package is probably appropriate. > I don't believe we have any evidence to say which use cases are more "common". But it's a use case that is supported by upstream, particularly since you can now optionally build without daemon/client and fwupdtool is placed in PATH by default. As such, I'll add a Recommends. > > That being said I don't think it would solve it for you. Systemd has dbus > > as a Recommends and you still appear to not have it. > > Even if systems are configured to not install recommended packages by default > (you are right, it does not solve it for me), then the list of recommended > packages can provide helpful clues, at least. OK.
Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
Thanks for your quick reply, Mario. On Wed, 2021-01-13 16:10 +, Limonciello, Mario wrote as excerpted: > I don't think it's a true dependency. You can use fwupdtool without it. > It's only needed for fwupdmgr. > Perhaps a Recommends would be better? I didn't know if fwupd is really useful without fwupdmgr. If using fwupd without fwupdmgr is a common use case then yes, listing dbus as recommended package is probably appropriate. > That being said I don't think it would solve it for you. Systemd has dbus > as a Recommends and you still appear to not have it. Even if systems are configured to not install recommended packages by default (you are right, it does not solve it for me), then the list of recommended packages can provide helpful clues, at least. Cheers, Lukas signature.asc Description: This is a digitally signed message part
Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
I don't think it's a true dependency. You can use fwupdtool without it. It's
only needed for fwupdmgr.
Perhaps a Recommends would be better?
That being said I don't think it would solve it for you. Systemd has dbus as a
Recommends and you still appear to not have it.
> -Original Message-
> From: lukas
> Sent: Wednesday, January 13, 2021 6:55
> To: Debian Bug Tracking System
> Subject: Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
>
>
> [EXTERNAL EMAIL]
>
> Package: fwupd
> Version: 1.5.3-2
> Severity: important
>
> Dear Maintainers,
>
> thanks for maintaining this package and taking the time to consider this bug
> report.
>
> On a minimal system, it happened to me that when installing fwupd, dbus is
> has not been installed as a dependency.
> Without dbus, fwupd turned out to be unusable ("Failed to connect to daemon"
> on ``fwupdmgr refresh``).
>
> Do we maybe need to list the package "dbus" as a dependency of "fwupd"?
>
> Cheers,
>
> Lukas
>
> -- System Information:
> Debian Release: bullseye/sid
> APT prefers testing
> APT policy: (500, 'testing')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 5.10.0-1-amd64 (SMP w/4 CPU threads)
> Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> LANGUAGE=en_US:en
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> Versions of packages fwupd depends on:
> ii libc6 2.31-9
> ii libcurl3-gnutls7.74.0-1
> ii libefiboot137-6
> ii libelf10.182-3
> ii libflashrom1 1.2-5
> ii libfwupd2 1.5.3-2
> ii libfwupdplugin11.5.3-2
> ii libglib2.0-0 2.66.4-1
> ii libgudev-1.0-0 234-1
> ii libgusb2 0.3.5-1
> ii libjcat1 0.1.3-2
> ii libjson-glib-1.0-0 1.6.0-2
> ii libpolkit-gobject-1-0 0.105-29
> ii libsmbios-c2 2.4.3-1
> ii libsqlite3-0 3.34.0-1
> ii libsystemd0247.2-4
> ii libtss2-esys-3.0.2-0 3.0.3-1
> ii libxmlb1 0.1.15-2
> ii shared-mime-info 2.0-1
>
> Versions of packages fwupd recommends:
> pn bolt
> pn fwupd-signed
> ii python33.9.1-1
> pn secureboot-db
> ii udisks22.9.1-2
>
> fwupd suggests no packages.
>
> -- no debconf information
Bug#980049: fwupd: Should fwupd specify dbus as a dependency?
Package: fwupd
Version: 1.5.3-2
Severity: important
Dear Maintainers,
thanks for maintaining this package and taking the time to consider this bug
report.
On a minimal system, it happened to me that when installing fwupd, dbus is
has not been installed as a dependency.
Without dbus, fwupd turned out to be unusable ("Failed to connect to daemon"
on ``fwupdmgr refresh``).
Do we maybe need to list the package "dbus" as a dependency of "fwupd"?
Cheers,
Lukas
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages fwupd depends on:
ii libc6 2.31-9
ii libcurl3-gnutls7.74.0-1
ii libefiboot137-6
ii libelf10.182-3
ii libflashrom1 1.2-5
ii libfwupd2 1.5.3-2
ii libfwupdplugin11.5.3-2
ii libglib2.0-0 2.66.4-1
ii libgudev-1.0-0 234-1
ii libgusb2 0.3.5-1
ii libjcat1 0.1.3-2
ii libjson-glib-1.0-0 1.6.0-2
ii libpolkit-gobject-1-0 0.105-29
ii libsmbios-c2 2.4.3-1
ii libsqlite3-0 3.34.0-1
ii libsystemd0247.2-4
ii libtss2-esys-3.0.2-0 3.0.3-1
ii libxmlb1 0.1.15-2
ii shared-mime-info 2.0-1
Versions of packages fwupd recommends:
pn bolt
pn fwupd-signed
ii python33.9.1-1
pn secureboot-db
ii udisks22.9.1-2
fwupd suggests no packages.
-- no debconf information
