Bug#983227: coz-profiler: drop unused Build-Depends

[Helmut Grohne]

Hi Petter,

On Thu, May 09, 2024 at 11:07:20AM +0200, Petter Reinholdtsen wrote:
> The reason it have these build dependencies, is to make sure the package
> only build on architectures where it will actually work, to avoid
> earning a release critical bug of providing binaries that do not work.
> 
> I am thus very reluctant to drop build dependencies also needed at
> runtime.

Your reasoning on this is sound to me. Would you mind adding comments to
debian/control documenting this non-obvious aspect such that the next
time someone looks for technically unused dependencies they see why
they're there?

>From my pov, please close this bug when documenting their need.

Helmut

Bug#983227: coz-profiler: drop unused Build-Depends

[Petter Reinholdtsen]

Control: tags -1 + wontfix

[Helmut Grohne 2021-02-21]
> actually builds with gcc rather than clang. Thus clang can be dropped.
> The fonts and javascript libraries are not needed for building either,
> they're only needed in an installation. Please consider applying the
> attached patch to drop all of the mentioned dependencies.

The reason it have these build dependencies, is to make sure the package
only build on architectures where it will actually work, to avoid
earning a release critical bug of providing binaries that do not work.

I am thus very reluctant to drop build dependencies also needed at
runtime.
-- 
Happy hacking
Petter Reinholdtsen

Bug#983227: coz-profiler: drop unused Build-Depends

[Helmut Grohne]

Source: coz-profiler
Version: 0.2.2-2
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: cross-satisfiability

coz-profiler cannot be cross built from source, because it has
unsatisfiable Build-Depends. Instead of looking into such a difficult
problem, I looked into easily droppable dependencies and noticed that it
actually builds with gcc rather than clang. Thus clang can be dropped.
The fonts and javascript libraries are not needed for building either,
they're only needed in an installation. Please consider applying the
attached patch to drop all of the mentioned dependencies.

Helmut
diff --minimal -Nru coz-profiler-0.2.2/debian/changelog 
coz-profiler-0.2.2/debian/changelog
--- coz-profiler-0.2.2/debian/changelog 2020-09-05 11:17:25.0 +0200
+++ coz-profiler-0.2.2/debian/changelog 2021-02-21 11:16:15.0 +0100
@@ -1,3 +1,14 @@
+coz-profiler (0.2.2-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Drop unused Build-Depends: (Closes: #-1)
++ The package actually builds with gcc. Drop clang.
++ fonts-font-awesome, libjs-jquery, libjs-d3, libjs-d3-tip are used to
+  replace copies of them with symlinks. For building we don't need the
+  symlink targets to exist. Keep them in runtime depends only.
+
+ -- Helmut Grohne   Sun, 21 Feb 2021 11:16:15 +0100
+
 coz-profiler (0.2.2-2) unstable; urgency=medium
 
   [ Lluis Vilanova ]
diff --minimal -Nru coz-profiler-0.2.2/debian/control 
coz-profiler-0.2.2/debian/control
--- coz-profiler-0.2.2/debian/control   2020-09-02 18:24:05.0 +0200
+++ coz-profiler-0.2.2/debian/control   2021-02-21 11:16:14.0 +0100
@@ -4,14 +4,9 @@
 Maintainer: Lluís Vilanova 
 Uploaders: Petter Reinholdtsen 
 Build-Depends: debhelper (>= 13~)
- , clang
  , python3
  , pkg-config
  , libelfin-dev (>= 0.2)
- , fonts-font-awesome
- , libjs-jquery
- , libjs-d3
- , libjs-d3-tip
  , python3-docutils
 Standards-Version: 4.4.0
 Homepage: http://coz-profiler.org/