Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-03 Thread Vasyl Gello
Source: libsmbclient-dev
Version: 2:4.9.5+dfsg-5+deb10u1
Severity: important
Tags: ftbfs patch
Justification: fails to build from source
X-Debbugs-Cc: sramac...@debian.org

Dear colleagues,

I encountered an old SMB client header bug trying to backport ffmpeg 4.3.2 to 
buster.
The build logs are identical to https://bugs.gentoo.org/666548 and the patch 
applied
from there (attached to this message) does resolve the build failure on 
buster-bpo for
amd64 and i386.

Is it possible to incorporate this low-risk fix to stable-updates / 
stable-security?

Regards,
Vasyl

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-66-generic (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
>From 11e8c14b78e2423041f3846882f74cd6490a3e44 Mon Sep 17 00:00:00 2001
From: Joan Karadimov 
Date: Thu, 18 Oct 2018 18:16:17 +0300
Subject: [PATCH] Fix compatibility issues with the timespec struct

---
 source3/include/libsmbclient.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/source3/include/libsmbclient.h b/source3/include/libsmbclient.h
index 5e4a1715402..6487ea7a8aa 100644
--- a/source3/include/libsmbclient.h
+++ b/source3/include/libsmbclient.h
@@ -78,6 +78,7 @@ extern "C" {
 #include 
 #include 
 #include 
+#include 
 #include 
 
   /* Debian bug #221618 */


Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Andrei POPESCU
Control: reassign -1 src:samba 2:4.9.5+dfsg-5+deb10u1

On Jo, 04 mar 21, 04:41:11, Vasyl Gello wrote:
> Source: libsmbclient-dev

Assuming you meant "source of libsmbclient-dev" here (this syntax is not 
supported by the BTS).

> Version: 2:4.9.5+dfsg-5+deb10u1
> Severity: important
> Tags: ftbfs patch
> Justification: fails to build from source
> X-Debbugs-Cc: sramac...@debian.org
> 
> Dear colleagues,
> 
> I encountered an old SMB client header bug trying to backport ffmpeg 4.3.2 to 
> buster.
> The build logs are identical to https://bugs.gentoo.org/666548 and the patch 
> applied
> from there (attached to this message) does resolve the build failure on 
> buster-bpo for
> amd64 and i386.
> 
> Is it possible to incorporate this low-risk fix to stable-updates / 
> stable-security?
> 
> Regards,
> Vasyl
> 
> -- System Information:
> Debian Release: bullseye/sid
>   APT prefers unstable-debug
>   APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
> 'unstable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 5.4.0-66-generic (SMP w/6 CPU threads)
> Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
> Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
> en_US.UTF-8), LANGUAGE not set
> Shell: /bin/sh linked to /bin/dash
> Init: unable to detect

> From 11e8c14b78e2423041f3846882f74cd6490a3e44 Mon Sep 17 00:00:00 2001
> From: Joan Karadimov 
> Date: Thu, 18 Oct 2018 18:16:17 +0300
> Subject: [PATCH] Fix compatibility issues with the timespec struct
> 
> ---
>  source3/include/libsmbclient.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/source3/include/libsmbclient.h b/source3/include/libsmbclient.h
> index 5e4a1715402..6487ea7a8aa 100644
> --- a/source3/include/libsmbclient.h
> +++ b/source3/include/libsmbclient.h
> @@ -78,6 +78,7 @@ extern "C" {
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  
>/* Debian bug #221618 */


Kind regards,
Andrei
-- 
Looking after bugs assigned to unknown or inexistent packages


signature.asc
Description: PGP signature


Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Vasyl Gello
Hi Andrei!

>Assuming you meant "source of libsmbclient-dev" here (this syntax is not 
>supported by the BTS).

Correct, thank you!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Mathieu Parent
Hi,

Le ven. 5 mars 2021 à 13:22, Andrei POPESCU  a écrit :

> > Is it possible to incorporate this low-risk fix to stable-updates / 
> > stable-security?

I won't have the time to handle this. But if any Debian Developer
wants, please reach me.

Regards
-- 
Mathieu Parent



Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Vasyl Gello
Hi Mathieu, Andrei, Mattia,

> I won't have the time to handle this. But if any Debian Developer
> wants, please reach me.

I have already prepared & tested the fix, but I am not a DD :)

Mattia, can you sponsor the upload then, please?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Mathieu Parent
Le ven. 5 mars 2021 à 15:02, Vasyl Gello  a écrit :
>
> Hi Mathieu, Andrei, Mattia,
>
> > I won't have the time to handle this. But if any Debian Developer
> > wants, please reach me.
>
> I have already prepared & tested the fix, but I am not a DD :)

Please push this to a MR, for review.

> Mattia, can you sponsor the upload then, please?


Regards
-- 
Mathieu Parent



Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Mattia Rizzolo
On Fri, 5 Mar 2021, 3:06 pm Mathieu Parent,  wrote:

> Le ven. 5 mars 2021 à 15:02, Vasyl Gello  a écrit :
> >
> > Hi Mathieu, Andrei, Mattia,
> >
> > > I won't have the time to handle this. But if any Debian Developer
> > > wants, please reach me.
> >
> > I have already prepared & tested the fix, but I am not a DD :)
>
> Please push this to a MR, for review.
>
> > Mattia, can you sponsor the upload then, please?
>

Beside the MR which is maintainer-specific workflow, you'll need to open a
pu bug for the release team.  I think I'm ready to upload anytime, but I'd
rather you file a bug first, mentioning that you'll upload soon after that.


Bug#984486: libsmbclient-dev: ffmpeg 4.3.2 FTBFS against libsmbclient.h

2021-03-05 Thread Vasyl Gello
Hi!

>> Please push this to a MR, for review.

MR: https://salsa.debian.org/samba-team/samba/-/merge_requests/51

> Beside the MR which is maintainer-specific workflow, you'll need to open a
> pu bug for the release team.

Doing that already :)
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

5 березня 2021 р. 14:18:38 UTC, Mattia Rizzolo  написав(-ла):
>On Fri, 5 Mar 2021, 3:06 pm Mathieu Parent,  wrote:
>
>> Le ven. 5 mars 2021 à 15:02, Vasyl Gello  a écrit :
>> >
>> > Hi Mathieu, Andrei, Mattia,
>> >
>> > > I won't have the time to handle this. But if any Debian Developer
>> > > wants, please reach me.
>> >
>> > I have already prepared & tested the fix, but I am not a DD :)
>>
>
>>
>> > Mattia, can you sponsor the upload then, please?
>>
>
>Beside the MR which is maintainer-specific workflow, you'll need to open a
>pu bug for the release team.  I think I'm ready to upload anytime, but I'd
>rather you file a bug first, mentioning that you'll upload soon after that.