Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
On 2021-03-05 16:51:44 +, Vasyl Gello wrote: > Hi Sebastian! > > > FWIW, the relevant version for buster-backports is ffmpeg > > 7:4.3.2-0+deb11u1 which does not require libsmbclient-dev. So the bug in > > samba does not prevent backports of ffmpeg > > Strange, I have noticed that 7:4.3.2-0+deb11u1 sits in debian/bullseye branch > of ffmpeg, but not in debian/master. > What is more strange, 'gbp pull --all' does not populate new branches so > there is no way to distinguish from CLI > if the new Git branch was cut. > > Anyway, I think it is nice to have a fixed samba in buster. Or you are not > planning to enable smbclient within ffmpeg > for bullseye at all? It's too late to introduce new binary packages in bullseye. The changes in debian/master are already for bookworm. That's why I have branched of debian/bullseye before the experimental uploads. smbclient in ffmpeg won't happen for bullseye. Cheers > -- > Vasyl Gello > == > Certified SolidWorks Expert > > Mob.:+380 (98) 465 66 77 > > E-Mail: vasek.ge...@gmail.com > > Skype: vasek.gello > == > 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다 -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
Hi Sebastian! > FWIW, the relevant version for buster-backports is ffmpeg > 7:4.3.2-0+deb11u1 which does not require libsmbclient-dev. So the bug in > samba does not prevent backports of ffmpeg Strange, I have noticed that 7:4.3.2-0+deb11u1 sits in debian/bullseye branch of ffmpeg, but not in debian/master. What is more strange, 'gbp pull --all' does not populate new branches so there is no way to distinguish from CLI if the new Git branch was cut. Anyway, I think it is nice to have a fixed samba in buster. Or you are not planning to enable smbclient within ffmpeg for bullseye at all? -- Vasyl Gello == Certified SolidWorks Expert Mob.:+380 (98) 465 66 77 E-Mail: vasek.ge...@gmail.com Skype: vasek.gello == 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
Hi Adam! > There is no "buster / buster-security". You need to pick one. (and if > it's security then you need to talk to the Security Team, not the > Release Team.) Sorry for confusion! I wrote both because they are exactly the same version. The fix is not related to security - it is a header-only FTBFS fix so I chose "buster" in d/changelog in the Salsa MR I mentioned. > Does it fix #939419 as well? Because if not then the packages will get > rejected by the archive software as soon as they're uploaded from the > buildds. No, at the moment it does not. Should I backport that change too? I can do that if needed. -- Vasyl Gello == Certified SolidWorks Expert Mob.:+380 (98) 465 66 77 E-Mail: vasek.ge...@gmail.com Skype: vasek.gello == 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
On 2021-03-05 15:21:59, Vasyl Gello wrote: > Package: release.debian.org > Severity: normal > Tags: buster > User: release.debian@packages.debian.org > Usertags: pu > X-Debbugs-Cc: mat...@debian.org, math.par...@gmail.com > > Dear colleagues, > > Please accept the proposed update of samba in buster / buster-security > after the fix closing #984486 gets merged by Mathieu and uploaded to > stable queue. > > [ Reason ] > > I encountered the missing header include within libsmbclient-dev > trying to do a no-change rebuild of ffmpeg 4.3.2 for buster-backports. FWIW, the relevant version for buster-backports is ffmpeg 7:4.3.2-0+deb11u1 which does not require libsmbclient-dev. So the bug in samba does not prevent backports of ffmpeg Cheers > > The problem has been reported to Samba upstream by Gentoo maintainers > two years ago there: https://bugs.gentoo.org/666548 and the only contribution > I made in re this bug is adapting the patch for Debian's samba source tree: > > https://salsa.debian.org/samba-team/samba/-/merge_requests/51 > > [ Impact ] > > ffmpeg >= 4.3.1-8 will FTBFS due to re-added libsmbclient build-dependency > > [ Tests ] > > Build passes, built package from my unofficial Kodi from Debian repo is > tested by me & other (several dozen) users. > > [ Risks ] > > The risk is low because: > > * It is a header-only change > * It has been accepted by upstream 2 years ago > * I confirmed ffmpeg builds fine with modified samba package > * Quite many unofficial repo users > > [ Checklist ] > [x] *all* changes are documented in the d/changelog > [x] I reviewed all changes and I approve them > [x] attach debdiff against the package in (old)stable > [x] the issue is verified as fixed in unstable > > [ Changes ] > > One patch added, debian/patches/fix-timeval.patch that includes > into source3/include/libsmbclient.h > > [ Other info ] > > Debdiff will be added after MR gets merged. > -- Sebastian Ramacher
Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
Control: tags -1 + moreinfo On Fri, 2021-03-05 at 15:21 +, Vasyl Gello wrote: > Please accept the proposed update of samba in buster / buster- > security There is no "buster / buster-security". You need to pick one. (and if it's security then you need to talk to the Security Team, not the Release Team.) > after the fix closing #984486 gets merged by Mathieu and uploaded to > stable queue. > Does it fix #939419 as well? Because if not then the packages will get rejected by the archive software as soon as they're uploaded from the buildds. Regards, Adam
Bug#984595: buster-pu: package samba/2:4.9.5+dfsg-5
Package: release.debian.org Severity: normal Tags: buster User: release.debian@packages.debian.org Usertags: pu X-Debbugs-Cc: mat...@debian.org, math.par...@gmail.com Dear colleagues, Please accept the proposed update of samba in buster / buster-security after the fix closing #984486 gets merged by Mathieu and uploaded to stable queue. [ Reason ] I encountered the missing header include within libsmbclient-dev trying to do a no-change rebuild of ffmpeg 4.3.2 for buster-backports. The problem has been reported to Samba upstream by Gentoo maintainers two years ago there: https://bugs.gentoo.org/666548 and the only contribution I made in re this bug is adapting the patch for Debian's samba source tree: https://salsa.debian.org/samba-team/samba/-/merge_requests/51 [ Impact ] ffmpeg >= 4.3.1-8 will FTBFS due to re-added libsmbclient build-dependency [ Tests ] Build passes, built package from my unofficial Kodi from Debian repo is tested by me & other (several dozen) users. [ Risks ] The risk is low because: * It is a header-only change * It has been accepted by upstream 2 years ago * I confirmed ffmpeg builds fine with modified samba package * Quite many unofficial repo users [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in (old)stable [x] the issue is verified as fixed in unstable [ Changes ] One patch added, debian/patches/fix-timeval.patch that includes into source3/include/libsmbclient.h [ Other info ] Debdiff will be added after MR gets merged.
