Bug#984630: python3-waitress: leaves alternatives after upgrade: /etc/alternatives/waitress-serve -> /usr/bin/waitress-serve-python3

2021-04-20 Thread Andreas Beckmann 
Followup-For: Bug #984630
Control: tag -1 pending

Hi,

I've just uploaded a NMU with the fix to DELAYED/5.


Andreas

Bug#984630: python3-waitress: leaves alternatives after upgrade: /etc/alternatives/waitress-serve -> /usr/bin/waitress-serve-python3

2021-04-02 Thread Andreas Beckmann 
Followup-For: Bug #984630
Control: tag -1 patch
diff -Nru waitress-1.4.4/debian/changelog waitress-1.4.4/debian/changelog
--- waitress-1.4.4/debian/changelog 2021-01-09 10:16:20.0 +0100
+++ waitress-1.4.4/debian/changelog 2021-04-02 15:03:03.0 +0200
@@ -1,3 +1,9 @@
+waitress (1.4.4-2) UNRELEASED; urgency=medium
+
+  * Fix cleanup of the waitress-serve alternative.  (Closes: #984630)
+
+ -- Andreas Beckmann   Fri, 02 Apr 2021 15:03:03 +0200
+
 waitress (1.4.4-1) unstable; urgency=medium
 
   [ Andrej Shadura ]
diff -Nru waitress-1.4.4/debian/python3-waitress.preinst 
waitress-1.4.4/debian/python3-waitress.preinst
--- waitress-1.4.4/debian/python3-waitress.preinst  2021-01-09 
10:16:20.0 +0100
+++ waitress-1.4.4/debian/python3-waitress.preinst  2021-04-02 
15:03:03.0 +0200
@@ -2,7 +2,7 @@
 
 set -e
 
-if [ "$1" = "configure" ]
+if [ "$1" = "upgrade" ]
 then
 if update-alternatives --list waitress-serve >/dev/null 2>&1
 then

Bug#984630: python3-waitress: leaves alternatives after upgrade: /etc/alternatives/waitress-serve -> /usr/bin/waitress-serve-python3

2021-03-05 Thread Andreas Beckmann 
Package: python3-waitress
Version: 1.4.4-1
Severity: important
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-removal-and-or-configuration-purging

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

>From the attached log (scroll to the bottom...):

1m8.4s INFO: Warning: Package purging left files on system:
  /etc/alternatives/waitress-serve -> /usr/bin/waitress-serve-python3not 
owned

The preinst script already has the code to clean up the alternative,
but that does not get called because the preint script is never called
with the argument "configure". Please trigger this cleanup in "upgrade"
instead.

cheers,

Andreas


python3-waitress_1.4.4-1.log.gz
Description: application/gzip