Bug#985228: unblock: petsc/3.14.5+dfsg1-2
On 2021-04-08 15:25, Paul Gevers wrote: Hi Drew, On 08-04-2021 15:01, Drew Parsons wrote: While petsc and release is close to mind, I'd like to request preauthorization for petsc/3.14.5+dfsg1-3 to make a minimal update to fix Bug#985659 (fixing broken symlinks in docs). You stretched us already quite a bit with -2. What we were missing is an explanation from you of all the changes in the release in an effort to convince us that the upstream release was a targeted fix. Graham spend quite some time to convince himself that this is a bug fix release (apparently he wanted to help you). I rather want the maintainer to do that work as it's really not sustainable to do this as Release Team for the whole Debian archive (we get lots of requests). Please read the FAQ [1]. Please, make a good judgement call and consider that we can only spend our time once. unblock request that are *not* clearly in line with our freeze policy take more time and energy from us. Having to judge corner cases is mentally straining. Denying an unblock request isn't nice. Follow the rules and you make our lives as Release Managers a lot easier. I hear you Paul, I'll take that as a general no on 3.14.6. I appreciate yours and Graham's effort with 3.14.5-2. I'll cherry-pick some specific, targetted fixes from 3.14.6. A couple of them do look unambiguously important. The fix for Bug#985659 will be trivial. Drew
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
Hi Drew, On 08-04-2021 15:01, Drew Parsons wrote: > While petsc and release is close to mind, I'd like to request > preauthorization for petsc/3.14.5+dfsg1-3 to make a minimal update to > fix Bug#985659 (fixing broken symlinks in docs). You stretched us already quite a bit with -2. What we were missing is an explanation from you of all the changes in the release in an effort to convince us that the upstream release was a targeted fix. Graham spend quite some time to convince himself that this is a bug fix release (apparently he wanted to help you). I rather want the maintainer to do that work as it's really not sustainable to do this as Release Team for the whole Debian archive (we get lots of requests). Please read the FAQ [1]. Please, make a good judgement call and consider that we can only spend our time once. unblock request that are *not* clearly in line with our freeze policy take more time and energy from us. Having to judge corner cases is mentally straining. Denying an unblock request isn't nice. Follow the rules and you make our lives as Release Managers a lot easier. Paul [1] https://release.debian.org/bullseye/FAQ.html OpenPGP_signature Description: OpenPGP digital signature
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
On 2021-04-08 14:29, Graham Inggs wrote: Unblocked. Thanks Graham. While petsc and release is close to mind, I'd like to request preauthorization for petsc/3.14.5+dfsg1-3 to make a minimal update to fix Bug#985659 (fixing broken symlinks in docs). Beyond that, what is your mood with respect to petsc 3.14.6, released a week ago? Again fixes a handful of small bugs, perhaps less important than the 3.14.5 patch. https://gitlab.com/petsc/petsc/-/commits/v3.14.6 3.15.0 was also just released, so 3.14.6 would be the last bugfix release in petsc 3.14. Perhaps bullseye will have to manage without it. Drew
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
On 2021-03-16 17:32, Ivo De Decker wrote:
Control: tags -1 moreinfo
...
On Sun, Mar 14, 2021 at 09:01:26PM +0100, Drew Parsons wrote:
upstream released petsc 3.14.5 with bug fixes only.
This will help improve the stability of the package over the lifetime
of the bullseye release.
I'm not convinced this complies with the freeze policy (but see below).
...
[ ] attach debdiff against the package in testing
We ask these this for a reason. The current diff between the version in
testing and unstable is very large and unreviewable. It certainly isn't
going
to get unblocked like this. If you can provide a filtered diff, with
only the
'real' changes, and not the noise generated by the new upstream
release,
there's at least a chance we could look at them. Note that this doesn't
guarantee it will be unblocked. There's still a decent chance that the
changes
will be too big.
Hi Ivo, I'm attaching the essential debdiff, omitting changes to docs,
TAGS and html files and trivial whitespace reformatting. I also omitted
the diff to src/ts/trajectory/impls/memory/trajmemory.c, involving the
conditional "#if defined(PETSC_HAVE_REVOLVE)", since we do not build
against revolve.
My argument is that this patch makes petsc and therefore bullseye a
little more robust.
Drew
diff -Nru --exclude '*.html' --exclude '*docs*' petsc-3.14.4+dfsg1/debian/changelog petsc-3.14.5+dfsg1/debian/changelog
--- petsc-3.14.4+dfsg1/debian/changelog 2021-02-11 16:51:02.0 +0100
+++ petsc-3.14.5+dfsg1/debian/changelog 2021-03-10 12:21:59.0 +0100
@@ -1,3 +1,22 @@
+petsc (3.14.5+dfsg1-2) unstable; urgency=medium
+
+ * upload new bugfix release to unstable
+
+ -- Drew Parsons Wed, 10 Mar 2021 12:21:59 +0100
+
+petsc (3.14.5+dfsg1-1) experimental; urgency=medium
+
+ * New upstream release (bugfixes)
+
+ -- Drew Parsons Mon, 08 Mar 2021 18:37:39 +0100
+
+petsc (3.14.4+dfsg1-2) unstable; urgency=medium
+
+ * fix PETSC64_NAME in libpetsc64-complex3.14-dev.prerm to enable a
+clean uninstall of libpetsc64-complex3.14-dev. Closes: #983892.
+
+ -- Drew Parsons Mon, 08 Mar 2021 18:27:40 +0100
+
petsc (3.14.4+dfsg1-1) unstable; urgency=medium
* New upstream release.
diff -Nru --exclude '*.html' --exclude '*docs*' petsc-3.14.4+dfsg1/debian/libpetsc64-complex3.14-dev.prerm petsc-3.14.5+dfsg1/debian/libpetsc64-complex3.14-dev.prerm
--- petsc-3.14.4+dfsg1/debian/libpetsc64-complex3.14-dev.prerm 2021-02-11 16:51:02.0 +0100
+++ petsc-3.14.5+dfsg1/debian/libpetsc64-complex3.14-dev.prerm 2021-03-10 12:21:59.0 +0100
@@ -8,7 +8,7 @@
PETSC_ARCH=${DEB_HOST_MULTIARCH}
PETSC_COMPLEX_ARCH=${PETSC_ARCH}-complex
PETSC_SONAME_VERSION=__PETSC_SONAME_VERSION__
-PETSC64_NAME=petsc${PETSC_SONAME_VERSION}
+PETSC64_NAME=petsc64-${PETSC_SONAME_VERSION}
PETSC64_DIR_COMPLEX=/usr/lib/petscdir/${PETSC64_NAME}/${PETSC_COMPLEX_ARCH}
diff -Nru --exclude '*.html' --exclude '*docs*' petsc-3.14.4+dfsg1/include/petsc/private/petschpddm.h petsc-3.14.5+dfsg1/include/petsc/private/petschpddm.h
--- petsc-3.14.4+dfsg1/include/petsc/private/petschpddm.h 2020-11-03 19:01:59.0 +0100
+++ petsc-3.14.5+dfsg1/include/petsc/private/petschpddm.h 2021-03-03 23:13:43.0 +0100
@@ -31,6 +31,7 @@
PC_HPDDM_Level **levels; /* array of shells */
Mat aux;/* local auxiliary matrix defined at the finest level on PETSC_COMM_SELF */
Mat B; /* right-hand side matrix defined at the finest level on PETSC_COMM_SELF */
+ Vec normal; /* temporary Vec when preconditioning the normal equations with KSPLSQR */
IS is; /* global numbering of the auxiliary matrix */
PetscIntN; /* number of levels */
PCHPDDMCoarseCorrectionType correction; /* type of coarse correction */
diff -Nru --exclude '*.html' --exclude '*docs*' petsc-3.14.4+dfsg1/src/dm/dt/fe/interface/ftn-custom/zfef.c petsc-3.14.5+dfsg1/src/dm/dt/fe/interface/ftn-custom/zfef.c
--- petsc-3.14.4+dfsg1/src/dm/dt/fe/interface/ftn-custom/zfef.c 2020-11-03 19:01:59.0 +0100
+++ petsc-3.14.5+dfsg1/src/dm/dt/fe/interface/ftn-custom/zfef.c 2021-03-03 23:09:50.0 +0100
@@ -17,6 +17,7 @@
char *t;
FIXCHAR(type,len,t);
+ CHKFORTRANNULLOBJECT(obj);
*ierr = PetscSpaceViewFromOptions(*ao,obj,t);if (*ierr) return;
FREECHAR(type,t);
}
@@ -26,6 +27,7 @@
char *t;
FIXCHAR(type,len,t);
+ CHKFORTRANNULLOBJECT(obj);
*ierr = PetscDualSpaceViewFromOptions(*ao,obj,t);if (*ierr) return;
FREECHAR(type,t);
}
@@ -35,6 +37,7 @@
char *t;
FIXCHAR(type,len,t);
+ CHKFORTRANNULLOBJECT(obj);
*ierr = PetscFEViewFromOptions(*ao,obj,t);if (*ierr) return;
FREECHAR(type,t);
}
diff -Nru --exclude '*.html' --exclude '*docs*' petsc-3.14.4+dfsg1/src/dm/dt/fv/interface/ftn-custom/zfvf.c petsc-3.14.5+dfsg1/src/dm/dt/fv/interface/ftn-custom/zfvf.c
---
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
Thanks Ivo, I'll prepare a filtered diff for consideration. Drew On 2021-03-16 17:32, Ivo De Decker wrote: Control: tags -1 moreinfo ... [ ] attach debdiff against the package in testing We ask these this for a reason. The current diff between the version in testing and unstable is very large and unreviewable. It certainly isn't going to get unblocked like this. If you can provide a filtered diff, with only the 'real' changes, and not the noise generated by the new upstream release, there's at least a chance we could look at them. Note that this doesn't guarantee it will be unblocked. There's still a decent chance that the changes will be too big.
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
Control: tags -1 moreinfo Hi, On Sun, Mar 14, 2021 at 09:01:26PM +0100, Drew Parsons wrote: > upstream released petsc 3.14.5 with bug fixes only. > This will help improve the stability of the package over the lifetime > of the bullseye release. I'm not convinced this complies with the freeze policy (but see below). > This update also fixes Bug#983892, fixing orphaned alternatives after > removal of libpetsc64-complex3.14-dev, > > [ Impact ] > > If this release is not permitted into stable then some users may > encounter the issues addressed by the patch, especially when running > under MPI parallelization. A range of bugs have been addressed: > - MatBAIJ: Fix specialization for size 9 > - Do not use MPI_Bcast() on a single rank. > - PCHPDDM: fix for KSPLSQR > - DMPlexVTKWriteAll_VTU: a couple of bugfixes > - handling error conditions in PetscOptions > - handling NULL objects in Fortran interface > - bugfix for MatMatMultSymbolic_MPIAIJ_MPIDense() > - CPARDISO: stick to OpenMPI BLACS when needed > - minor Documentation fixes > If the release is not allowed into stable then > libpetsc64-complex3.14-dev will leave dangling alternatives links when > removed. This specific issue could be fixed without switching to a new upstream version (as was done initially in 3.14.4+dfsg1-2). > [ Tests ] > > debian/tests autopkgtest is enabled. > petsc debci tests have passed in unstable. > > debci tests in client packages are also passing successfully in unstable > (petsc4py, slepc, slep4py, deal.ii, dolfin, mshr, dolfinx) > > sundials continues to build successfully. > > [ Risks ] > > The patch fixes a range of bugs, it is not a simple one-line patch. > [ Checklist ] > [-] all changes are documented in the d/changelog > - documented as "New upstream release (bugfixes)" > [x] I reviewed all changes and I approve them > [ ] attach debdiff against the package in testing We ask these this for a reason. The current diff between the version in testing and unstable is very large and unreviewable. It certainly isn't going to get unblocked like this. If you can provide a filtered diff, with only the 'real' changes, and not the noise generated by the new upstream release, there's at least a chance we could look at them. Note that this doesn't guarantee it will be unblocked. There's still a decent chance that the changes will be too big. Thanks, Ivo
Bug#985228: unblock: petsc/3.14.5+dfsg1-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package petsc [ Reason ] upstream released petsc 3.14.5 with bug fixes only. This will help improve the stability of the package over the lifetime of the bullseye release. This update also fixes Bug#983892, fixing orphaned alternatives after removal of libpetsc64-complex3.14-dev, [ Impact ] If this release is not permitted into stable then some users may encounter the issues addressed by the patch, especially when running under MPI parallelization. A range of bugs have been addressed: - MatBAIJ: Fix specialization for size 9 - Do not use MPI_Bcast() on a single rank. - PCHPDDM: fix for KSPLSQR - DMPlexVTKWriteAll_VTU: a couple of bugfixes - handling error conditions in PetscOptions - handling NULL objects in Fortran interface - bugfix for MatMatMultSymbolic_MPIAIJ_MPIDense() - CPARDISO: stick to OpenMPI BLACS when needed - minor Documentation fixes If the release is not allowed into stable then libpetsc64-complex3.14-dev will leave dangling alternatives links when removed. [ Tests ] debian/tests autopkgtest is enabled. petsc debci tests have passed in unstable. debci tests in client packages are also passing successfully in unstable (petsc4py, slepc, slep4py, deal.ii, dolfin, mshr, dolfinx) sundials continues to build successfully. [ Risks ] The patch fixes a range of bugs, it is not a simple one-line patch. [ Checklist ] [-] all changes are documented in the d/changelog - documented as "New upstream release (bugfixes)" [x] I reviewed all changes and I approve them [ ] attach debdiff against the package in testing unblock petsc/3.14.5+dfsg1-2
