Bug#985963: debuerreotype: uses debian-archive-keyring in autopkgtests without real dependency
control: tags -1 important > [1]: > https://github.com/debuerreotype/debian-debuerreotype/commit/349027dd77b24effecb9574fd61c40e81f283a74 > > However, I'm not sure I agree with "Severity: serious" (or even > whether this is worth an upload during the deep state of bullseye's > freeze), given that it only occurs in a non-standard configuration and > only applies to the tests (and does not render the package otherwise > unusable in any functional way). Thoughts? Ok, release team should be already aware of the issue, and I admit the severity was somewhat a corner-case scenario. Since it doesn't change anything on the package itself, and the autopkgtests passes in this configuration, I think its ok to downgrade (specially because the fix is already committed thanks for that!) They might want to increase the severity, but from my perspective, no rush at all :) Gianfranco
Bug#985963: debuerreotype: uses debian-archive-keyring in autopkgtests without real dependency
tags 985963 + pending thanks On Fri, 26 Mar 2021 at 15:45, Gianfranco Costamagna wrote: > Hello, looks like the debian/tests/stretch is using the keyring but the > package has only a recommends on that dependency. > This makes the autopkgtest fail when apt is configured with > --no-install-recommends. > > I see two solutions: > 1) make the debian-archive-keyring a real runtime dependency (from > recommends) in control file > 2) add the dependency on debian/tests/control. > > Since I think this is not a real dependency, I propose solution 2 for the > issue: Agreed, thanks! Committed to Git [1], pending the next upload. [1]: https://github.com/debuerreotype/debian-debuerreotype/commit/349027dd77b24effecb9574fd61c40e81f283a74 However, I'm not sure I agree with "Severity: serious" (or even whether this is worth an upload during the deep state of bullseye's freeze), given that it only occurs in a non-standard configuration and only applies to the tests (and does not render the package otherwise unusable in any functional way). Thoughts? ♥, - Tianon 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4
Bug#985963: debuerreotype: uses debian-archive-keyring in autopkgtests without real dependency
Source: debuerreotype Version: 0.10-2 Severity: serious Justification: breaks autopkgtests when recommended packages are not installed by default tags: patch Hello, looks like the debian/tests/stretch is using the keyring but the package has only a recommends on that dependency. This makes the autopkgtest fail when apt is configured with --no-install-recommends. I see two solutions: 1) make the debian-archive-keyring a real runtime dependency (from recommends) in control file 2) add the dependency on debian/tests/control. Since I think this is not a real dependency, I propose solution 2 for the issue: --- debuerreotype-0.10/debian/changelog 2021-02-25 21:56:24.0 +0100 +++ debuerreotype-0.10/debian/changelog 2021-03-26 23:36:13.0 +0100 @@ -1,3 +1,9 @@ +debuerreotype (0.10-3) UNRELEASED; urgency=medium + + * Depend on debian-archive-keyring for autopkgtests to succeed (Closes: #-1) + + -- Gianfranco Costamagna Fri, 26 Mar 2021 23:36:13 +0100 + debuerreotype (0.10-2) unstable; urgency=medium [ Tianon Gravi ] diff -Nru debuerreotype-0.10/debian/tests/control debuerreotype-0.10/debian/tests/control --- debuerreotype-0.10/debian/tests/control 2021-02-25 19:54:53.0 +0100 +++ debuerreotype-0.10/debian/tests/control 2021-03-26 23:35:49.0 +0100 @@ -1,5 +1,6 @@ Tests: stretch Depends: ca-certificates, + debian-archive-keyring, debootstrap, debuerreotype, diffoscope, Let me know if this sounds good for you too, and thanks for maintaining the package! Gianfranco
