Bug#987625: ntpdate -p samples number is 1 by default, which is not consistent with manpage

[Roger Shimizu]

control: found -1 1:4.2.8p10+dfsg-1
control: affects -1 adjtimex
control: block 944867 by -1

On Tue, Apr 27, 2021 at 2:33 AM Roger Shimizu  wrote:
>
> I found since buster version, -p samples default value changed from 4,
> which is in manpage, to 1.

Should be related to this commit:
* https://salsa.debian.org/pkg-ntp-team/ntp/-/commit/5263b05

ntpdate/ntpdate.c
Line 157

-int sys_samples = DEFSAMPLES;   /* number of samples/server */
+int sys_samples = 0;/* number of samples/server, will be
modified later */

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#987625: ntpdate -p samples number is 1 by default, which is not consistent with manpage

[Roger Shimizu]

Package: ntpdate
Version: 1:4.2.8p15+dfsg-1
Severity: important

Dear Maintainer,

I found since buster version, -p samples default value changed from 4,
which is in manpage, to 1.
So it will output "filter delay:" and "filter offset:" lines by
default in stretch version, 1:4.2.8p10+ based; but will not in buster or
later version, 1:4.2.8p12+ based.

You can check the output by command:
 $ ntpdate -d -q pool.ntp.org
 $ ntpdate -d -p4 -q pool.ntp.org

In manpage:
   -p samples
  Specify  the  number of samples to be acquired from each server as 
the integer samples, with values from 1 to 8
  inclusive. The default is 4.

So clearly the behaviour is not consistent with manpage.
Please kindly fix this, by either change the code, or update the
manpage. Thank you!

Cheers,
Roger