Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package fwlogwatch Dear Release Team, [ Reason ] I am requesting an unblock for an upload that addresses a grave [1] bug that was opened during the freeze. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987315 [ Impact ] If the unblock isn't granted, fwlogwatch should not ship with bullseye because it hangs during install and requires the user to stop the systemd unit and manually address the PID file issue . I don't have a sense of the impact of removal based on popcon, which 112. https://qa.debian.org/popcon.php?package=fwlogwatch [ Tests ] I reproduced the issue with the 1.4-2 package. I successful tested package installation, daemon startup, manipulation with systemctl, and package removal with 1.4-3. The upload also addresses a trivial bug in the autopkgtest that was preventing the tests from running at all. The tests now show as "No test results" on the PTS (https://tracker.debian.org/pkg/fwlogwatch), but that is because the test itself is now marked as superficial. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969828 [ Risks ] The fix to the name of the PID file is trivial. The package is leaf. I am not familiar with alternatives. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] Thank you for your work on Debian! unblock fwlogwatch/1.4-3
diff -Nru fwlogwatch-1.4/debian/changelog fwlogwatch-1.4/debian/changelog
--- fwlogwatch-1.4/debian/changelog 2019-07-22 05:27:20.000000000 -0700
+++ fwlogwatch-1.4/debian/changelog 2021-04-23 21:10:36.000000000 -0700
@@ -1,3 +1,12 @@
+fwlogwatch (1.4-3) unstable; urgency=medium
+
+ * QA upload.
+ * Correct service PID file (Closes: #987315)
+ * Mark autopkgtest as superficial (Closes: #969828)
+ * Correct the path to the fwlogwatch command in the autopkgtest.
+
+ -- tony mancill <tmanc...@debian.org> Fri, 23 Apr 2021 21:10:36 -0700
+
fwlogwatch (1.4-2) unstable; urgency=medium
* QA upload.
diff -Nru fwlogwatch-1.4/debian/fwlogwatch.service
fwlogwatch-1.4/debian/fwlogwatch.service
--- fwlogwatch-1.4/debian/fwlogwatch.service 2019-07-22 05:27:20.000000000
-0700
+++ fwlogwatch-1.4/debian/fwlogwatch.service 2021-04-23 21:10:36.000000000
-0700
@@ -9,7 +9,7 @@
'if [ "x${START_DAEMON}" != "xtrue" ]; then echo "aborted"; exit 1; fi; \
exec /usr/sbin/fwlogwatch -c /etc/fwlogwatch/fwlogwatch.config -R ${PARAMS}'
Type=forking
-PIDFile=/run/htpdate.pid
+PIDFile=/run/fwlogwatch.pid
################
### Security ###
################
diff -Nru fwlogwatch-1.4/debian/tests/control
fwlogwatch-1.4/debian/tests/control
--- fwlogwatch-1.4/debian/tests/control 2019-07-22 05:27:20.000000000 -0700
+++ fwlogwatch-1.4/debian/tests/control 2021-04-23 21:10:36.000000000 -0700
@@ -1 +1,3 @@
-Test-Command: fwlogwatch -V | grep -q "Zlib support enabled"
+Test-Command: /usr/sbin/fwlogwatch -V | grep -q "Zlib support enabled"
+Depends: @
+Restrictions: superficial
signature.asc
Description: PGP signature
