Bug#989140: roundcube-core: Error displayed during upgrade if manually installed plugins are in use in /var/lib/roundcube

2021-05-26 Thread Guilhem Moulin
On Wed, 26 May 2021 at 13:25:21 -0300, Kurt Fitzner wrote:
> During an upgrade of roundcube-core, if there are any manually installed
> plugins in /var, then an error is shown:

Thanks for the report!

> It may be a disply-only error with no actual ramifications. 

AFAICT that's correct, load_plugin() aborts but that only stops
initialization of the missing plugin, bin/update.sh continues with other
plugins and other configuration update steps, and the original array is
preserved on upgrades.

> That being said, the assumption of a reverse correlation shouldn't be made.

Indeed ;-)

-- 
Guilhem.


signature.asc
Description: PGP signature


Bug#989140: roundcube-core: Error displayed during upgrade if manually installed plugins are in use in /var/lib/roundcube

2021-05-26 Thread Kurt Fitzner
Package: roundcube
Version: 1.4.11+dfsg.1-4
Severity: minor

During an upgrade of roundcube-core, if there are any manually installed
plugins in /var, then an error is shown:

Setting up roundcube-mysql (1.4.11+dfsg.1-4) ...
Setting up libx11-xcb1:amd64 (2:1.7.1-1) ...
Setting up roundcube-core (1.4.11+dfsg.1-4) ...
Determining localhost credentials from /etc/mysql/debian.cnf: succeeded.
dbconfig-common: writing config to /etc/dbconfig-common/roundcube.conf
dbconfig-common: flushing administrative password
ERROR: Failed to load plugin file 
/usr/share/roundcube/plugins/show_gravatar/show_gravatar.php
Setting up roundcube-plugins (1.4.11+dfsg.1-4) ...
Setting up roundcube (1.4.11+dfsg.1-4) ...
Processing triggers for libc-bin (2.31-12) ...
Processing triggers for man-db (2.9.4-2) ...


Something is either looking at the roundcube configuration, or iterating
through all the plugins in /var/lib/roundcube/plugins and wanting to
associate them with the package-supplied plugins which are in
/usr/lib/roundcube/plugins.  However, only plugins supplied by the package
/should rightfully exist in /usr/lib/roundcube/plugins.

The script can assume that all plugins in /usr/lib/roundcube/plugins/* exist
as a link to /var/lib/roundcube/plugins/*, but the reverse cannot be
assumed.

Why the upgrade script for roundcube-core was looking at the plugins, and
why it made the assumption that the /var plugins must also all exist in /usr
is unknown.  It may be a disply-only error with no actual ramifications. 
That being said, the assumption of a reverse correlation shouldn't be made.



-- System Information:
Debian Release: 11.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-6-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages roundcube-core depends on:
ii  dbconfig-common 2.0.19
ii  debconf [debconf-2.0]   1.5.75
ii  dpkg1.20.9
ii  libjs-bootstrap44.5.2+dfsg1-6
ii  libjs-codemirror5.59.2+~cs0.23.109-1
ii  libjs-jquery3.5.1+dfsg+~3.5.5-7
ii  libjs-jquery-minicolors 2.2.6+dfsg-4
ii  libjs-jquery-ui 1.12.1+dfsg-8
ii  libjs-jstimezonedetect  1.0.6-5
ii  libmagic1   1:5.39-3
ii  php 2:7.4+76
ii  php-auth-sasl   1.1.0-1
ii  php-cli 2:7.4+76
ii  php-common  2:76
ii  php-intl2:7.4+76
ii  php-mail-mime   1.10.10-1
ii  php-masterminds-html5   2.7.4+dfsg-2
ii  php-mbstring2:7.4+76
ii  php-net-sieve   1.4.4-2
ii  php-net-smtp1.9.0-1
ii  php-net-socket  1.2.2-2
ii  php-pear1:1.10.12+submodules+notgz+20210212-1
ii  php7.4 [php]7.4.15-5+deb11u1
ii  php7.4-cli [php-cli]7.4.15-5+deb11u1
ii  php7.4-intl [php-intl]  7.4.15-5+deb11u1
ii  php7.4-json [php-json]  7.4.15-5+deb11u1
ii  php7.4-mbstring [php-mbstring]  7.4.15-5+deb11u1
ii  roundcube-mysql 1.4.11+dfsg.1-4
ii  ucf 3.0043

Versions of packages roundcube-core recommends:
ii  lighttpd [httpd-cgi]1.4.59-1
ii  php-fpm 2:7.4+76
ii  php-gd  2:7.4+76
ii  php-pspell  2:7.4+76
ii  php7.4-fpm [php-fpm]7.4.15-5+deb11u1
ii  php7.4-gd [php-gd]  7.4.15-5+deb11u1
ii  php7.4-pspell [php-pspell]  7.4.15-5+deb11u1
ii  spawn-fcgi  1.6.4-2

Versions of packages roundcube-core suggests:
pn  php-crypt-gpg 
pn  php-mkopinsky-zxcvbn-php  
pn  php-net-ldap3 
ii  roundcube-plugins 1.4.11+dfsg.1-4

Versions of packages roundcube depends on:
ii  dpkg  1.20.9

-- Configuration Files:
/etc/roundcube/lighttpd.conf changed [not included]

-- debconf information excluded