Bug#989450: bdebstrap: Unconditionally passes verbose "-v" option to mmdebstrap
On 2021-06-04, Benjamin Drung wrote: > Am Freitag, den 04.06.2021, 10:55 -0700 schrieb Vagrant Cascadian: >> On 2021-06-04, Benjamin Drung wrote: >> > On Thu, 03 Jun 2021 16:01:46 -0700 Vagrant Cascadian >> > wrote: >> > > While I can see value in increased verbosity in some situations, it >> > > would be nice to be able to get mmdebstrap's simple and minimal progress >> > > bar output while still using bdebstrap for the configuration and other >> > > features it provides. >> > > >> > > Simply removing the "-v" argument in /usr/bin/bdebstrap appears to work >> > > fine, though obviously people who want the increased verbosity will need >> > > to add it back somehow. >> > >> > I thought about it. bdebstrap produces some log messages as well. Do >> > you want to tweak the verbosity of mmdebstrap and bdebstrap separately? >> > >> > One simple change would be to couple the verbosity of bdebstrap and >> > mmdebstrap: >> > >> > * normal mode: uses info level and pass -v to mmdebstrap >> > * --debug: uses debug level and pass -v to mmdebstrap >> > * --quiet: use warning level and don't pass -v to mmdebstrap >> > >> > I have implemented that in the quiet branch for testing it: >> > https://github.com/bdrung/bdebstrap/tree/quiet >> > >> > What do you think? >> >> Works for me! >> >> The only thing is I'm not sure if someone *might* want a --silent >> option, but that's not currently me. :) > > --silent as alias for --quiet? Oh dear, I didn't realize that --silent and --quiet in mmdebstrap are the same thing... > I just had a look at the man page of mmdebstrap. It has a > --quiet/--silent option as well. Is it better to align the log level of > bdebstrap with mmdebstrap? So add the same option to bdebstrap than > mmdebstrap and just pass it down? There is a lot to say for mirroring what mmdebstrap does by just passing --verbose, --silent, --quiet, --debug down, though that does mean bdebstrap would have to change default behavior. Mostly, I prefer the default verbosity of mmdebstrap and was mildly surprised that bdebstrap hard-coded a higher level of verbosity for mmdebstrap. As long as there's some reasonable way to get mmdebstrap's default verbosity level when using bdebstrap, I'm not particularly opinionated in how it is implemented. :) live well, vagrant signature.asc Description: PGP signature
Bug#989450: bdebstrap: Unconditionally passes verbose "-v" option to mmdebstrap
Am Freitag, den 04.06.2021, 10:55 -0700 schrieb Vagrant Cascadian: > On 2021-06-04, Benjamin Drung wrote: > > On Thu, 03 Jun 2021 16:01:46 -0700 Vagrant Cascadian > > wrote: > > > While I can see value in increased verbosity in some situations, it > > > would be nice to be able to get mmdebstrap's simple and minimal progress > > > bar output while still using bdebstrap for the configuration and other > > > features it provides. > > > > > > Simply removing the "-v" argument in /usr/bin/bdebstrap appears to work > > > fine, though obviously people who want the increased verbosity will need > > > to add it back somehow. > > > > I thought about it. bdebstrap produces some log messages as well. Do > > you want to tweak the verbosity of mmdebstrap and bdebstrap separately? > > > > One simple change would be to couple the verbosity of bdebstrap and > > mmdebstrap: > > > > * normal mode: uses info level and pass -v to mmdebstrap > > * --debug: uses debug level and pass -v to mmdebstrap > > * --quiet: use warning level and don't pass -v to mmdebstrap > > > > I have implemented that in the quiet branch for testing it: > > https://github.com/bdrung/bdebstrap/tree/quiet > > > > What do you think? > > Works for me! > > The only thing is I'm not sure if someone *might* want a --silent > option, but that's not currently me. :) --silent as alias for --quiet? I just had a look at the man page of mmdebstrap. It has a --quiet/--silent option as well. Is it better to align the log level of bdebstrap with mmdebstrap? So add the same option to bdebstrap than mmdebstrap and just pass it down? -- Benjamin Drung Debian & Ubuntu Developer
Bug#989450: bdebstrap: Unconditionally passes verbose "-v" option to mmdebstrap
On 2021-06-04, Benjamin Drung wrote: > On Thu, 03 Jun 2021 16:01:46 -0700 Vagrant Cascadian > wrote: >> While I can see value in increased verbosity in some situations, it >> would be nice to be able to get mmdebstrap's simple and minimal progress >> bar output while still using bdebstrap for the configuration and other >> features it provides. >> >> Simply removing the "-v" argument in /usr/bin/bdebstrap appears to work >> fine, though obviously people who want the increased verbosity will need >> to add it back somehow. > > I thought about it. bdebstrap produces some log messages as well. Do > you want to tweak the verbosity of mmdebstrap and bdebstrap separately? > > One simple change would be to couple the verbosity of bdebstrap and > mmdebstrap: > > * normal mode: uses info level and pass -v to mmdebstrap > * --debug: uses debug level and pass -v to mmdebstrap > * --quiet: use warning level and don't pass -v to mmdebstrap > > I have implemented that in the quiet branch for testing it: > https://github.com/bdrung/bdebstrap/tree/quiet > > What do you think? Works for me! The only thing is I'm not sure if someone *might* want a --silent option, but that's not currently me. :) live well, vagrant signature.asc Description: PGP signature
Bug#989450: bdebstrap: Unconditionally passes verbose "-v" option to mmdebstrap
Hi Vagrant, On Thu, 03 Jun 2021 16:01:46 -0700 Vagrant Cascadian wrote: > bdebstrap is a nice way to pass complicated commands to mmdebstrap, > thanks! Thanks. It's nice to see that someone else is using bdebstrap (or at least trying to use it). > There appears to be no way to disable the "-v" argument passed to > mmdebstrap. The reason is trivial: Because it was my preference to have the verbose mode and because we often build the images using a CI pipeline (where you want to have verbose logs). So initial there were no need for dropping it. > While I can see value in increased verbosity in some situations, it > would be nice to be able to get mmdebstrap's simple and minimal progress > bar output while still using bdebstrap for the configuration and other > features it provides. > > Simply removing the "-v" argument in /usr/bin/bdebstrap appears to work > fine, though obviously people who want the increased verbosity will need > to add it back somehow. I thought about it. bdebstrap produces some log messages as well. Do you want to tweak the verbosity of mmdebstrap and bdebstrap separately? One simple change would be to couple the verbosity of bdebstrap and mmdebstrap: * normal mode: uses info level and pass -v to mmdebstrap * --debug: uses debug level and pass -v to mmdebstrap * --quiet: use warning level and don't pass -v to mmdebstrap I have implemented that in the quiet branch for testing it: https://github.com/bdrung/bdebstrap/tree/quiet What do you think? -- Benjamin Drung Senior DevOps Engineer and Debian & Ubuntu Developer Compute Platform Operations 1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Deutschland E-Mail: benjamin.dr...@ionos.com | Web: www.ionos.de Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498 Vorstand: Hüseyin Dogan, Dr. Martin Endreß, Claudia Frese, Henning Kettler, Arthur Mai, Matthias Steinberg, Achim Weiß Aufsichtsratsvorsitzender: Markus Kadelke Member of United Internet
Bug#989450: bdebstrap: Unconditionally passes verbose "-v" option to mmdebstrap
Package: bdebstrap Version: 0.1.1-1 Severity: wishlist X-Debbugs-Cc: Vagrant Cascadian bdebstrap is a nice way to pass complicated commands to mmdebstrap, thanks! There appears to be no way to disable the "-v" argument passed to mmdebstrap. While I can see value in increased verbosity in some situations, it would be nice to be able to get mmdebstrap's simple and minimal progress bar output while still using bdebstrap for the configuration and other features it provides. Simply removing the "-v" argument in /usr/bin/bdebstrap appears to work fine, though obviously people who want the increased verbosity will need to add it back somehow. Thanks! live well, vagrant signature.asc Description: PGP signature
