Bug#990456: Processed: Bug#990456 marked as pending in openssh

[Martin]

On 2021-07-04 10:21, Colin Watson wrote:
> On Sun, Jul 04, 2021 at 08:17:59AM +, Martin wrote:
>> No harm done by `update_ssh_group_name()`, but maybe I would use
>> `if ! getent group _ssh >/dev/null; then` instead of
>> `if getent group ssh >/dev/null; then` just for the aesthetics (and to
>> prevent postinst failure, in case both `ssh` and `_ssh` already exist).
>
> The version check should deal with most of this in practice, but I've
> added a check for _ssh in addition (rather than "instead").

Even better, thank you!

Bug#990456: Processed: Bug#990456 marked as pending in openssh

[Colin Watson]

On Sun, Jul 04, 2021 at 08:17:59AM +, Martin wrote:
> Thanks for solving this so quickly, Colin!
> 
> But doesn't need the `addgroup --system --quiet` also `--force-badname`,
> if the group name starts with an underscore?

Yes, a CI job pointed that out as well - fixed.

> No harm done by `update_ssh_group_name()`, but maybe I would use
> `if ! getent group _ssh >/dev/null; then` instead of
> `if getent group ssh >/dev/null; then` just for the aesthetics (and to
> prevent postinst failure, in case both `ssh` and `_ssh` already exist).

The version check should deal with most of this in practice, but I've
added a check for _ssh in addition (rather than "instead").

Thanks,

-- 
Colin Watson (he/him)  [cjwat...@debian.org]

Bug#990456: Processed: Bug#990456 marked as pending in openssh

[Martin]

Thanks for solving this so quickly, Colin!

But doesn't need the `addgroup --system --quiet` also `--force-badname`,
if the group name starts with an underscore?

No harm done by `update_ssh_group_name()`, but maybe I would use
`if ! getent group _ssh >/dev/null; then` instead of
`if getent group ssh >/dev/null; then` just for the aesthetics (and to
prevent postinst failure, in case both `ssh` and `_ssh` already exist).