On Sun, Jul 4, 2021 at 9:46 PM Sebastian Ramacher wrote:
>
> Control: tags -1 moreinfo
>
> On 2021-07-02 07:37:22 +0200, Christian Ehrhardt wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian@packages.debian.org
> > Usertags: unblock
> >
> > Hi,
> > please unblock mdevctl 0.81-1.
> >
> > It fixes a problem with an allowed combined usage two parameters.
> > v0.78 -> 0.81 sounds a lot, but that is due to the way upstream creates
> > versions which essentially is a counter of git commits.
> > Therefore the only real change is [1] which should be ok for the freeze
> > time.
> >
> > There are two packaging-only changes which I had in git but not
> > uploaded yes (as they didn't qualify for an upload without any fix.
> > But both are no-impact changes (compat level while the package has not much
> > that is affected by it and the drop of the unused d/source/local-options.
> >
> > The builds all LGTM, see [2]. I have installed the new build and it works
> > as expected:
> >
> > Before
> > # mdevctl define -p 0.0.0033 --jsonfile mdev_nodedev.json
> > /usr/sbin/mdevctl: line 183:
> > /etc/mdevctl.d/0.0.0033/eea1c8dc-ce6d-42dd-bd26-02e3b707ff95: No such
> > file or directory
> > After
> > # mdevctl define -p 0.0.0033 --jsonfile mdev_nodedev.json
> > 83123a52-3147-44d1-9154-1175e266804e
> >
> > The package has no autopkgtests as they would be superficial and not much
> > worth or would need mdev splittable GPUs or such on the test systems which
> > we
> > can not assume/expect to have. Therefore I need to ask you via this ubblock
> > request. I hope that this is sufficient to unblock, if you need anything
> > else please let me know.
> >
> > [1]: https://github.com/mdevctl/mdevctl/commit/e6cf620b4b04c6
> > [2]:
> > https://buildd.debian.org/status/fetch.php?pkg=mdevctl&arch=all&ver=0.78-1&stamp=1606290427
Hi Sebastian,
I missed your question before today, so sorry for the delay in clarifying this.
> Please attach a debdiff between the version in testing and unstable.
Attached is the debdiff "mdevctl-to-0.81.debdiff" as requested.
> Regarding the packaging changes: it's too late to bump debhelper compat.
> See https://release.debian.org/bullseye/freeze_policy.html. Please
> revert that change (or show that the change does not cause any
> differences in the produced binary packages).
Furthermore in regard to compat I have extracted the full content and
control of 0.78 and 0.81 locally (with dpkd -x and -e out of the debs
in the archive).
You can see in the attached "effective-changes.diff" that the only
changes are only:
- version number
- wanted fix in lsmdev (link to mdevctl, so it is the same change in two places)
- wanted fix in mdevctl
- changelog binary
AFAICS there are no unexpected changes built into the binaries or the maintainer
scripts.
> Cheers
> --
> Sebastian Ramacher
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
diff -Naur 0.78/content/usr/sbin/lsmdev 0.81/content/usr/sbin/lsmdev
--- 0.78/content/usr/sbin/lsmdev 2020-11-25 07:02:19.0 +
+++ 0.81/content/usr/sbin/lsmdev 2021-07-01 14:07:15.0 +
@@ -3,7 +3,7 @@
persist_base=/etc/mdevctl.d
mdev_base=/sys/bus/mdev/devices
parent_base=/sys/class/mdev_bus
-version="0.78"
+version="0.81"
# Alias 'lsmdev' to 'mdevctl list'
if [ $(basename $0) == "lsmdev" ]; then
@@ -609,6 +609,7 @@
exit 1
fi
+mkdir -p "$persist_base/$parent"
write_config "$persist_base/$parent/$uuid"
if [ $? -ne 0 ]; then
exit 1
diff -Naur 0.78/content/usr/sbin/mdevctl 0.81/content/usr/sbin/mdevctl
--- 0.78/content/usr/sbin/mdevctl 2020-11-25 07:02:19.0 +
+++ 0.81/content/usr/sbin/mdevctl 2021-07-01 14:07:15.0 +
@@ -3,7 +3,7 @@
persist_base=/etc/mdevctl.d
mdev_base=/sys/bus/mdev/devices
parent_base=/sys/class/mdev_bus
-version="0.78"
+version="0.81"
# Alias 'lsmdev' to 'mdevctl list'
if [ $(basename $0) == "lsmdev" ]; then
@@ -609,6 +609,7 @@
exit 1
fi
+mkdir -p "$persist_base/$parent"
write_config "$persist_base/$parent/$uuid"
if [ $? -ne 0 ]; then
exit 1
diff -Naur 0.78/content/usr/share/doc/mdevctl/changelog.Debian.gz 0.81/content/usr/share/doc/mdevctl/changelog.Debian.gz
--- 0.78/content/usr/share/doc/mdevctl/changelog.Debian.gz 2020-11-25 07:02:19.0 +
+++ 0.81/content/usr/share/doc/mdevctl/changelog.Debian.gz 2021-07-01 14:07:15.0 +
@@ -1,2 +1,3 @@
- ? ??M??0???#q??I?4???b?\X??Z??l?e??L??H?ri?D?L???W??
-w2xY??E?^Agck?o? [???]?Jw?hp???J]? Tp ??O7f^?&???
X??5j?!%v?HgSp???k=?U"?; Q; ?A??9? ??l??b$.T?~> ?-=??& ???? ?gQm?c???V???H?f?7A?Ds??&4D???<?s???Mg??90??????M?g?Zaig?8?fSY+?d*??1^?x5????l?q?? ???9?XVu9-?;y?^?G??[??Z?I??7"!??` ?k+ ??h6,c?k??3^V?? ???
\ No newline at end of f
