Bug#991099: gem2deb should Provides: dh-sequence-ruby

2021-07-22 Thread Antonio Terceiro
Hi,

On Wed, Jul 14, 2021 at 07:46:09AM +0200, Helmut Grohne wrote:
> Package: gem2deb
> Version: 1.4
> Tags: patch
> 
> Traditionally, packages could enable debhelper addons using
> --with=ADDON. That's what works today and is most commonly used.
> Recently, debhelper added another way of doing so. If one declares a
> build dependency on dh-sequence-ADDON, the addon is automatically
> enabled. This is beneficial for two major reason:
>  * Don't repeat yourself. There no longer is a need to issue both
>"Build-Depends: gem2deb" and "dh --with=ruby". A single
>"Build-Depends: dh-sequence-ruby" takes care of both.
>  * We can declaratively conditionalize Build-Depends. The most obvious
>one is e.g. "Build-Depends-Indep: dh-sequence-ruby". Conditionally
>enabling an addon in debian/rules has been quite annoying thus far
>and the declarative method makes it simple. Build profiles are also
>supported, so "Build-Depends: dh-sequence-ruby " does the
>right thing.
> 
> As such, please consider applying the attached patch. I think that this
> is really harmless, so if there is any chance of getting this into
> bullseye, please do it. Otherwise, it'll have to be added to
> bullseye-backports in order to support packages in bookworm that start
> relying on it. I do see that this comes quiet late, so I don't expect
> miracles.

Thanks.

I applied your patch but I don't intend to upload any non-bugfix update
to gem2deb this late into the freeze.


signature.asc
Description: PGP signature


Bug#991099: gem2deb should Provides: dh-sequence-ruby

2021-07-14 Thread Helmut Grohne
Package: gem2deb
Version: 1.4
Tags: patch

Traditionally, packages could enable debhelper addons using
--with=ADDON. That's what works today and is most commonly used.
Recently, debhelper added another way of doing so. If one declares a
build dependency on dh-sequence-ADDON, the addon is automatically
enabled. This is beneficial for two major reason:
 * Don't repeat yourself. There no longer is a need to issue both
   "Build-Depends: gem2deb" and "dh --with=ruby". A single
   "Build-Depends: dh-sequence-ruby" takes care of both.
 * We can declaratively conditionalize Build-Depends. The most obvious
   one is e.g. "Build-Depends-Indep: dh-sequence-ruby". Conditionally
   enabling an addon in debian/rules has been quite annoying thus far
   and the declarative method makes it simple. Build profiles are also
   supported, so "Build-Depends: dh-sequence-ruby " does the
   right thing.

As such, please consider applying the attached patch. I think that this
is really harmless, so if there is any chance of getting this into
bullseye, please do it. Otherwise, it'll have to be added to
bullseye-backports in order to support packages in bookworm that start
relying on it. I do see that this comes quiet late, so I don't expect
miracles.

Helmut
diff --minimal -Nru gem2deb-1.4/debian/changelog 
gem2deb-1.4+nmu1/debian/changelog
--- gem2deb-1.4/debian/changelog2020-10-30 15:46:14.0 +0100
+++ gem2deb-1.4+nmu1/debian/changelog   2021-07-14 06:23:42.0 +0200
@@ -1,3 +1,10 @@
+gem2deb (1.4+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Provide dh-sequence-ruby from gem2deb. (Closes: #-1)
+
+ -- Helmut Grohne   Wed, 14 Jul 2021 06:23:42 +0200
+
 gem2deb (1.4) unstable; urgency=medium
 
   [ Helmut Grohne ]
diff --minimal -Nru gem2deb-1.4/debian/control gem2deb-1.4+nmu1/debian/control
--- gem2deb-1.4/debian/control  2020-10-30 15:45:41.0 +0100
+++ gem2deb-1.4+nmu1/debian/control 2021-07-14 06:23:39.0 +0200
@@ -42,6 +42,7 @@
 python3-debian
 Suggests: git-buildpackage,
   pristine-tar
+Provides: dh-sequence-ruby
 Description: Debian Ruby packaging suite
  gem2deb is a set of tools to create Debian package from ruby software
  distributed with Rubygems. gem2tgz converts the .gem file to a tar archive,