Bug#991223: modemmanager: missing policykit-1 in Depends or Recommends

[Cyril Brulebois]

Control: tag -1 pending

Cyril Brulebois  (2021-07-18):
> It's arguably worse in bullseye, during installation:
> 
> # apt install modemmanager
> […]
> Created symlink 
> /etc/systemd/system/dbus-org.freedesktop.ModemManager1.service → 
> /lib/systemd/system/ModemManager.service.
> Created symlink 
> /etc/systemd/system/multi-user.target.wants/ModemManager.service → 
> /lib/systemd/system/ModemManager.service.
> Failed to start ModemManager.service: Unit polkit.service not found.
> […]
> 
> which means we don't even get the daemon up and running:
> 
> # systemctl status ModemManager.service
> ● ModemManager.service - Modem Manager
>  Loaded: loaded (/lib/systemd/system/ModemManager.service; enabled; 
> vendor preset: enabled)
>  Active: inactive (dead)
> 
> and again, pulling the same package would help, given it ships:
> 
> policykit-1: /lib/systemd/system/polkit.service

I'm attaching the source debdiff I'm getting ready to upload to
unstable; maybe it'll be unblocked in time for 11.0 (it's been such a
long-standing issue that it could wait until 11.1 but hopefully there's
still some time for 11.0).

I'd be pushing this to a new sid branch, since master is used for
experimental at the moment.

Happy to get an ACK, but I won't wait too long. :)


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant
diff -Nru modemmanager-1.14.12/debian/changelog modemmanager-1.14.12/debian/changelog
--- modemmanager-1.14.12/debian/changelog	2021-03-12 19:09:44.0 +0100
+++ modemmanager-1.14.12/debian/changelog	2021-07-23 06:31:17.0 +0200
@@ -1,3 +1,15 @@
+modemmanager (1.14.12-0.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix missing dependency on policykit-1 (Closes: #991223): without
+it, a lot of operations would result in a D-Bus level “The name
+org.freedesktop.PolicyKit1 was not provided by any .service files”
+error. In bullseye, ModemManager.service wouldn't even start due to
+the missing polkit.service dependency at the systemd level.
+  * Adjust gbp configuration for sid uploads.
+
+ -- Cyril Brulebois   Fri, 23 Jul 2021 06:31:17 +0200
+
 modemmanager (1.14.12-0.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru modemmanager-1.14.12/debian/control modemmanager-1.14.12/debian/control
--- modemmanager-1.14.12/debian/control	2021-03-12 19:09:31.0 +0100
+++ modemmanager-1.14.12/debian/control	2021-07-23 06:27:27.0 +0200
@@ -29,6 +29,7 @@
 Architecture: linux-any
 Depends: ${shlibs:Depends},
  ${misc:Depends},
+ policykit-1,
 Recommends: usb-modeswitch
 Description: D-Bus service for managing modems
  ModemManager is a DBus-activated daemon which controls mobile broadband
diff -Nru modemmanager-1.14.12/debian/gbp.conf modemmanager-1.14.12/debian/gbp.conf
--- modemmanager-1.14.12/debian/gbp.conf	2021-03-12 19:09:31.0 +0100
+++ modemmanager-1.14.12/debian/gbp.conf	2021-07-23 06:30:51.0 +0200
@@ -1,3 +1,3 @@
 [DEFAULT]
 pristine-tar = True
-debian-branch = master
+debian-branch = sid


signature.asc
Description: PGP signature

Bug#991223: modemmanager: missing policykit-1 in Depends or Recommends

[Cyril Brulebois]

Control: found -1 1.14.12-0.1

Cyril Brulebois  (2021-07-18):
> I've double checked those findings with buster myself, but I'm told
> the same happens with bullseye as well, which would be consistent with
> the facts Depends/Recommends didn't change between buster's version
> and bullseye's.

It's arguably worse in bullseye, during installation:

# apt install modemmanager
[…]
Created symlink 
/etc/systemd/system/dbus-org.freedesktop.ModemManager1.service → 
/lib/systemd/system/ModemManager.service.
Created symlink 
/etc/systemd/system/multi-user.target.wants/ModemManager.service → 
/lib/systemd/system/ModemManager.service.
Failed to start ModemManager.service: Unit polkit.service not found.
[…]

which means we don't even get the daemon up and running:

# systemctl status ModemManager.service
● ModemManager.service - Modem Manager
 Loaded: loaded (/lib/systemd/system/ModemManager.service; enabled; 
vendor preset: enabled)
 Active: inactive (dead)

and again, pulling the same package would help, given it ships:

policykit-1: /lib/systemd/system/polkit.service


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#991223: modemmanager: missing policykit-1 in Depends or Recommends

[Cyril Brulebois]

Package: modemmanager
Version: 1.10.0-1
Severity: serious
Justification: missing dependency

Hi,

A basic modemmanager installation doesn't result in a functional mmcli
command. The following might work (e.g. after a reboot, to make sure the
modem detection is fine):

# mmcli -L
/org/freedesktop/ModemManager1/Modem/0 [QUALCOMM INCORPORATED] QUECTEL 
Mobile Broadband Module

But trying to force a scan (e.g. before or instead of rebooting)
doesn't:

# mmcli -S
error: couldn't request to scan devices: 
'GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Failed: PolicyKit 
authorization failed: 'GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: 
The name org.freedesktop.PolicyKit1 was not provided by any .service files''

Trying to establish a connection doesn't work either:

# mmcli -m 0 --simple-connect apn=orange
error: couldn't connect the modem: 
'GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Failed: PolicyKit 
authorization failed: 'GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: 
The name org.freedesktop.PolicyKit1 was not provided by any .service files''

Given the error message, it's pretty clear the problem is at the D-Bus
level, so isn't actually limited to mmcli: trying to toy with the modem
over D-Bus directly (e.g. using Python bindings) would result in the
same problems.


It looks to me policykit-1 should be at least in Recommends, possibly in
Depends. This might have been unreported until since end users are
likely using NetworkManager from a desktop environment, and
network-manager does list policykit-1 in Depends.


I've double checked those findings with buster myself, but I'm told the
same happens with bullseye as well, which would be consistent with the
facts Depends/Recommends didn't change between buster's version and
bullseye's.

This would seem worth fixing in both distributions.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant