Bug#991392: flameshot: Don't "phone home" for updates by default

[Chris Lamb]

Source: flameshot
Version: 0.9.0+ds1-1
Severity: important
Tags: patch

Hi,

By default, flameshot "calls home" every 24 hours via the GitHub API
to check for new versions. This is not quite in the Debian tradition
and doesn't present the best UI/UX experience given the presence of
APT repos.

I have attached a patch to change the default setting for this
configuration option. Users who wish to enable the behaviour
post-installation may do so, but this patch renders this opt-in.


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-

diff --git a/src/utils/confighandler.cpp b/src/utils/confighandler.cpp
index 6786225..b63237f 100644
--- a/src/utils/confighandler.cpp
+++ b/src/utils/confighandler.cpp
@@ -298,7 +298,7 @@ void ConfigHandler::setKeepOpenAppLauncher(const bool 
keepOpen)
 
 bool ConfigHandler::checkForUpdates()
 {
-    bool res = true;
+    bool res = false;
     if (m_settings.contains(QStringLiteral("checkForUpdates"))) {
         res = m_settings.value(QStringLiteral("checkForUpdates")).toBool();
     }