Bug#992341: Acknowledgement (bird2: does not properly take over /etc/bird/bird.conf)

2023-08-07 Thread Jakub Ružička
Hello,

I'm the new bird2 maintainer and I'm happy to help with this.


On 23-08-04 11:08, Jonathan Wiltshire wrote:
> Control: retitle -1 bird2: does not properly take over from bird package
> Control: severity -1 serious

This results in

Version 2.0.12-7 of bird2 is marked for autoremoval from testing on Sat 19 Aug 
2023.

I think this help noone.

If any of the two packages should be dropped from testing, it's bird as it's
nearing upstream EOL at the end of 2023.


> Control: affects -1 + src:bird
> 
> Hi,
> 
> I have just run into this again on the upgrade from bullseye to bookworm.

bullseye contains bird_1.6.8-2.1 which is the same as bookworm,
so I tested on bookworm as it should be equivalent.


> In fact it's worse than just the config files now: bird in its postrm does
> things like disabling and masking the systemd units bird2 uses, and attempts
> to remove the 'bird' user.

I'm unable to reproduce the error on purge after upgrade on my machine, in VM,
or in a container:

$ apt install bird
Setting up bird (1.6.8-2.1+b1) ...

$ apt install bird2
Removing bird (1.6.8-2.1+b1) ...
Setting up bird2 (2.0.12-7) ...

$ apt purge bird
Purging configuration files for bird (1.6.8-2.1+b1) ...

$ grep bird /etc/passwd
bird:x:105:110::/run/bird:/usr/sbin/nologin

$ ls /etc/bird
bird.conf
envvars

$ ls /run/bird
bird.ctl
   
$ systemctl status bird
● bird.service - BIRD Internet Routing Daemon
Loaded: loaded (/lib/systemd/system/bird.service; disabled; preset: 
enabled)
Active: active (running) since Mon 2023-08-07 12:29:43 UTC; 3min 45s ago


On further investigation, the collision you describe is fixed by a patch
included in bird_1.6.7-1 (2019):

https://salsa.debian.org/debian/bird/-/commit/7738791be2

It checks for the ownership of /etc/bird/bird.conf using ucf and only performs
actual purging (including the removal of bird user) when it should.


> disabling and masking the systemd units bird2 uses

I don't see such thing happening in current bird/bird2 package sources:

https://salsa.debian.org/debian/bird/-/blob/master/debian/bird.postrm


The problems you describe imply upgrading from older bird package than 1.6.7,
for example buster 1.6.6-1 but that that's old-old-stable now.

This seems fixed both in bookworm and bullseye. IOW upgrading from a fully
upgraded bullseye system bird_1.6.8 to bookworm bird2_2.0.12 seems to work.

Are you sure you upgraded from latest bullseye bird package?

If so, I'm afraid you might be a victim of a fallout from previous package
versions.


> Please work together to make these two packages cooperate better.

They cooperated just fine in my testing with current bullseye/bookworm
versions and the above-described patch seems to have addressed exactly this 
issue.

Please provide a reproducer with current (bookworm/bullseye) packages,
otherwise I think this was fixed in bird_1.6.7-1.


Cheers,
Jakub Ružička


signature.asc
Description: PGP signature


Bug#992341: Acknowledgement (bird2: does not properly take over /etc/bird/bird.conf)

2023-08-04 Thread Jonathan Wiltshire

Control: retitle -1 bird2: does not properly take over from bird package
Control: severity -1 serious
Control: affects -1 + src:bird

Hi,

I have just run into this again on the upgrade from bullseye to bookworm.

In fact it's worse than just the config files now: bird in its postrm 
does things like disabling and masking the systemd units bird2 uses, and 
attempts to remove the 'bird' user.


Please work together to make these two packages cooperate better.

Thanks,

--
Jonathan Wiltshire MBCS
Operations Manager

Tiger Computing Ltd
ISO27001:2017 Certified

Tel: 01600 483 484
Web: http://www.tiger-computing.co.uk

Registered in England. Company number: 3389961
Registered address: Woodlands, Staunton,
 Coleford, GL16 8NU