Bug#992842: Slow stop due to killproc in /etc/init.d/nagios4

2024-04-01 Thread Imanol-Mikel Barba Sabariego
This is still happening with 4.4.6-4 in Debian bookworm

I used $DAEMON instead of $NAME to be consistent with the invocation in the 
reload function.

Besides slow restarts, this also breaks persistent data in Nagios, as it 
either saves that data on shutdown (which it does not a chance to do since it 
ends up SIGKILL'd after the start-stop-daemon call fails due to missing name), 
or every X minutes. The only workaround to the persistent data is to ask 
nagios to save it every minute, which is not great.

Is there any blocker to deploying this patch or did this somehow regress?

Thanks!



Bug#992842: Slow stop due to killproc in /etc/init.d/nagios4

2021-09-21 Thread Andrei POPESCU
Control: reassign -1 nagios4-common 4.3.4-3

On Ma, 24 aug 21, 09:18:31, Benoit DOLEZ wrote:
> Package: nagios4-common Version: 4.3.4-3

Fixing affected package(s) and version due to mangled line breaks.

Kind regards,
Andrei
-- 
Looking after bugs assigned to unknown or inexistent packages


signature.asc
Description: PGP signature


Bug#992842: Slow stop due to killproc in /etc/init.d/nagios4

2021-08-24 Thread Benoit DOLEZ
Package: nagios4-common Version: 4.3.4-3
Hi,

I have problem with nagios4 on debian 10.9 than is very slow to stop (and 
restart).

# date ; systemctl stop nagios4 ; date
Tue Aug 24 09:13:04 CEST 2021
Tue Aug 24 09:13:19 CEST 2021
# 

=> 15 seconds 

After debug, I think I have found an error in the call to "killproc" than need 
progname as parameter to work.

--- /etc/init.d/nagios4.orig    2021-08-18 01:59:17.172227277 +0200
+++ /etc/init.d/nagios4    2021-08-18 01:58:27.017586384 +0200
@@ -146,7 +146,7 @@
 }
 
 stop () {
-    killproc -p $THEPIDFILE
+    killproc -p $THEPIDFILE $NAME
 ret=$?
 if [ `pidof nagios4 | wc -l ` -gt 0 ]; then
 echo -n "Waiting for $NAME daemon to die.."


Regards

Benoit

-- Benoit DOLEZ, e-mail: bdo...@zenetys.com