Bug#993115: [Pkg-utopia-maintainers] Bug#993115: firewalld: missing test dependencies

2021-08-27 Thread Michael Biebl

Control: tags -1 + moreinfo

Am 27.08.21 um 15:46 schrieb Gianfranco Costamagna:

Source: firewalld
Version: 1.0.1-1
Severity: serious
tags: patch

Hello, looks some tests needs nftables and ipset installed inside the chroot

the following patch makes them pass all.

diff -Nru firewalld-1.0.1/debian/tests/control 
firewalld-1.0.1/debian/tests/control
--- firewalld-1.0.1/debian/tests/control2021-08-17 23:25:15.0 
+0200
+++ firewalld-1.0.1/debian/tests/control2021-08-27 15:16:04.0 
+0200
@@ -3,6 +3,7 @@
   ipset,
   libglib2.0-bin,
   libxml2-utils,
+ nftables,
  Restrictions: needs-root, isolation-machine
  
  Tests: integration-tests

@@ -10,6 +11,8 @@
   network-manager,
   sudo,
   policykit-1,
+ nftables,
+ ipset
  Restrictions: needs-root, isolation-machine
  
  Tests: smoke



I know Debian infrastructure doesn't support isolation-machine (yet), so I'm not
totally confident about the severity of this bug, but since its trivial to fix, 
better
fix it and leave autopkgtests to user working.


I did run the autopkgtest suite before uploading (log attached), so I'm 
surprised it fails for you.


Can you send me your autopkgtest log?

Michael

autopkgtest [17:19:19]: starting date: 2021-08-27
autopkgtest [17:19:19]: version 5.16
autopkgtest [17:19:19]: host pluto; command line: /usr/bin/autopkgtest -o 
logs-qemu firewalld -- qemu /mnt/share/chroot/autopkgtest-sid.img
qemu-system-x86_64: warning: 9p: degraded performance: a reasonable high msize 
should be chosen on client/guest side (chosen msize is <= 8192). See 
https://wiki.qemu.org/Documentation/9psetup#msize for details.
autopkgtest [17:19:31]: testbed dpkg architecture: amd64
autopkgtest [17:19:33]: testbed running kernel: Linux 5.10.0-8-amd64 #1 SMP 
Debian 5.10.46-4 (2021-08-03)
autopkgtest [17:19:34]:  apt-source firewalld
Get:1 http://deb.debian.org/debian sid/main firewalld 1.0.1-1 (dsc) [2405 B]
Get:2 http://deb.debian.org/debian sid/main firewalld 1.0.1-1 (tar) [2041 kB]
Get:3 http://deb.debian.org/debian sid/main firewalld 1.0.1-1 (diff) [9460 B]
gpgv: unknown type of key resource 'trustedkeys.kbx'
gpgv: keyblock resource '/tmp/dpkg-verify-sig.DC1QbOoT/trustedkeys.kbx': 
General error
gpgv: Signature made Tue Aug 17 21:36:10 2021 UTC
gpgv:using RSA key 09B3AC2ECB169C904345CC546AE1DF0D608F22DC
gpgv: Can't check signature: No public key
dpkg-source: warning: failed to verify signature on ./firewalld_1.0.1-1.dsc
autopkgtest [17:19:44]: testing package firewalld version 1.0.1-1
autopkgtest [17:19:44]: build not needed
autopkgtest [17:19:45]: test standard-tests: preparing testbed
Reading package lists...
Building dependency tree...
Reading state information...
Correcting dependencies...Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
 Done
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
The following additional packages will be installed:
  firewalld firewalld-tests gir1.2-glib-2.0 gir1.2-nm-1.0 ipset iptables
  libgirepository-1.0-1 libglib2.0-0 libglib2.0-bin libglib2.0-data libicu67
  libip6tc2 libipset13 libmpdec3 libnetfilter-conntrack3 libnfnetlink0 libnm0
  libpolkit-agent-1-0 libpolkit-gobject-1-0 libpython3-stdlib
  libpython3.9-stdlib libxml2 libxml2-utils media-types policykit-1 python3
  python3-dbus python3-firewall python3-gi python3-nftables python3.9
Suggested packages:
  python3-doc python3-tk python3-venv python-dbus-doc python3-dbus-dbg
  python3.9-venv python3.9-doc
Recommended packages:
  python3-cap-ng shared-mime-info xdg-user-dirs ca-certificates
The following NEW packages will be installed:
  firewalld firewalld-tests gir1.2-glib-2.0 gir1.2-nm-1.0 ipset iptables
  libgirepository-1.0-1 libglib2.0-0 libglib2.0-bin libglib2.0-data libicu67
  libip6tc2 libipset13 libmpdec3 libnetfilter-conntrack3 libnfnetlink0 libnm0
  libpolkit-agent-1-0 libpolkit-gobject-1-0 libpython3-stdlib
  libpython3.9-stdlib libxml2 libxml2-utils media-types policykit-1 python3
  python3-dbus python3-firewall python3-gi python3-nftables python3.9
0 upgraded, 31 newly installed, 0 to remove and 0 not upgraded.
1 not fully installed or removed.
Need to get 17.1 MB of archives.
After this operation, 82.7 MB of additional disk space will be used.
Get:1 http://deb.debian.org/debian sid/main amd64 libglib2.0-0 amd64 2.68.4-1 
[1390 kB]
Get:2 http://deb.debian.org/debian sid/main amd64 libgirepository-1.0-1 amd64 
1.68.0-2 [96.8 kB]
Get:3 http://deb.debian.org/debian sid/main amd64 gir1.2-glib-2.0 amd64 
1.68.0-2 [152 kB]
Get:4 http://deb.debian.org/debian sid/main amd64 libnm0 amd64 1.30.6-1 [447 kB]
Get:5 http://deb.debian.org/debian sid/main amd64 gir1.2-nm-1.0 amd64 1.30.6-1 
[102 kB]
Get:6 http://deb.debian.org/debian sid/main amd64 libip6tc2 amd64 1.8.7-1 [35.0 
kB]
Get:7 http://deb.debian.org/debian 

Bug#993115: firewalld: missing test dependencies

2021-08-27 Thread Gianfranco Costamagna
Source: firewalld
Version: 1.0.1-1
Severity: serious
tags: patch

Hello, looks some tests needs nftables and ipset installed inside the chroot

the following patch makes them pass all.

diff -Nru firewalld-1.0.1/debian/tests/control 
firewalld-1.0.1/debian/tests/control
--- firewalld-1.0.1/debian/tests/control2021-08-17 23:25:15.0 
+0200
+++ firewalld-1.0.1/debian/tests/control2021-08-27 15:16:04.0 
+0200
@@ -3,6 +3,7 @@
  ipset,
  libglib2.0-bin,
  libxml2-utils,
+ nftables,
 Restrictions: needs-root, isolation-machine
 
 Tests: integration-tests
@@ -10,6 +11,8 @@
  network-manager,
  sudo,
  policykit-1,
+ nftables,
+ ipset
 Restrictions: needs-root, isolation-machine
 
 Tests: smoke


I know Debian infrastructure doesn't support isolation-machine (yet), so I'm not
totally confident about the severity of this bug, but since its trivial to fix, 
better
fix it and leave autopkgtests to user working.

cheers,

Gianfranco