Bug#994808: upgrade issue
Hi, On Wed, 22 Sep 2021, Andreas B. Mundt wrote: > If I don't hear back from you, I'll upload the package with the fix > later today in the early evening. Thanks for the quick upload! > Concerning the autopkgtests: Can you point me to a package that > implements a test to detect these kind of errors early? I don't have any specific example in mind but I was expecting that any test suite that would rely on the daemon running with the parameters defined in /etc/default/atftpd would detect the issue... either because the daemon fails to run or because it runs with options that don't match what was supplied through debconf. > [1] This covers also the case I had here: After the faulty line, I had > a correct line, which made the test: > > $ if ! . /etc/default/atftpd_save ; then echo "Remove broken > /etc/default/atftpd"; fi > bash: 69: command not found > $ > > slightly confusing … Note that the test had "2>/dev/null" to avoid this confusing output. But it's irrelevant now. Cheers, -- ⢀⣴⠾⠻⢶⣦⠀ Raphaël Hertzog ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/ ⠈⠳⣄ Debian Long Term Support: https://deb.li/LTS
Bug#994808: upgrade issue
On Wed, 22 Sep 2021 16:27:46 +0200 "Andreas B. Mundt" wrote: [...] Great, many thanks. I slightly modified the patch to make the fix a bit more targeted: Only the faulty syntax is fixed now, not the whole file removed [1]. You'll find the code already pushed to salsa. I quickly tested and everything works fine for me. Thanks for your quick answer! Concerning the autopkgtests: Can you point me to a package that implements a test to detect these kind of errors early? I don't know specific packages that implement that. Maybe Raphaël does. The syntax error can probably be easily detected if you start the service and check the status of the service in the autopkgtest. Sophie
Bug#994808: upgrade issue
Control: tags -1 + pending Hi Sophie, hi Raphael, On Wed, Sep 22, 2021 at 09:37:46AM +0200, Raphael Hertzog wrote: > > We will come up with an additional MR later today. Great, many thanks. I slightly modified the patch to make the fix a bit more targeted: Only the faulty syntax is fixed now, not the whole file removed [1]. You'll find the code already pushed to salsa. If I don't hear back from you, I'll upload the package with the fix later today in the early evening. Concerning the autopkgtests: Can you point me to a package that implements a test to detect these kind of errors early? Best regards, Andi [1] This covers also the case I had here: After the faulty line, I had a correct line, which made the test: $ if ! . /etc/default/atftpd_save ; then echo "Remove broken /etc/default/atftpd"; fi bash: 69: command not found $ slightly confusing …
Bug#994808: upgrade issue
Hello, Sorry for the partial fix. I created an additional merge request: https://salsa.debian.org/debian/atftp/-/merge_requests/2 This time I tested it in a schroot Kali, in a Kali VM and on my own Debian machine. I hope I have thought of all the possible cases. Regards, Sophie
Bug#994808: upgrade issue
Hello, Le mardi 21 septembre 2021, Andreas B. Mundt a écrit : > I have to investigate further, but does it really work for you? Thanks for testing. Unfortunately, our testing was not sufficient indeed. We tested in a chroot (thus without systemd) and the code path is really different there: the "prerm upgrade" fails while trying to stop the service with "invoke-rc.d atftpd stop" and thus the "prerm failed-upgrade" triggers correctly. However with systemd, there's no failure in the prerm, and the snippet we added is thus useless: we have to also do the same check in "preinst upgrade" instead. We will come up with an additional MR later today. Cheers, -- Raphaël Hertzog
Bug#994808: upgrade issue
Hi Sophie, On Tue, Sep 21, 2021 at 05:12:42PM +0200, Sophie Brun wrote: > > I created Merge Request to fix this issue: > > https://salsa.debian.org/debian/atftp/-/merge_requests/1 > > I tested this patch and uploaded it in Kali Linux while waiting for a fix > in Debian. I hope it can be merged so we can drop our fork. Many thanks for the report and your patch; sorry for causing you extra work with this stupid mistake. I merged the patch, however for me it seems not to be sufficient. I installed the -3 package, added the faulty line to the configuration and tried to upgrade with your patch applied: sudo dpkg -i atftpd_0.7.git20210915-2_amd64.deb (Reading database ... 319039 files and directories currently installed.) Preparing to unpack atftpd_0.7.git20210915-2_amd64.deb ... Warning: Stopping atftpd.service, but it can still be activated by: atftpd.socket Unpacking atftpd (0.7.git20210915-2) over (0.7.git20210202-3) ... Setting up atftpd (0.7.git20210915-2) ... /var/lib/dpkg/info/atftpd.config: 2: /etc/default/atftpd: 69: not found dpkg: error processing package atftpd (--install): installed atftpd package post-installation script subprocess returned error exit status 127 Processing triggers for man-db (2.9.4-2) ... Errors were encountered while processing: atftpd I have to investigate further, but does it really work for you? Best regards, Andi
Bug#994808: upgrade issue
Control: tags -1 + patch Hello, I created Merge Request to fix this issue: https://salsa.debian.org/debian/atftp/-/merge_requests/1 I tested this patch and uploaded it in Kali Linux while waiting for a fix in Debian. I hope it can be merged so we can drop our fork. Thanks Sophie
