Bug#995909: python3-fava: Fails to start with jinja2 3.0.1
Package: python3-fava
Version: 1.18-1
Severity: important
Hi!
On current sid, starting fava fails here:
$ fava accounting.beancount
Traceback (most recent call last):
File "/bin/fava", line 33, in
sys.exit(load_entry_point('fava==1.18', 'console_scripts', 'fava')())
File "/bin/fava", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/usr/lib/python3/dist-packages/fava/cli.py", line 11, in
from fava.application import app
File "/usr/lib/python3/dist-packages/fava/application.py", line 67, in
app.jinja_options["extensions"].append("jinja2.ext.do")
KeyError: 'extensions'
Downgrading python3-jinja2 to 2.11.3-1, and python3-flask to 1.1.2-3,
fixes the problem.
I don't know if all main use cases of Fava are impacted, hence the
non-RC severity.
I understand this is upstream bug https://github.com/beancount/fava/issues/1266,
that's been fixed in the 1.19 release.
Thanks for maintaining Fava in Debian :)
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (990, 'unstable'), (2, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.14.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_USER
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages python3-fava depends on:
ii python3 3.9.2-3
ii python3-babel2.8.0+dfsg.1-7
ii python3-beancount2.3.3-1+b1
ii python3-cheroot 8.5.2+ds1-3
ii python3-click7.1.2-1
ii python3-flask2.0.1-2
ii python3-flask-babel 0.12.2-2
ii python3-jinja2 3.0.1-2
ii python3-markdown22.4.1-1
ii python3-ply 3.11-4
ii python3-simplejson 3.17.5-2
ii python3-werkzeug 2.0.1+dfsg1-2
python3-fava recommends no packages.
python3-fava suggests no packages.
-- no debconf information
Bug#995909: python3-fava: Fails to start with jinja2 3.0.1
Hi, intrigeri (2021-12-05): >> I understand this is upstream bug >> https://github.com/beancount/fava/issues/1266, >> that's been fixed in the 1.19 release. > > Upgrading fava requires python3-flask-babel (>= 1). > > I'll try to update it. I've uploaded python3-flask-babel 2.0.0. Here's a merge request that updates Fava to 1.20.1: https://salsa.debian.org/python-team/packages/fava/-/merge_requests/1 I did not dare uploading because I resorted to a rather ugly hack for the tests to pass: https://salsa.debian.org/python-team/packages/fava/-/blob/debian/new-upstream-1.20.1/debian/patches/0002-Ensure-fava.__version__-is-defined-even-when-the-dis.patch I suppose there's a better way to do it but I know very little about Python packaging, so I would appreciate if someone more at ease in this area reviewed this. Might this be related to the other patch, which is also about version numbers? Suggestions welcome :) Cheers, -- intrigeri
Bug#995909: python3-fava: Fails to start with jinja2 3.0.1
On Sun, 05 Dec 2021 12:50:32 +0100 intrigeri wrote: Here's a merge request that updates Fava to 1.20.1: https://salsa.debian.org/python-team/packages/fava/-/merge_requests/1 I did not dare uploading because I resorted to a rather ugly hack for the tests to pass: https://salsa.debian.org/python-team/packages/fava/-/blob/debian/new-upstream-1.20.1/debian/patches/0002-Ensure-fava.__version__-is-defined-even-when-the-dis.patch I suppose there's a better way to do it but I know very little about Python packaging, so I would appreciate if someone more at ease in this area reviewed this. Might this be related to the other patch, which is also about version numbers? Suggestions welcome :) Hi intrigeri, thanks a lot for your work! I've added some more tweaks and uploaded the new version to unstable. Regarding your patch, the tests pass and there does not seem to be a regression to the last version (1.18-1). As a side note: in your local repository, there's probably a tag for upstream/1.20.1, which is missing on salsa. Could you please push that to salsa as well? Thanks! Regards, Tobias OpenPGP_signature Description: OpenPGP digital signature
Bug#995909: python3-fava: Fails to start with jinja2 3.0.1
Hi, Dr. Tobias Quathamer (2021-12-13): > thanks a lot for your work! I've added some more tweaks and uploaded the > new version to unstable. Thanks! > As a side note: in your local repository, there's probably a tag for > upstream/1.20.1, which is missing on salsa. Could you please push that > to salsa as well? Done :)
