Bug#999694: postfix: postconf outputs 2 bounce_notice_recipient lines

[Vincent Lefevre]

Control: found -1 3.6.3-1

On 2021-11-16 00:23:01 +0100, Vincent Lefevre wrote:
> Control: tags -1 upstream patch
> 
> On 2021-11-15 03:25:10 +0100, Vincent Lefevre wrote:
> > zira:~> postconf | grep '^bounce_notice_recipient'
> > bounce_notice_recipient = postmaster
> > bounce_notice_recipient = postmaster
> 
> Attached Wietse Venema's patch from
>   https://marc.info/?l=postfix-users=163698504624352=2
> 
>   Bugfix (introduced: 20210708): duplicate bounce_notice_recipient
>   entries in postconf output. The fix to send SMTP session
>   transcripts to bounce_notice_recipient was incomplete.
>   Reported by Vincent Lefevre. File: smtpd/smtpd.c.
> 
> I've tested it and everything is OK.

The bug still occurs, but I think that this patch was applied
only for the future 3.7 and later.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Bug#999694: postfix: postconf outputs 2 bounce_notice_recipient lines

[Vincent Lefevre]

Control: tags -1 upstream patch

On 2021-11-15 03:25:10 +0100, Vincent Lefevre wrote:
> zira:~> postconf | grep '^bounce_notice_recipient'
> bounce_notice_recipient = postmaster
> bounce_notice_recipient = postmaster

Attached Wietse Venema's patch from
  https://marc.info/?l=postfix-users=163698504624352=2

  Bugfix (introduced: 20210708): duplicate bounce_notice_recipient
  entries in postconf output. The fix to send SMTP session
  transcripts to bounce_notice_recipient was incomplete.
  Reported by Vincent Lefevre. File: smtpd/smtpd.c.

I've tested it and everything is OK.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
Description: Fix duplicate bounce_notice_recipient entries in postconf output.
 Bug introduced on 2021-07-08. Reported by Vincent Lefevre.
 https://marc.info/?l=postfix-users=163698504624352=2
Bug-Debian: https://bugs.debian.org/999694
Author: Wietse Venema 
Last-Update: 2021-11-15

Index: postfix-3.5.13/src/smtpd/smtpd.c
===
--- postfix-3.5.13.orig/src/smtpd/smtpd.c
+++ postfix-3.5.13/src/smtpd/smtpd.c
@@ -6419,7 +6419,7 @@ int main(int argc, char **argv)
 	VAR_EOD_CHECKS, DEF_EOD_CHECKS, _eod_checks, 0, 0,
 	VAR_MAPS_RBL_DOMAINS, DEF_MAPS_RBL_DOMAINS, _maps_rbl_domains, 0, 0,
 	VAR_RBL_REPLY_MAPS, DEF_RBL_REPLY_MAPS, _rbl_reply_maps, 0, 0,
-	VAR_BOUNCE_RCPT, DEF_ERROR_RCPT, _bounce_rcpt, 1, 0,
+	VAR_BOUNCE_RCPT, DEF_BOUNCE_RCPT, _bounce_rcpt, 1, 0,
 	VAR_ERROR_RCPT, DEF_ERROR_RCPT, _error_rcpt, 1, 0,
 	VAR_REST_CLASSES, DEF_REST_CLASSES, _rest_classes, 0, 0,
 	VAR_CANONICAL_MAPS, DEF_CANONICAL_MAPS, _canonical_maps, 0, 0,

Bug#999694: postfix: postconf outputs 2 bounce_notice_recipient lines

[Vincent Lefevre]

Package: postfix
Version: 3.5.13-1
Severity: minor

zira:~> postconf | grep '^bounce_notice_recipient'
bounce_notice_recipient = postmaster
bounce_notice_recipient = postmaster

A single line would be sufficient.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 
'stable-security'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.14.0-4-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=POSIX, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages postfix depends on:
ii  adduser3.118
ii  cpio   2.13+dfsg-7
ii  debconf [debconf-2.0]  1.5.79
ii  dpkg   1.20.9
ii  e2fsprogs  1.46.4-1
ii  libc6  2.32-4
ii  libdb5.3   5.3.28+dfsg1-0.8
ii  libicu67   67.1-7
ii  libnsl21.3.0-2
ii  libsasl2-2 2.1.27+dfsg-2.3
ii  libssl1.1  1.1.1l-1
ii  lsb-base   11.1.0
ii  netbase6.3
ii  ssl-cert   1.1.1

Versions of packages postfix recommends:
ii  ca-certificates  20211016
ii  python3  3.9.7-1

Versions of packages postfix suggests:
ii  bsd-mailx [mail-reader]  8.1.2-0.20180807cvs-2
ii  emacs-gtk [mail-reader]  1:27.1+1-3.1
ii  libsasl2-modules 2.1.27+dfsg-2.3
ii  mailutils [mail-reader]  1:3.13-1
ii  mutt [mail-reader]   2.0.5-4.1
pn  postfix-cdb  
ii  postfix-doc  3.5.13-1
pn  postfix-ldap 
pn  postfix-lmdb 
pn  postfix-mysql
ii  postfix-pcre 3.5.13-1
pn  postfix-pgsql
pn  postfix-sqlite   
ii  procmail 3.22-26
pn  resolvconf   
pn  ufw  

-- debconf information:
  postfix/retry_upgrade_warning:
  postfix/procmail: true
  postfix/destinations: zira.vinc17.org, 128.119.75.86.rev.sfr.net, 
localhost.vinc17.org, , localhost
  postfix/chattr: false
  postfix/newaliases: false
  postfix/relayhost:
  postfix/kernel_version_warning:
  postfix/main_cf_conversion_warning: true
  postfix/compat_conversion_warning: true
  postfix/relay_restrictions_warning:
  postfix/mailbox_limit: 0
  postfix/bad_recipient_delimiter:
  postfix/mynetworks: 127.0.0.0/8 [:::127.0.0.0]/104 [::1]/128
  postfix/tlsmgr_upgrade_warning:
  postfix/recipient_delim: +
  postfix/rfc1035_violation: false
  postfix/lmtp_retired_warning: true
* postfix/main_mailer_type: Internet Site
  postfix/dynamicmaps_conversion_warning:
  postfix/root_address:
  postfix/mydomain_warning:
* postfix/mailname: zira.vinc17.org
  postfix/protocols: all
  postfix/not_configured:
  postfix/sqlite_warning:

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)