Bug#1057573: linpac: FTBFS: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
Hello Dave,
I received the following email yesterday which gives me the impression
that your patch wasn't accepted. What needs to be done here by Jan 16th?
--
linpac 0.28-2 is marked for autoremoval from testing on 2024-01-16
It is affected by these RC bugs:
1057573: linpac: FTBFS: error: invalid use of incomplete type âWINDOWâ {aka
âstruct _win_stâ}
https://bugs.debian.org/1057573
This mail is generated by:
https://salsa.debian.org/release-team/release-tools/-/blob/master/mailer/mail_autoremovals.pl
Autoremoval data is generated by:
https://salsa.debian.org/qa/udd/-/blob/master/udd/testing_autoremovals_gatherer.pl
--
On 01/01/2024 08:55 AM, Dave Hibberd wrote:
Hi there!
Yeah I’ve pushed his patch already to our git, so if anyone else on
the team wants to upload it they can - I am still waiting on our
account managers to finalise my Debian developer application before I
have free reign to upload things, and I’ll switch this package to
fall under my ownership like a collection of other packet things to
make life a little easier going forward.
Cheers
DH
On 1 Jan 2024, at 16:46, David Ranch wrote:
Hello DaveH,
I have pushed the required fixes to the develop branch of Linpac. I
do plan on adding some other enhancements to Linpac before publishing
an new official release but I don't know if getting out this fix is
important to the Debian release process. Maybe the similar third
party fix offered by Svenis good enough for now to keep Linpac in the
Debian Unstable/Testing repos?
--David
KI6ZHD
On 12/18/2023 02:40 AM, Dave Hibberd wrote:
Hi both,
I'll prepare a team upload for this in advance of the new upstream
release (thanks David), and upload it independently or with support
depending on the outcome of the DAM stage of my NM process
(https://nm.debian.org/process/1224/)
Cheers
DH
--
Hibby
MM0RFN
On Sat, 16 Dec 2023, at 6:32 PM, David Ranch wrote:
Hello Sven, Debian team,
I was about to apply a very similar fix to the "develop" branch of
Linpac at https://sourceforge.net/p/linpac/linpac/ci/develop/tree
though my changes didn't include the "-1" at the end of the
changes. Not sure if that's needed / important. Regardless, I am
planning to eventually merge the develop branch into the Master
branch and releae 0.29 in the near future which will include this
and other fixes.
--David
KI6ZHD
On 12/16/2023 10:01 AM, Sven Joachim wrote:
Control: tags -1 + patch
On 2023-12-05 23:07 +0100, Santiago Vila wrote:
Package: src:linpac
Version: 0.28-2
Severity: serious
Tags: ftbfs
Dear maintainer:
During a rebuild of all packages in unstable, your package failed to build:
[...]
g++ -DHAVE_CONFIG_H -I. -I../../.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-ffile-prefix-map=/<>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o
mail_screen.o mail_screen.cc
mail_screen.cc: In function ‘void init_main_screen()’:
mail_screen.cc:39:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
39 | maxx = stdscr->_maxx;
|^~
In file included from mail_screen.cc:13:
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc:40:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
40 | maxy = stdscr->_maxy;
|^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc: In function ‘void redraw()’:
mail_screen.cc:70:15: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
70 |main_window->_clear = TRUE;
| ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
The attached patch, which can be added to the series file fixes, these
errors and two additional ones in src/linpac.cc, but I have only tested
that the package builds, not if it works. Note that getmaxx(win)
returns win->_maxx + 1, and similar for getmaxy.
Cheers,
Sven
Bug#1057573: linpac: FTBFS: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
Hello DaveH,
I have pushed the required fixes to the develop branch of Linpac. I do
plan on adding some other enhancements to Linpac before publishing an
new official release but I don't know if getting out this fix is
important to the Debian release process. Maybe the similar third party
fix offered by Svenis good enough for now to keep Linpac in the Debian
Unstable/Testing repos?
--David
KI6ZHD
On 12/18/2023 02:40 AM, Dave Hibberd wrote:
Hi both,
I'll prepare a team upload for this in advance of the new upstream
release (thanks David), and upload it independently or with support
depending on the outcome of the DAM stage of my NM process
(https://nm.debian.org/process/1224/)
Cheers
DH
--
Hibby
MM0RFN
On Sat, 16 Dec 2023, at 6:32 PM, David Ranch wrote:
Hello Sven, Debian team,
I was about to apply a very similar fix to the "develop" branch of
Linpac at https://sourceforge.net/p/linpac/linpac/ci/develop/tree
though my changes didn't include the "-1" at the end of the changes.
Not sure if that's needed / important. Regardless, I am planning to
eventually merge the develop branch into the Master branch and releae
0.29 in the near future which will include this and other fixes.
--David
KI6ZHD
On 12/16/2023 10:01 AM, Sven Joachim wrote:
Control: tags -1 + patch
On 2023-12-05 23:07 +0100, Santiago Vila wrote:
Package: src:linpac
Version: 0.28-2
Severity: serious
Tags: ftbfs
Dear maintainer:
During a rebuild of all packages in unstable, your package failed to build:
[...]
g++ -DHAVE_CONFIG_H -I. -I../../.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-ffile-prefix-map=/<>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o
mail_screen.o mail_screen.cc
mail_screen.cc: In function ‘void init_main_screen()’:
mail_screen.cc:39:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
39 | maxx = stdscr->_maxx;
|^~
In file included from mail_screen.cc:13:
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc:40:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
40 | maxy = stdscr->_maxy;
|^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc: In function ‘void redraw()’:
mail_screen.cc:70:15: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
70 |main_window->_clear = TRUE;
| ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
The attached patch, which can be added to the series file fixes, these
errors and two additional ones in src/linpac.cc, but I have only tested
that the package builds, not if it works. Note that getmaxx(win)
returns win->_maxx + 1, and similar for getmaxy.
Cheers,
Sven
Bug#1057573: linpac: FTBFS: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
Hello Sven, Debian team,
I was about to apply a very similar fix to the "develop" branch of
Linpac at https://sourceforge.net/p/linpac/linpac/ci/develop/tree though
my changes didn't include the "-1" at the end of the changes. Not sure
if that's needed / important. Regardless, I am planning to eventually
merge the develop branch into the Master branch and releae 0.29 in the
near future which will include this and other fixes.
--David
KI6ZHD
On 12/16/2023 10:01 AM, Sven Joachim wrote:
Control: tags -1 + patch
On 2023-12-05 23:07 +0100, Santiago Vila wrote:
Package: src:linpac
Version: 0.28-2
Severity: serious
Tags: ftbfs
Dear maintainer:
During a rebuild of all packages in unstable, your package failed to build:
[...]
g++ -DHAVE_CONFIG_H -I. -I../../.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-ffile-prefix-map=/<>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o
mail_screen.o mail_screen.cc
mail_screen.cc: In function ‘void init_main_screen()’:
mail_screen.cc:39:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
39 | maxx = stdscr->_maxx;
|^~
In file included from mail_screen.cc:13:
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc:40:16: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
40 | maxy = stdscr->_maxy;
|^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
|^~~
mail_screen.cc: In function ‘void redraw()’:
mail_screen.cc:70:15: error: invalid use of incomplete type ‘WINDOW’ {aka
‘struct _win_st’}
70 |main_window->_clear = TRUE;
| ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka
‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
The attached patch, which can be added to the series file fixes, these
errors and two additional ones in src/linpac.cc, but I have only tested
that the package builds, not if it works. Note that getmaxx(win)
returns win->_maxx + 1, and similar for getmaxy.
Cheers,
Sven
Bug#957029: ax25mail-utils: ftbfs with GCC-10
Hello Christoph, I was glancing at the SF.net repo for ax25mail-utils but thought I had seen the last commit in 2018. Sorry for being sloppy there. Ok, good that you see it now. Do you think you can resolve the gcc 10 issues (-fcommon is the default now) and put up a new release we can package? Hmmm.. I don't have any systems that run GCC 10 today. Do either of these packages NOT compile on your desired system? What Debian OS version are you testing with? On the linpac side, I see Debian hasn't even picked up the last 0.25 release yet. I'll see to upload that soonish. I would recommend to focus on the 0.28 Git "Develop" branch (Sorry, we have a lot of old dust in the hamradio team we have to work on removing, and I don't think anyone in the team has an overview over all the packages we curate, so please excuse my not so well-founded assessment of your utilities.) That's ok though coming out of the gates saying this package is "horrible", "dead", etc. is a bit brutal. --David KI6ZHD
Bug#957029: ax25mail-utils: ftbfs with GCC-10
Hello Chris, I am the current gatekeeper for this package written by a previous developer with significant help from others. Have you reviewed the current GIT "develop" branch: https://sourceforge.net/p/ax25mail/ax25mail-utils/ci/develop/tree/ same can be said for the Linpac package: https://sourceforge.net/p/linpac/linpac/ci/develop/tree/ The last commit for ax25mail-utils was back in late December 2019 and April 11th 2020 for Linpac so I wouldn't call these as "very much dead upstream". It's more a matter than it's being sustained. Also, I'm not very familiar with the Debian packaging process but I've never seen code reviews come from the packaging process. Is this a new requirement? Is there a set of required Debian best practices, etc. that is enforced here? --David On 08/04/2020 11:31 AM, Christoph Berg wrote: Control: tags -1 upstream wontfix gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -Wall -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -c axgetlist.c In file included from /usr/include/string.h:495, from axgetlist.c:19: In function ‘strncat’, inlined from ‘load_config’ at axgetlist.c:127:42: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning: ‘__builtin___strncat_chk’ output may be truncated copying 1 byte from a string of length 255 [-Wstringop-truncation] The package is horrible 1990ies C code cluttered with global variables that no not even agree about the definitions. Since it seems very much dead upstream, I think it's best to remove it, unless someone thinks it is still needed. (In which case we need a patch to fix this.) Christoph
Bug#801568: Resolving tevent.h name conflict
Hello Jelmer, Yes, I'm working on renaming it. --David On 11/08/2015 08:15 AM, Jelmer Vernooij wrote: Hi Colin, tevent has been shipping tevent.h for a long time, and various dependencies include this header (samba, ldb, openchange). Would it be possible for linpac to change the name of this file? Cheers, Jelmer
