Bug#340576: [interchange-core] Re: Bug#340576: Data Loss in Table Editor

2007-10-11 Thread Jon Jensen

On Tue, 9 Oct 2007, Stefan Hornburg (Racke) wrote:


OK, the attached patch is experimental code in order to fix this problem.
It has the following flaws right now:

* works only with DBI databases
* pragma needs to be set
* confusing error message from DBI in the UI

Any comments and suggestions for improvements ?


Seems ok to me, but I wonder if a pragma is the right level to control it 
from. Does e.g. the table editor distinguish between insert and update 
when creating a new row? I thought it just called set_row blindly, not 
caring whether the row existed already or not.


I wonder if a table editor checkbox Overwrite any existing record or 
some such would be appropriate.


Jon



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#340576: [interchange-core] Re: Bug#340576: Data Loss in Table Editor

2007-10-11 Thread Jon Jensen

On Thu, 11 Oct 2007, Stefan Hornburg (Racke) wrote:

Why not ask the user if he really likes to overwrite a record if the 
insert fails ?


That would be great.

Jon



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]