Bug#1028416: systemctl kexec doesn't shutdown system properly and corrupts mounted filesystems

2023-01-19 Thread Khalid Aziz

On 1/11/23 15:40, Michael Biebl wrote:

Control: reassign -1 kexec-tools

Am 10.01.23 um 20:34 schrieb KOLANICH:

Package: systemd
Version: 252.4-1
Severity: grave
So do kexec-tools if a user has chosen to use it for
reboots during package configuration.
Either of the following can cause fs corruption (to the point one has 
to use `fsck -y`):
a) the procedure described in 
https://wiki.archlinux.org/title/Kexec#Manually
1. `kexec -l /boot/vmlinuz-6.0.0-6-amd64 
--initrd=/boot/initrd-6.0.0-6-amd64 --reuse-cmdline`

2. `systemctl kexec`
b) Just choosing to use kexec for reboots when installing it, and 
then rebooting.


Since systemd basically just calls kexec [1] and running kexec 
directly shows the same issue, let's reassign this to kexec-tools


Michael


[1] 
https://github.com/systemd/systemd/blob/main/src/shutdown/shutdown.c#L584





Can you give me the version of kexec-tools package that you saw this 
issue with?


Thanks,
Khalid



Bug#957403: kexec-tools: diff for NMU version 1:2.0.20-2.1

2020-07-31 Thread Khalid Aziz
On 7/31/20 12:03 PM, casca...@debian.org wrote:
> Control: tags 957403 + patch
> 
> 
> Dear maintainer,
> 
> I've prepared an NMU for kexec-tools (versioned as 1:2.0.20-2.1). The diff
> is attached to this message.
> 
> Regards.
> 

Thanks! I appreciate it.

--
Khalid



Bug#942617: FTBFS on i386

2019-10-21 Thread Khalid Aziz
On 10/18/19 9:38 PM, Daniel Baumann wrote:
> tag 942617 + patch
> thanks
> 
> I've found a patch for that and verified that it works, feel free to
> cherry-pick from here:
> 
> https://git.progress-linux.org/distributions/engywuck-backports/packages/kexec-tools/tree/debian/patches/progress-linux/0001-ftbfs-i386.patch
> 

Thanks! I will pull this patch in and update kexec-tools.

--
Khalid



Bug#771671: Fixing kexec-tools bugs in jessie

2017-05-14 Thread Khalid Aziz
On 05/14/2017 05:59 AM, Adrian Bunk wrote:
> Hi Khalid,
> 
> the following RC bugs are open for kexec-tools in jessie and
> seem worth fixing:
> 
>   771671 /sbin/kexec: Unable to load kdump kernel on i386
>   782033 kexec-tools: Reboots the machine while removing the package
>   785714 kexec-tools is broken when using systemd, danger of filesystem 
> corruption
>   807018 kexec-tools: upgrade wheezy-jessie is broken (update-rc.d: 
> /etc/init.d/kexec exists during rc.d purge)
> 
> Could you make a jessie-pu upload [1] fixing them there?
> Alternatively, I can fix them for jessie if you don't object.
> 
> Thanks
> Adrian
> 
> [1] 
> https://www.debian.org/doc/manuals/developers-reference/pkgs.html#upload-stable
> 

Hi Adrian,

Please go ahead and fix them for jessie.

Thanks,
Khalid



Bug#785714: kexec-tools is broken when using systemd, danger of filesystem corruption

2016-03-22 Thread Khalid Aziz
On 03/16/2016 12:18 PM, Jan Stattegger-Sievers wrote:
> Hi,
> 
> for the second time we ran into this problem and lost again data on
> several servers. First time, we assumed a firmware update we ran before
> the reboot to be the cause.
> 
> This time, there was no firmware update and we looked further into this,
> knowing now this is no singular issue. And it turns out: On every kexec
> reboot you will loose data, if your servers are doing a significant
> amount of work shortly before the reboot, since no umount is done
> before the new kernel kicks in.
> 
> This definitely needs a fix!
> 
> Since the proposed fix changes the behavior of reboot and shutdown -r I
> am cc'ing systemd-sysv maintainers.
> 
> Regards,
> Jan
> 

I have managed to reproduce this problem on a test system. I am working
on a fix.

--
Khalid



Bug#785714: kexec-tools is broken when using systemd, danger of filesystem corruption

2016-03-03 Thread Khalid Aziz
On 03/03/2016 12:10 PM, Daniel Baumann wrote:
> On 2016-03-03 01:33, Khalid Aziz and Shuah Khan wrote:
>> I have not been able to reproduce this bug and that has been the
>> limiting factor in being able to fix it.
> 
> I can reliably reproduce it on unmodified, standard/default sid minimal
> install with / on raid1. i'll check tomorrow if i can also reproduce it
> without mdadm (i used to have the problem too without mdadm, but last
> checked a few weeks ago, thus rechecking to confirm).
> 

Hi Daniel,

Is this issue happening for you on jessie or sid? Your original bug
report said Debian 8.0, so I have been focusing on jessie.

--
Khalid



Bug#785714: kexec-tools is broken when using systemd, danger of filesystem corruption

2016-03-02 Thread Khalid Aziz and Shuah Khan
On 02/26/2016 01:13 PM, Daniel Baumann wrote:
> Hi,
> 
> thanks for maintaining kexec-tools, however, kexec-tools reliably and
> reproducibly trashes my root filesystem *on* *every* *reboot*.
> 
> can this be finally fixed please?
> 
> Regards,
> Daniel
> 

Hi Daniel,

I have not been able to reproduce this bug and that has been the
limiting factor in being able to fix it. I have tried this on 3
different machines and kexec reboot always unmounts the root filesystem
correctly before reboot. I am doing a fresh install on another machine
and will spend some time trying to reproduce it. I appreciate your
patience with me.

Thanks,
Khalid



Bug#785714: kexec-tools is broken when using systemd, danger of filesystem corruption

2015-06-19 Thread Khalid Aziz
I have a freshly installed jessie system (which is running systemd, not 
SysV init) and I am having trouble reproducing most of these issues. Let 
me address these one at a time below.


On 05/19/2015 07:15 AM, Thomas Stangner wrote:

Package: kexec-tools
Version: 1:2.0.7-5
Severity: grave
Tags: patch

Rebooting via kexec is currently broken when using the default init system of 
Jessie (systemd) and may result in filesystem corruption or other unwanted 
effects of improperly shutdown services. This bug does not apply when using the 
SysV init system.

Reboots (e.g. via 'reboot', 'systemctl kexec' or 'systemctl reboot') will cause 
the LSB SysV scripts of kexec-tools (/etc/init.d/kexec-load and 
/etc/init.d/kexec) to be stopped BEFORE reaching the systemd kexec target (and 
other systemd targets), which means that other LSB init scripts and/or systemd 
services will be in a race condition with the LSB kexec script and the 
filesystems may not be properly unmounted beforce /etc/init.d/kexec calls 
/sbin/kexec -e.
As an effect of this, after rebooting via kexec, one may often observe orphaned 
inodes or other filesystem incosistencies, especially on a busy machine with 
heavy IO.



/etc/init.d/kexec script header says:

# X-Stop-After: umountroot

which means stop target for /etc/init.d/kexec will not be called until 
root fs has been unmounted, at which point all other filesystems must 
have already been unmounted.


Have you seen any evidence of corruption on a filesystem?


There also seems to be logical error in the /etc/init.d/kexec-load LSB script, 
because the kexec image will only get loaded when the systemd target is reboot 
- when the target is kexec, the image won't be loaded and thus a normal reboot 
will occur.


Rebooting the system with reboot calls the target reboot. If one 
invokes the target kexec directly, their intent is to kexec immediately 
(same as exceuting kexec -e which does not do an orderly shutdown). 
Orderly shutdown is meant to happen when reboot is called, not when 
kernel is kexec'd explicitly by the user. I do not agree with this change.




The following patch for the source package should fix this and make rebooting 
via 'systemctl kexec' possible (when /etc/default/kexec has LOAD_KEXEC 
enabled), 'reboot' or 'systemctl reboot' will result in normal reboots.


--- debian/kexec.init.d.org 2014-07-25 19:03:25.0 +0200
+++ debian/kexec.init.d 2015-05-19 14:26:40.680256999 +0200
@@ -36,7 +36,10 @@
 exit 3
 ;;
stop)
-   do_stop
+   # Only execute, when running with SysV, systemd has its own kexec target
+   if [ ! -d /run/systemd/system ] ; then
+   do_stop
+   fi


This causes systems running systemd to do a normal full reboot, not a 
kexec reboot. I applied this change to a freshly installed jessie system 
running systemd and confirmed lack of kexec reboot with this change.



 ;;
*)
 echo Usage: $0 start|stop 2
--- debian/kexec-load.init.d.org2014-11-24 05:02:10.0 +0100
+++ debian/kexec-load.init.d2015-05-19 14:27:43.431537728 +0200
@@ -102,9 +102,9 @@
 ;;
stop)
 # If running systemd, we want kexec reboot only if current
-   # command is reboot
+   # target is kexec
 if [ -d /run/systemd/system ]; then
-   systemctl list-jobs systemd-reboot.service | grep -q 
systemd-reboot.service
+   systemctl list-jobs systemd-kexec.service | grep -q 
systemd-kexec.service
 if [ $? -ne 0 ]; then
 exit 0
 fi


This change also bypasses kexec reboot and does a normal reboot. Again 
confirmed on a freshly installed jessie system.


--
Khalid




-- System Information:
Debian Release: 8.0
   APT prefers stable-updates
   APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages kexec-tools depends on:
ii  debconf [debconf-2.0]  1.5.56
ii  libc6  2.19-18

kexec-tools recommends no packages.

kexec-tools suggests no packages.

-- debconf information:
* kexec-tools/load_kexec: true
   kexec-tools/use_grub_config: false




--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#730896: kexec-tools: FTBFS: stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or directory

2013-12-16 Thread Khalid Aziz
On Sat, 2013-11-30 at 16:28 +0100, David Suárez wrote:
 During a rebuild of all packages in sid, your package failed to build on
 amd64.
 
 Relevant part (hopefully):
  gcc -m32 -D_FORTIFY_SOURCE=2 -I./include -I./util_lib/include -Iinclude/  
  -DRELOC=0x1  -c -MD -o kexec_test/kexec_test16.o 
  kexec_test/kexec_test16.S
  In file included from command-line:0:0:
  /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file 
  or directory
   #include bits/predefs.h
^
  compilation terminated.
  make[1]: *** [kexec_test/kexec_test16.o] Error 1

I have tried to reproduce this problem multiple times so I could debug
it and have failed to reproduce it. Error message looks like issue with
glibc. buildd shows amd64 package for kexec-tools built and installed
successfully -
https://buildd.debian.org/status/package.php?p=kexec-toolssuite=sid.
Could it have been a glitch in glibc that has been resolved?

--
Khalid


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#543081: kexec-tools: FTBFS: ./configure: line 5806: syntax error: unexpected end of file

2009-09-10 Thread Khalid Aziz
On Thu, 2009-09-10 at 11:27 +0300, Yavor Doganov wrote:
 On Wed, Sep 09, 2009 at 01:44:00PM -0600, Khalid Aziz wrote:
  This bug is caused by redefinition of AC_MSG_ERROR macro in autoconf
  2.64. I am working on a fix.
 
 There is no redefinition of AC_MSG_ERROR; the configure.ac has a bug 
 which is now exposed.
 
 You just need to add a semicolon before each `fi'.  Or just use AS_IF 
 which is shorter, clearer and works in all situations.
 

I have compared expansion of AC_MSG_ERROR between 2.63 and 2.64. It
looks very different between the two. Nevertheless, you are right. The
fix is simply to add a ; before fi. I have already added that patch
and sent the same patch out to kexec-tools maintainer yesterday. I was
trying to update kexec-tools to 2.0.1. while fixing this bug as well but
have run into some problems. I will upload 2.0.0 with this fix for now
and work on 2.0.1 after that.

-- 
Khalid
===
Khalid Aziz
kha...@debian.org




-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#543081: kexec-tools: FTBFS: ./configure: line 5806: syntax error: unexpected end of file

2009-09-09 Thread Khalid Aziz
This bug is caused by redefinition of AC_MSG_ERROR macro in autoconf
2.64. I am working on a fix.

-- 
===
Khalid Aziz
kha...@debian.org




-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#543081: kexec-tools: FTBFS: ./configure: line 5806: syntax error: unexpected end of file

2009-08-26 Thread Khalid Aziz
Ack.

I am looking into it.

--
Khalid






-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#473547: kexec is broken on amd64

2008-04-28 Thread Khalid Aziz
On Mon, 2008-03-31 at 11:53 +0200, Romain Francoise wrote:
 Package: kexec-tools
 Version: 20080227-2
 Severity: serious
 
 Trying to load a kernel with the current version of kexec fails with the
 following error on amd64:
 
  Symbol: entry32_regs not found cannot get
 
 This issue is apparently fixed upstream, you may wish to update the
 package:
 
  http://lists.infradead.org/pipermail/kexec/2008-March/001444.html
 
 -- System Information:
 Debian Release: lenny/sid
   APT prefers unstable
   APT policy: (500, 'unstable')
 Architecture: amd64 (x86_64)
 
 Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores)
 Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/bash
 
 Versions of packages kexec-tools depends on:
 ii  debconf   1.5.20 Debian configuration management 
 sy
 ii  libc6 2.7-10 GNU C Library: Shared libraries
 
 kexec-tools recommends no packages.
 
 -- debconf information:
 * kexec-tools/load_kexec: 1
 
 
 

I am packaging up version 20080324 which fixes this bug. I am waiting
for debconf translation updates and will release soon after I receive
those.

-- 
===
Khalid Aziz
[EMAIL PROTECTED]




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#477260: kexec-tools: fails to build on powerpc.

2008-04-25 Thread Khalid Aziz
Previous release of kexec-tools did not build on powerpc which is why I
had removed powerpc from the list of architectures (see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=338846). Are you sure
this version (20080227) builds and works reliably on powerpc?

--
Khalid

On Tue, 2008-04-22 at 12:27 +1000, Tony Breeds wrote:
 Package: kexec-tools
 Version: 20080227-2
 Severity: serious
 Justification: no longer builds from source
 
 the control file uses ppc64 as a build-architecture, I believe this
 should be powerpc.  I have made that change locally and it seems to
 build and work.
 
 http://buildd.debian.org/fetch.cgi?pkg=kexec-toolsver=20080227-2arch=powerpcstamp=1206822164file=log
 
 Note: I'm running reportbug on my (x86) laptop.
 
 -- System Information:
 Debian Release: lenny/sid
   APT prefers unstable
   APT policy: (500, 'unstable')
 Architecture: i386 (i686)
 
 Kernel: Linux 2.6.25-rc8 (SMP w/1 CPU core)
 Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/bash
 
 Versions of packages kexec-tools depends on:
 ii  debconf [debconf-2.0] 1.5.21 Debian configuration management 
 sy
 ii  libc6 2.7-10 GNU C Library: Shared libraries
 
 kexec-tools recommends no packages.
 
 Yours Tony
 
   linux.conf.auhttp://linux.conf.au/ || http://lca2008.linux.org.au/
   Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
 
 
 

-- 
===
Khalid Aziz
[EMAIL PROTECTED]




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#442280: gsoap: Possible license issue with wsdl2h

2007-09-14 Thread Khalid Aziz
Package: gsoap
Version: 2.7.9b-1.1
Severity: serious
Justification: Policy 2.1

wsdl2h tool included in gsoap package is licensed under gSOAP
commercial 
license http://www.genevia.com/Products/gsoap/contract.html and is not
compliant with Debian FSG I believe. This license should be looked at
more closely before we continue distributing wsdl2h in debian gsoap
package.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.21-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gsoap depends on:
ii  libc6 2.6.1-2GNU C Library: Shared
libraries
ii  libgcc1   1:4.2.1-5  GCC support library
ii  libstdc++64.2.1-5The GNU Standard C++
Library v3

gsoap recommends no packages.

-- no debconf information




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#327639: kexec-tools: FTBFS: ./configure: Permission denied

2005-09-12 Thread Khalid Aziz
On Sun, 2005-09-11 at 16:07 +0200, Kurt Roeckx wrote:
 Package: kexec-tools
 Version: 1.101-1
 Severity: serious
 
 Hi,
 
 Your package is failing to build with the following error:
 ./configure --sbindir=/sbin --mandir=/usr/share/man --datadir=/usr/share
 make: execvp: ./configure: Permission denied
 make: *** [configure-stamp] Error 127
 
 
 It looks like the configure script is not executable, and you'll
 have to chmod it before running it.
 
 
 Kurt
 
 

I am trying to track this down. configure script is executable in
orig.tar.gz and diff.gz should not change the permissions.

--
Khalid Aziz
[EMAIL PROTECTED]



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#327715: kexec-tools: FTBFS: ./configure: Permission denied

2005-09-12 Thread Khalid Aziz
On Sun, 2005-09-11 at 19:31 +0200, Andreas Jochens wrote:
 Package: kexec-tools
 Version: 1.101-1
 Severity: serious
 Tags: patch
 
 When building 'kexec-tools' on unstable,
 I get the following error:
 
 
 dh_testdir
 # Add here commands to configure the package.
 ./configure --sbindir=/sbin --mandir=/usr/share/man --datadir=/usr/share
 make: execvp: ./configure: Permission denied
 make: *** [configure-stamp] Error 127
 
 With the attached patch 'kexec-tools' can be compiled on unstable.
 
 Regards
 Andreas Jochens
 
 diff -urN ../tmp-orig/kexec-tools-1.101/debian/rules ./debian/rules
 --- ../tmp-orig/kexec-tools-1.101/debian/rules2005-09-11 
 15:48:14.0 +
 +++ ./debian/rules2005-09-11 15:42:30.0 +
 @@ -24,6 +24,7 @@
  configure-stamp: 
   dh_testdir
   # Add here commands to configure the package.
 + chmod a+x configure
   ./configure --sbindir=/sbin --mandir=/usr/share/man --datadir=/usr/share
  
   touch configure-stamp
 

This puts a band aid on the real problem but does not solve the real
problem. diff .gz file does not look correct to me which is where the
real problem is. I am looking into it.

-- 
Khalid Aziz
[EMAIL PROTECTED]



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]