Bug#729540: closed by Bernd Zeimetz

2014-01-12 Thread Mihai Limbasan
Jim, it looks like you're trying to build a modified package, not 
Bernd's package - is that correct?


There are two issues I can see:

- your CFLAGS don't seem to include -Wno-deprecated-declarations, 
without which the build will fail because GCC will treat the warnings as 
errors. Now, granted, those warnings could be patched away by using some 
explicit casts, but I'd rather not mask some possible subtle bugs that way
- you seem to be compiling with GCC 4.8. This package will not 
build with 4.8 anytime soon, unfortunately, unless upstream migrates to 
4.8+ as well


Both issues have been dealth with both in my package and in Bernd's, are 
you absolutely sure you're using the correct one?


Mihai


Bug#729540: closed by Bernd Zeimetz b...@debian.org (Bug#729540: fixed in open-vm-tools 2:9.4.0-1280544-1)

2014-01-12 Thread Mihai Limbasan
Oh, I can finally get rid of 4.7 then! Awesome, thank you. It's good to 
see open-vm-tools adopted again.


Mihai

On 01/13/2014 12:15 AM, Bernd Zeimetz wrote:

hi,

please use open-vm-tools 2:9.4.0-1280544-5 - not -1.
Building with 3.11 should work fine with -1, but 3.12 (and gcc 4.8) needs -5.

Mihai: -5 builds just fine with gcc 4.8 :)

Cheers,

Bernd

On 01/07/2014 07:33 AM, Jim Barber wrote:

Hi Bernd.

I have tried this new version of open-vm-tools-dkms against the 3.12 kernel that
is now in Debian testing and it failed to compile for me.
The contents of the /var/lib/dkms/open-vm-tools/9.4.0/build/make.log file 
follows:


DKMS make.log for open-vm-tools-9.4.0 for kernel 3.12-1-amd64 (x86_64)
Tuesday 7 January  14:12:27 WST 2014
Using 2.6.x kernel build system.
make: Entering directory `/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock'
make -C /lib/modules/3.12-1-amd64/build/include/.. SUBDIRS=$PWD SRCROOT=$PWD/. \
   MODULEBUILDDIR=/var/lib/dkms/open-vm-tools/9.4.0/build modules
make[1]: Entering directory `/usr/src/linux-headers-3.12-1-amd64'
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/block.o
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/control.o
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/control.c: In function
‘ExecuteBlockOp’:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/control.c:286:9: warning:
assignment from incompatible pointer type [enabled by default]
 name = getname(buf);
  ^
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.o
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.c:38:4: warning:
initialization from incompatible pointer type [enabled by default]
 .d_revalidate = DentryOpRevalidate,
 ^
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.c:38:4: warning:
(near initialization for ‘LinkDentryOps.d_revalidate’) [enabled by default]
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.c: In function
‘DentryOpRevalidate’:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.c:104:7: warning:
passing argument 2 of ‘actualDentry-d_op-d_revalidate’ makes integer from
pointer without a cast [enabled by default]
return actualDentry-d_op-d_revalidate(actualDentry, nd);
^
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/dentry.c:104:7: note:
expected ‘unsigned int’ but argument is of type ‘struct nameidata *’
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/file.o
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/filesystem.o
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.o
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c:49:4: warning:
initialization from incompatible pointer type [enabled by default]
 .lookup = InodeOpLookup,
 ^
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c:49:4: warning:
(near initialization for ‘RootInodeOps.lookup’) [enabled by default]
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c: In function
‘InodeOpLookup’:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c:138:32: error:
incompatible types when assigning to type ‘kgid_t’ from type ‘int’
 inode-i_uid = inode-i_gid = 0;
 ^
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c: In function
‘InodeOpFollowlink’:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.c:224:4: error:
implicit declaration of function ‘vfs_follow_link’
[-Werror=implicit-function-declaration]
 ret = vfs_follow_link(nd, iinfo-name);
 ^
cc1: some warnings being treated as errors
make[4]: *** [/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock/linux/inode.o]
Error 1
make[3]: *** [_module_/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock] Error 2
make[2]: *** [sub-make] Error 2
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.12-1-amd64'
make: *** [vmblock.ko] Error 2
make: Leaving directory `/var/lib/dkms/open-vm-tools/9.4.0/build/vmblock'
Using 2.6.x kernel build system.
Building vmhgfs without VMCI module symbols.
make: Entering directory `/var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs'
make -C /lib/modules/3.12-1-amd64/build/include/.. SUBDIRS=$PWD SRCROOT=$PWD/. \
   MODULEBUILDDIR=/var/lib/dkms/open-vm-tools/9.4.0/build modules
make[1]: Entering directory `/usr/src/linux-headers-3.12-1-amd64'
   CC [M]  /var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs/backdoor.o
In file included from
/var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs/backdoor.h:44:0,
  from 
/var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs/backdoor.c:49:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs/./shared/backdoor_types.h: In
function ‘BACKDOOR_STRUCT_SIZES’:
/var/lib/dkms/open-vm-tools/9.4.0/build/vmhgfs/./shared/vm_assert.h:366:20:
warning: typedef ‘AssertOnCompileFailed’ locally defined but not used
[-Wunused-local-typedefs]
typedef char 

Bug#729540: Packaged (WORKSFORME) open-vm-tools-9.4.0-1280544, perhaps it helps

2014-01-02 Thread Mihai Limbasan

Hi there,

Ran into the same issue, so I packaged open-vm-tools-9.4.0-1280544 from 
upstream based on the sid package for 9.2.3. Works just fine for me in 
Workstation 10.0.1 with linux-image-3.12-1-amd64. Did *not* test Shared 
Folders (i.e. vmhgfs) which I don't care about since it has sucked for 
years.


If someone needs it, you can find the source at 
http://deb.limbasan.ro/sid/pool/main/o/open-vm-tools/open-vm-tools_9.4.0-1280544-1.dsc 
(there are also amd64 binaries, but I wouldn't run binaries provided by 
Some Random Person Off The Internet.)


Not particularly well-versed in Debian packaging policy so I'm sure it 
can be improved significantly.


Apart from the obvious version number change, the changes required were 
as follows (detailed in the changelog as well):


- Removed 0004-vmblock-vmhgfs-compat-3_10.patch from the patch series, 
it's no longer required.
- Altered dh_auto_configure invocation to include Debian's procps 
library name (CUSTOM_PROCPS_NAME=procps as documented in configure.ac)
- Altered dh_auto_configure invocation to avoid gcc erroring out on 
deprecated glib function declarations 
(CFLAGS=-Wno-deprecated-declarations). I'm sure this violates some 
policies, but upstream has clearly indicated in bug 122 at 
http://sourceforge.net/p/open-vm-tools/tracker/122/ that they won't fix 
this (they need to support older glib versions, and they don't want to 
litter the code with ifdefs.) Nate Muench provided a patch there if the 
CFLAGS changes are inacceptable.


Hope this helps someone.

Mihai


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#729540: Forgot to mention - still doesn't build with GCC 4.8

2014-01-02 Thread Mihai Limbasan
Forgot to mention - still doesn't build with GCC 4.8 (unexpected struct 
size issues galore.)



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org