Bug#874853: [cmtk] Future Qt4 removal from Buster
No plans for Qt5 whatsoever. The only thing to note here is that Qt is actually optional for the vast majority of CMTK's tools. The package config could probably be changed to build without GUI support, which would remove the dependency on Qt. Am Do., 31. Okt. 2019 um 15:57 Uhr schrieb Moritz Mühlenhoff : > On Sat, Sep 09, 2017 at 09:03:16PM +0200, Lisandro Damián Nicanor Pérez > Meyer wrote: > > Source: cmtk > > Version: 3.3.1-1.2 > > Severity: wishlist > > User: debian-qt-...@lists.debian.org > > Usertags: qt4-removal > > > > > > Hi! As you might know we the Qt/KDE team are preparing to remove Qt4 > > as [announced] in: > > > > [announced] < > https://lists.debian.org/debian-devel-announce/2017/08/msg6.html> > > > > Currently Qt4 has been dead upstream and we are starting to have problems > > maintaining it, like for example in the [OpenSSL 1.1 support] case. > > > > [OpenSSL 1.1 support] < > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828522> > > > > In order to make this move, all packages directly or indirectly > depending on > > the Qt4 libraries have to either get ported to Qt5 or eventually get > > removed from the Debian repositories. > > > > Therefore, please take the time and: > > - contact your upstream (if existing) and ask about the state of a Qt5 > > port of your application > > - if there are no activities regarding porting, investigate whether > there are > > suitable alternatives for your users > > - if there is a Qt5 port that is not yet packaged, consider packaging it > > - if both the Qt4 and the Qt5 versions already coexist in the Debian > > archives, consider removing the Qt4 version > > There hasn't been any followup on this bug since two years and we're now > moving > forward with the Qt4 removal, are the immediate plans to port cmtk to Qt5 > or > should we remove it from the archive? > > Cheers, > Moritz > > >
Bug#919727:
Hello again - So I don't know how you guys pull CMTK sources, but I just published a new release with the DCMTK compile errors fixed. Download here: https://www.nitrc.org/frs/download.php/11132/CMTK-3.3.1p1-Source.tar.gz Or from SVN at NITRC via https://nitrc.org/svn/cmtk/releases/3.3.1p1 Best, Torsten
Bug#919727: cmtk /dcmtk
Thanks Yarik, but too late ;)
Anyway, I have a patch (see below) that appears to work. I'll be rolling a
small bugfix release of CMTK in the next few days if/when I get a chance.
Index: core/apps/dcm2image.cxx
===
--- core/apps/dcm2image.cxx (revision 5439)
+++ core/apps/dcm2image.cxx (working copy)
@@ -82,7 +82,11 @@
const std::string tagName( pattern, static_cast(
equals-pattern ) );
const DcmDictEntry* dictEntry = dcmDataDict.rdlock().findEntry(
tagName.c_str() );
+#if PACKAGE_VERSION_NUMBER < 364
dcmDataDict.unlock();
+#else
+dcmDataDict.rdunlock();
+#endif
if ( dictEntry )
{
@@ -482,7 +486,11 @@
#ifdef CMTK_DCMDICTPATH
if ( dcmDataDict.wrlock().loadDictionary( CMTK_DCMDICTPATH ) )
{
+#if PACKAGE_VERSION_NUMBER < 364
dcmDataDict.unlock();
+#else
+ dcmDataDict.wrunlock();
+#endif
}
else
#endif
@@ -489,7 +497,11 @@
#ifdef CMTK_DCMDICTPATH_INSTALL
if ( dcmDataDict.wrlock().loadDictionary( CMTK_DCMDICTPATH_INSTALL ) )
{
+#if PACKAGE_VERSION_NUMBER < 364
dcmDataDict.unlock();
+#else
+ dcmDataDict.wrunlock();
+#endif
}
else
#endif
@@ -566,9 +578,17 @@
if ( !dcmDataDict.rdlock().findEntry( "RawDataType_ImageType" ) )
{
+#if PACKAGE_VERSION_NUMBER < 364
dcmDataDict.unlock();
+#else
+dcmDataDict.rdunlock();
+#endif
dcmDataDict.wrlock().addEntry( new DcmDictEntry( 0x0043, 0x102f,
EVR_SS, "RawDataType_ImageType", 1, 1, NULL, OFFalse, "GE" ) );
+#if PACKAGE_VERSION_NUMBER < 364
dcmDataDict.unlock();
+#else
+dcmDataDict.wrunlock();
+#endif
}
VolumeList volumeList( Tolerance );
===
On Mon, Jan 21, 2019 at 8:08 PM Yaroslav Halchenko
wrote:
>
> On Mon, 21 Jan 2019, Torsten Rohlfing wrote:
>
> >Hi there -
> >Upstream owner of CMTK here. It looks like DCMTK in release 3.6.4
> changed
> >their API for locking/unlocking the global data dictionary.
> >I am going to look into fixing this, but it'll take a while since I'll
> >have to set up a suitable Debian VM for testing first.
>
> docker run -it --rm debian:sid
>
> adjust /etc/apt/sources.list to include deb-src entries
>
> apt-get update
> apt-get build-dep cmtk
>
> and you should be all set ;)
>
> --
> Yaroslav O. Halchenko
> Center for Open Neuroscience http://centerforopenneuroscience.org
> Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
> Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
> WWW: http://www.linkedin.com/in/yarik
>
Bug#919727: cmtk /dcmtk
Hi there - Upstream owner of CMTK here. It looks like DCMTK in release 3.6.4 changed their API for locking/unlocking the global data dictionary. I am going to look into fixing this, but it'll take a while since I'll have to set up a suitable Debian VM for testing first. Best, Torsten
Bug#772217: fixed in cmtk 3.2.2-1.1
Thanks from me as well.
It seems that your patch is more sophisticated than my upstream fix (which
essentially just switches the scripts shebang to /bin/bash). Please let me
know if you want me to deploy your patch instead.
Best,
Torsten
On Dec 15, 2014 6:36 AM, Yaroslav Halchenko y...@debian.org wrote:
thank you guys for helping with the cmtk package! And sorry for being
slow to respond/react
Upstream also issued a patch to address bashisms, see it attached.
it seems that we are still at -1.2 in the archive so I could issue -2
with this one or if you are at it already -- just go ahead with NMU and
I will absorb it later into VCS
(http://git.debian.org/?p=pkg-exppsy/cmtk.git)
cheers
On Sun, 14 Dec 2014, Adam D. Barratt wrote:
Control: reopen -1
On Sun, 2014-12-14 at 21:48 +, Michael Gilbert wrote:
cmtk (3.2.2-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix bashisms in shell scripts (closes: #772217).
Unfortunately the fixes are incorrect in some cases:
+- if [[ ${line} =~ ^\} ]]; then
++ if [ ${line} =~ ^\} ]; then
Even bash doesn't support =~ outside of its [[ extension.
Regards,
Adam
--
Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Research Scientist,Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik
Bug#713341: cmtk: FTBFS: CMake Error at CMakeLists.txt:53 (INCLUDE): include could not find load file: /«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles/CMakeSystem.cmake
for include file ieeefp.h - not found -- Looking for include file inttypes.h -- Looking for include file inttypes.h - found -- Looking for include file malloc.h -- Looking for include file malloc.h - found -- Looking for include file pthread.h -- Looking for include file pthread.h - found -- Looking for include file termios.h -- Looking for include file termios.h - found -- Looking for include file unistd.h -- Looking for include file unistd.h - found -- Looking for include file values.h -- Looking for include file values.h - found -- Looking for include file sys/ioctl.h -- Looking for include file sys/ioctl.h - found -- Looking for include file sys/procfs.h -- Looking for include file sys/procfs.h - found -- Looking for include file sys/stat.h -- Looking for include file sys/stat.h - found -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- Looking for include file sys/times.h -- Looking for include file sys/times.h - found -- Looking for include file sys/utsname.h -- Looking for include file sys/utsname.h - found -- Check if the system is big endian -- Searching 16 bit integer -- Using unsigned short -- Check if the system is big endian - little endian -- Check the value of the 22nd bit of a 32-bit quiet-NaN -- Check the value of the 22nd bit of a 32-bit quiet-NaN - 1 -- Looking for C++ include unordered_map -- Looking for C++ include unordered_map - not found -- Looking for C++ include hash_map -- Looking for C++ include hash_map - found -- Try OpenMP C flag = [-fopenmp] -- Performing Test OpenMP_FLAG_DETECTED -- Performing Test OpenMP_FLAG_DETECTED - Success -- Try OpenMP CXX flag = [-fopenmp] -- Performing Test OpenMP_FLAG_DETECTED -- Performing Test OpenMP_FLAG_DETECTED - Success -- Found OpenMP: -fopenmp -- Looking for include file dispatch/dispatch.h -- Looking for include file dispatch/dispatch.h - not found -- Performing Test CMTK_COMPILER_VAR_AUTO_ARRAYSIZE -- Performing Test CMTK_COMPILER_VAR_AUTO_ARRAYSIZE - Success -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) -- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version 1.2.8) -- Using system zlib -- Using system mxml -- Found BZip2: /usr/lib/x86_64-linux-gnu/libbz2.so (found version 1.0.6) -- Looking for BZ2_bzCompressInit in /usr/lib/x86_64-linux-gnu/libbz2.so -- Looking for BZ2_bzCompressInit in /usr/lib/x86_64-linux-gnu/libbz2.so - found -- Found system libbz2 -- Could NOT find LZMA (missing: LZMA_LIBRARIES LZMA_INCLUDE_DIRS) -- Found DCMTK: /usr/include/dcmtk/config -- - tested library png -- - tested library tiff -- - tested library CharLS -- Using system DCMTK library. -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) -- Found SQLite3: /usr/lib/x86_64-linux-gnu/libsqlite3.so -- Using system sqlite3 library -- Looking for Q_WS_X11 -- Looking for Q_WS_X11 - found -- Looking for Q_WS_WIN -- Looking for Q_WS_WIN - not found -- Looking for Q_WS_QWS -- Looking for Q_WS_QWS - not found -- Looking for Q_WS_MAC -- Looking for Q_WS_MAC - not found -- Found Qt4: /usr/bin/qmake (found suitable version 4.8.4, minimum required is 4.3.0) Qt4 Found OK () -- Configuring incomplete, errors occurred! dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_APPS:BOOL=ON -DBUILD_DOCUMENTATION:BOOL=OFF -DBUILD_GUI:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_TESTING:BOOL=OFF -DCMTK_BUILD_DCMTK:BOOL=OFF -DCMTK_BUILD_MXML:BOOL=OFF -DCMTK_BUILD_NRRD:BOOL=ON -DCMTK_BUILD_SQLITE:BOOL=OFF -DCMTK_BUILD_ZLIB:BOOL=OFF -DCMTK_ROOT_PATH_SRI24:PATH=/usr/share/data/sri24-atlas -DCMTK_USE_DCMTK:BOOL=ON -DCMTK_USE_FFTW:BOOL=ON -DCMTK_USE_QT:BOOL=ON -DCMTK_USE_SMP:BOOL=ON -DCMTK_USE_SQLITE:BOOL=ON -DDART_TESTING_TIMEOUT:STRING=15000 -DMXML_INCLUDE_DIR:PATH=/usr/include -DLZMA_INCLUDE_DIRS:PATH=/usr/include/lzma -DCMAKE_SKIP_RPATH:BOOL=OFF -DCMTK_BUILD_WRAPPER:BOOL=ON returned exit code 1 make[1]: *** [override_dh_auto_configure] Error 2 The full build log is available from: http://aws-logs.debian.net/ftbfs-logs/2013/06/20/cmtk_2.2.2-2_unstable.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. -- Torsten Rohlfing, PhD SRI International, Neuroscience Program Program Director 333 Ravenswood Ave, Menlo Park, CA 94025 Phone: ++1 (650) 859-3379 Fax: ++1 (650) 859-2743 tors...@synapse.sri.comhttp://www.stanford.edu/~rohlfing/ Though this be madness, yet there is a method in't -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
