Bug#971713: sysstat: init or systemd file has overlapping runlevels
On Tue, 15 Dec 2020 12:45:40 -0400
Jesse Smith wrote:
> I gave the patch a test run and, while I like what it does in theory,
> in practise I'm running into trouble with it. When I use the attached
> patch and then run "make check" in the insserv source directory,
> inssrev segfaults after about eight tests. I haven't had a chance yet
> to hunt down what is causing the problem, but I'm guessing a variable
> is getting used before it is given a value/initialized.
well, moving the Start_Stop_Overlap call broke the assumption that
start_levels and stop_levels are never undefined, so this additional
patch should fix the regression
make check now passes all 240 tests
thanks for the review and happy hacking! :)
>From 4a3b1e90f23792b6f640e8d9bc28c334cafce843 Mon Sep 17 00:00:00 2001
From: Trek
Date: Tue, 15 Dec 2020 20:00:18 +0100
Subject: [PATCH 3/3] Skip overlapping check on empty runlevels
---
insserv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/insserv.c b/insserv.c
index dbd3202..b7e1d8f 100644
--- a/insserv.c
+++ b/insserv.c
@@ -2737,6 +2737,8 @@ boolean Start_Stop_Overlap(char *start_levels, char *stop_levels)
int string_index = 0;
char *found;
+ if (!start_levels || !stop_levels) return false;
+
while (start_levels[string_index]) /* go to end of string */
{
if (start_levels[string_index] != ' ') /* skip spaces */
--
2.20.1
Bug#971713: sysstat: init or systemd file has overlapping runlevels
On Tue, 15 Dec 2020 00:58:19 +0100
Robert Luberda wrote:
> >> insserv: Script ssh has overlapping Default-Start and Default-Stop
> >> runlevels (2 3 4 5) and (2 3 4 5). This should be fixed.
>
> What is surprising the ssh warning is shown even if I run insserv from
> the command line without giving any other arguments:
> [...]
> While the sysstat warning is shown only on upgrades.
it is because insserv scan all the init.d files on each invocation, but
it scans the rc.d links only for the ones specified by commandline
> Removing the links removes the warning as well:
> [...]
> But when I re-add the K01ssh links, 'apt install --reinstall sysstat'
> warns about ssh, and no longer about sysstat service...
this is the culprit: if the user tweaks the rc.d links, then the
overlapping warning appears, but it should not
> Oh, wait, I've just read my email from Sunday, and it looks like the
> warning on my system was always about ssh:
> [...]
> Sorry about not noticing it before, I must have been too strongly
> suggested by the Julian's original bug report :(
>
> So it looks like the warning says that run-level links were customized
> by a user. IMHO it would be nice if the warning message stated this
> simple fact in a more explicit way.
well, thanks to your report we found a bug in insserv :)
> I looked into insserv(8) man page before changing the script, and was
> under impression that Default-Start and Default-Stop must contain at
> least one run level, as the example given at the top of the man page
> says:
>
> # Default-Start: run_level_1 [ run_level_2 ...]
> # Default-Stop: run_level_1 [ run_level_2 ...]
the actual syntax may be misleading, because insserv works happily if
any of those fields are empty (or even missing)
> But if you're sure they can be empty, I will revert the change in
> sysstat's init.d script.
yes, you can safely revert it, as far i understand
@Jesse Smith: I attached a possible fix, but it slightly changes the
behavior, as now it prints the overlapping warning when loading all the
init.d scripts and not only for the ones in the commandline
this because if script_inf.default_start and stop are empty, they are
overwritten by the levels gathered from rc.d links and I do not fully
understand the implications of removing those overwrites, so I just
moved the code before this part
the second patch is for the manpage about empty fields, that are
allowed by insserv, but probably it could be explained better
please to tell me if you need some more info or work to be done :)
ciao!
>From d6704148edd51cbb972a9e61e9d165a9e266be45 Mon Sep 17 00:00:00 2001
From: Trek
Date: Tue, 15 Dec 2020 16:17:54 +0100
Subject: [PATCH 1/2] Check only LSB header for overlapping runlevels to fix
Debian bug #971713
---
insserv.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/insserv.c b/insserv.c
index 1e43bf0..dbd3202 100644
--- a/insserv.c
+++ b/insserv.c
@@ -3573,6 +3573,14 @@ int main (int argc, char *argv[])
if (script_inf.stop_after && script_inf.stop_after != empty) {
reversereq(service, REQ_SHLD|REQ_KILL, script_inf.stop_after);
}
+
+overlap = Start_Stop_Overlap(script_inf.default_start, script_inf.default_stop);
+if (overlap)
+{
+warn("Script `%s' has overlapping Default-Start and Default-Stop runlevels (%s) and (%s). This should be fixed.\n",
+ d->d_name, script_inf.default_start, script_inf.default_stop);
+}
+
/*
* Use information from symbolic link structure to
* check if all services are around for this script.
@@ -3739,13 +3747,6 @@ int main (int argc, char *argv[])
}
#endif /* not SUSE */
-overlap = Start_Stop_Overlap(script_inf.default_start, script_inf.default_stop);
-if (overlap)
-{
-warn("Script %s has overlapping Default-Start and Default-Stop runlevels (%s) and (%s). This should be fixed.\n",
- d->d_name, script_inf.default_start, script_inf.default_stop);
-}
-
if (isarg && !defaults && !del) {
if (argr[curr_argc]) {
char * ptr = argr[curr_argc];
--
2.20.1
>From fa303693753e774adc3ad1d34679d346b4beddaa Mon Sep 17 00:00:00 2001
From: Trek
Date: Tue, 15 Dec 2020 16:16:12 +0100
Subject: [PATCH 2/2] Added Default-Start and Stop definitions to insserv.8
---
insserv.8.in | 9 +
1 file changed, 9 insertions(+)
diff --git a/insserv.8.in b/insserv.8.in
index b79385a..5faa46e 100644
--- a/insserv.8.in
+++ b/insserv.8.in
@@ -97,6 +97,11 @@ execute insserv directly unless you know exactly what you're doing, doing so
may render your boot system inoperable.
.B update\-rc.d
is the recommended interface for manag
Bug#971713: sysstat: init or systemd file has overlapping runlevels
On Mon, 14 Dec 2020 03:54:28 +0100 Lorenzo wrote: > if you are searching in the source under /debian directory, the code > that you are looking for will be written by dh-installinit in place of > the #DEBHEPLER# placeholder, during the build of the package. @Lorenzo oh yeah, many thanks :) so the fix would be like the one attached to this mail but reading the init.d script I see that it does not stop anything, so an empty Default-Stop should be correct what I really don't understand now it's from where those messages come from: > insserv: Script sysstat has overlapping Default-Start and > Default-Stop runlevels (2 3 4 5) and (2 3 4 5). This should be fixed. running insserv on a script with an empty Default-Stop field does not print this message, at least with buster and sid versions reading the source, it could set an empty Default-Stop to the value of Default-Start, but only when compiled with the -DSUSE flag enabled: https://sources.debian.org/src/insserv/1.21.0-1/insserv.c/#L3727 and this flag is not enabled on debian builds > insserv: Script ssh has overlapping Default-Start and Default-Stop > runlevels (2 3 4 5) and (2 3 4 5). This should be fixed. this instead comes from ssh, that have an empty Default-Stop too @Robert Luberda: I ran out of ideas, your script was correct with an empty Default-Stop field, like the ssh one! Actually I'm running a buster installation, but using the sid insserv binary it does not show this issue, so I can't debug further for now ciao! diff --git a/debian/sysstat.postinst b/debian/sysstat.postinst index f4730d0..3ea1596 100644 --- a/debian/sysstat.postinst +++ b/debian/sysstat.postinst @@ -114,6 +114,11 @@ if [ "$1" = "configure" ] ; then --slave /usr/share/man/man1/sar.1.gz sar.1.gz \ /usr/share/man/man1/sar.sysstat.1.gz fi + +# new Default-Stop (see #971713) +if dpkg --compare-versions "$2" le '12.4.1-2'; then +update-rc.d -f sysstat remove +fi fi #DEBHELPER#
Bug#971713: sysstat: init or systemd file has overlapping runlevels
On Sun, 13 Dec 2020 11:03:57 +0100 Robert Luberda wrote: > sysstat's init.d has the following lines in /etc/init.d/sysstat > # Default-Start: 2 3 4 5 > # Default-Stop: > I'm not sure how empty Default-Stop is interpreted, so I've just tried it seems to me that on empty Default-Stop the runlevels will be copied from Default-Start, but this is not an issue, just to better understand > to change it to: > # Default-Stop: 0 1 6 this seems correct > As a result insserv displays two warnings instead of one: before explaining the error messages, remember that init scripts and their links are configuration files, like (almost) everything else under /etc > insserv: warning: current stop runlevel(s) (empty) of script `sysstat' > overrides LSB defaults (0 1 6). it is saying that the current stop runlevels (the /etc/rc*.d/*sysstat links) are overriding the ones described by the LSB header (inside the /etc/init.d/sysstat script) > insserv: Script ssh has overlapping Default-Start and Default-Stop > runlevels (2 3 4 5) and (2 3 4 5). This should be fixed. the end result is that the rc*.d links are unchanged and the runlevels still inconsistent > As a maintainer of sysstat I have no idea what else I can do to fix > the warning. It seems to me there is some bug in insserv. As the bug > affects my package, and according to the bug report "any package > that has init.d file", I'm setting severity of this report to grave. on new installations, simply adding the correct levels (0 1 6) to the script should fix the bug, but to fix on upgrades you should remove those links before running insserv, that is adding something like that to postinst inside the configure step: # new Default-Stop (see #971713) if dpkg --compare-versions "$2" le '12.4.0-2'; then update-rc.d -f sysstat remove fi this will also remove any tweaking done by user, that should be annotated inside the NEWS.Debian file I would like to provide you a patch, but I can't find where the init.d file is enabled inside the sysstat postinst, that should be: update-rc.d sysstat defaults ciao!
Bug#940034: libelogind0: replacing a core system library and conflicting against the default init considered harmful
On Tue, 24 Sep 2019 07:28:29 +0800 Ian Campbell wrote: > Has anyone investigated late dynamic binding using a stub library > which merely determines which init is running and then dlopens the > appropriate libsystemd0 of libelogind0 library and forwards the calls > to it? it could be in the form of libglvnd, a generic dispatcher to have co-installed multiple vendor implementations of libgl, with runtime selection https://github.com/NVIDIA/libglvnd a stripped down version of that architecture could be used to simply detect what init system is actually running and then dispatch to the correct library (libsystemd or libelogind) ciao!
Bug#928040: lprng: fails to install
Control: tag -1 patch
this patch should fix the issue
ciao!
diff -urN a/debian/lprng.init.in b/debian/lprng.init.in
--- a/debian/lprng.init.in 2012-06-11 09:47:19.0 +0200
+++ b/debian/lprng.init.in 2019-05-17 16:54:10.750983282 +0200
@@ -106,7 +106,8 @@
;;
stop)
[ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" lpd
- if start-stop-daemon --stop --oknodo --quiet --pidfile "${PIDFILE}" ; then
+ if start-stop-daemon --stop --oknodo --quiet --pidfile "${PIDFILE}" \
+ --exec $DAEMON --user daemon ; then
cleanup
[ "$VERBOSE" != no ] && log_end_msg 0
else
@@ -129,7 +130,8 @@
;;
restart|force-reload)
[ "$VERBOSE" != no ] && log_daemon_msg "Restarting $DESC" lpd
- start-stop-daemon --stop --quiet --pidfile "${PIDFILE}"
+ start-stop-daemon --stop --quiet --pidfile "${PIDFILE}" \
+ --exec $DAEMON --user daemon
sleep 1
initialise
start-stop-daemon --start --quiet --pidfile "${PIDFILE}" \
Bug#827395: firefox hidden connections
the connections you found can be blocked by changing these configuration directives: browser.newtabpage.enabled security.OCSP.enabled browser.safebrowsing.enabled browser.safebrowsing.malware.enabled privacy.trackingprotection.pbmode.enabled browser.search.suggest.enabled browser.search.update extensions.blocklist.enabled extensions.update.enabled extensions.getAddons.cache.enabled datareporting.healthreport.service.enabled toolkit.telemetry.enabled network.http.speculative-parallel-limit and may be: beacon.enabled browser.send_pings from time to time I have collected a list of configuration directives to stop automatic connections to remote hosts you can find at http://www.trek.eu.org/text/firefox-tuning.html I hope this can help
Bug#699034: Is this fixed in upstream upstream LIBGCRYPT-1-5-BRANCH?
On Sun, 24 Feb 2013 11:44:05 +0100 Andreas Metzler ametz...@downhill.at.eu.org wrote: upstream has a couple of patches in in their LIBGCRYPT-1-5-BRANCH, would you mind checking whether the issue is fixed there? I have built binary packages for i386, and have temporarily uploaded them to people.debian.org. http://people.debian.org/~ametzler/libgcrypt11_1.5.0-3+test+1_i386.deb Thank you! The bug is fixed with claws-mail as it can establish SSL connections. If it is fixed also with midori/webkit, this new version should be uploaded. Ciao! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699034: Is this fixed in upstream LIBGCRYPT-1-5-BRANCH?
On Sun, 24 Feb 2013 16:34:32 +0100 Andreas Metzler ametz...@downhill.at.eu.org wrote: relevant patches. Could you please test whether http://people.debian.org/~ametzler/libgcrypt11_1.5.0-3+test+2_i386.deb also does the trick? It just adds three patches (35_Avoid-dereferencing-pointer-right-after-the-end.patch 39_Fix-segv-with-AES-NI-on-some-platforms.patch 40_libgcrypt-1.5-rinjdael-Fix-use-of-SSE2-outside-USE_A.patch) instead of 11. It runs fine and the bug no longer shows up. I can exclude also the patches 39 and 40 as the CPU is an old AMD Athlon without AES-NI and SSE2. Ciao! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699034: similar bug report
you may find interesting this bug report: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640501 that was fixed downgrading libgcrypt11 to the 1.4.6-9 version from: http://snapshot.debian.org/archive/debian/20110807T212024Z/pool/main/libg/libgcrypt11/ may be it is the same bug? Ciao -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#658896: please try to downgrade libgcrypt11 to 1.4.6
Hi, can you try to downgrade libgcrypt11 to the version 1.4.6-9? You can download it from: http://snapshot.debian.org/archive/debian/20110807T212024Z/pool/main/libg/libgcrypt11/ this resolved a bug using claws-mail and midori with libgcrypt 1.5, that seems to have problems with its memory management: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640123 If this is the case, may be that libgcrypt11 should be downgraded before wheezy is released. Ciao! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#658739: please try to downgrade libgcrypt11 to 1.4.6
Hi, can you try to downgrade libgcrypt11 to the version 1.4.6-9? You can download it from: http://snapshot.debian.org/archive/debian/20110807T212024Z/pool/main/libg/libgcrypt11/ this resolved a bug using claws-mail and midori with libgcrypt 1.5, that seems to have problems with its memory management: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640123 If this is the case, may be that libgcrypt11 should be downgraded before wheezy is released. Ciao! -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
