Bug#1000229: binary package is missing /usr/sbin/memlockd

2022-03-05 Thread Paul Wise
Control: tags -1 + patch pending

On Fri, 19 Nov 2021 23:02:53 +0100 Sven Hartge wrote:

> The subject says it all: The package is missing the binary:

This is caused by the install target in debian/rules doing things
manually instead of leaving everything to dh_* scripts and
configuration files for them, which means that an arch-any build with
dpkg-buildpackage -B does not run the debian/rules install target.

I've attached a patch for a minimal NMU that fixes the issue and I have
uploaded that NMU to Debian with a 7 days delay. Please either
incorporate the patch into your next upload or reschedule the NMU to
occur as soon as possible. Note that after applying the patch you will
need to delete debian/memlockd-default, since the debdiff doesn't seem
to include removal of the file somehow.

I note this package needs a lot of polish. There are a lot of low
priority but trivial to fix lintian warnings. There are a lot of
unnecessary comments in the debian/ directory. The debian/docs file is
empty and can be deleted. The debian/dirs file can be deleted,
debhelper creates dirs as needed. The debian/copyright looks very out
of date. `wrap-and-sort -sabt` needs running. autopkgtests are needed.
debian/watch needs updating, memlockd 1.3 needs uploading upstream, the
upstream website needs links converting to https. The upstream project
should really get imported into git, from the Debian tarballs on
snapshot.debian.org if there isn't anything better.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise
diff -u memlockd-1.3/debian/changelog memlockd-1.3/debian/changelog
--- memlockd-1.3/debian/changelog
+++ memlockd-1.3/debian/changelog
@@ -1,3 +1,10 @@
+memlockd (1.3-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix package when building only arch-any packages (Closes: #1000229)
+
+ -- Paul Wise   Sun, 06 Mar 2022 07:24:13 +0800
+
 memlockd (1.3-2) unstable; urgency=medium
 
   * Made it install correctly when systemctl isn't installed, closes: ##999587
only in patch2:
unchanged:
--- memlockd-1.3.orig/debian/memlockd.default
+++ memlockd-1.3/debian/memlockd.default
@@ -0,0 +1,10 @@
+# Defaults for memlockd initscript
+# sourced by /etc/init.d/memlockd
+# installed at /etc/default/memlockd
+
+#
+# This is a POSIX shell fragment
+#
+
+# Additional options that are passed to the Daemon.
+DAEMON_OPTS="-u memlockd"
only in patch2:
unchanged:
--- memlockd-1.3.orig/debian/memlockd.install
+++ memlockd-1.3/debian/memlockd.install
@@ -0,0 +1,2 @@
+memlockd usr/sbin
+memlockd.cfg etc
only in patch2:
unchanged:
--- memlockd-1.3.orig/debian/memlockd.manpages
+++ memlockd-1.3/debian/memlockd.manpages
@@ -0,0 +1 @@
+memlockd.8
only in patch2:
unchanged:
--- memlockd-1.3.orig/debian/rules
+++ memlockd-1.3/debian/rules
@@ -17,19 +17,8 @@
 %:
 	dh $@
 
-install: build
-	dh_installdirs
-	cp memlockd debian/memlockd/usr/sbin
-	cp memlockd.cfg debian/memlockd/etc
-	cp debian/memlockd-default debian/memlockd/etc/default/memlockd
-	dh_installsystemd --restart-after-upgrade memlockd.service
+override_dh_installchangelogs:
 	dh_installchangelogs -X changes.txt
-	dh_installdocs
-	dh_installinit
-	dh_installman memlockd.8
-	dh_installdeb
-	dh_strip
-	dh_compress
 
 # dh_make generated override targets
 # This is example for Cmake (See https://bugs.debian.org/641051 )


signature.asc
Description: This is a digitally signed message part


Bug#1000229: binary package is missing /usr/sbin/memlockd

2021-11-19 Thread Sven Hartge
Package: memlockd
Version: 1.3-2
Severity: grave

Hello!

The subject says it all: The package is missing the binary:

,
| oweh@ds9:~$ dpkg -L memlockd
| /.
| /etc
| /etc/default
| /etc/init.d
| /etc/init.d/memlockd
| /etc/memlockd.d
| /lib
| /lib/systemd
| /lib/systemd/system
| /lib/systemd/system/memlockd.service
| /usr
| /usr/sbin
| /usr/share
| /usr/share/doc
| /usr/share/doc/memlockd
| /usr/share/doc/memlockd/changelog.Debian.gz
| /usr/share/doc/memlockd/changelog.gz
| /usr/share/doc/memlockd/copyright
| /usr/share/man
| /usr/share/man/man8
| /etc/memlockd.cfg
| /etc/default/memlockd
`

Interestingly, when I rebuild the 1.3-2 source package locally, I get a
DEB with the daemon in it:

,
| oweh@ds9:/tmp/test$ ls -l from_archive/ rebuild/
| from_archive/:
| total 8
| -rw-r--r-- 1 oweh oweh 5732 13. Nov 16:27 memlockd_1.3-2_amd64.deb
|
| rebuild/:
| total 16
| -rw-r--r-- 1 oweh oweh 13432 19. Nov 22:58 memlockd_1.3-2_amd64.deb
`

,
| oweh@ds9:/tmp/test$ debdiff from_archive/memlockd_1.3-2_amd64.deb 
rebuild/memlockd_1.3-2_amd64.deb
| [The following lists of changes regard files as different if they have
| different names, permissions or owners.]
|
| Files in second .deb but not in first
| -
| -rw-r--r--  root/root   /etc/default/memlockd
| -rw-r--r--  root/root   /etc/memlockd.cfg
| -rw-r--r--  root/root   /usr/share/man/man8/memlockd.8.gz
| -rwxr-xr-x  root/root   /usr/sbin/memlockd
|
| Files in first .deb but not in second
| -
| -rw-r--r--  root/root   /usr/share/doc/memlockd/changelog.gz
|
| Control files: lines which differ (wdiff format)
| 
| Installed-Size: [-31-] {+56+}
`

The buildlog from the buildd also confirms the missing binary: 
https://buildd.debian.org/status/fetch.php?pkg=memlockd=amd64=1.3-2=1636816430=0

Weird.

Grüße,
Sven.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'unstable'), (500, 'testing'), (200, 'experimental'), (1, 'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.14.0-2-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_CPU_OUT_OF_SPEC, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages memlockd depends on:
ii  adduser  3.118

memlockd recommends no packages.

memlockd suggests no packages.

-- debconf-show failed