Bug#1015080: irssi-plugin-robustirc: FTBFS: robustsession.c:599:25: error: ‘G_INPUT_READ’ undeclared (first use in this function); did you mean ‘I_INPUT_READ’?

2022-07-17 Thread Michael Stapelberg
I fixed the compilation issue with
https://github.com/robustirc/irssi-robustirc/commit/a89d711914cc852c7135bd8f822bbd0a4e16829a
upstream, but the plugin itself doesn’t actually work, at least not with
irssi 1.4.2.

When I last tried to use this plugin a few months ago by installing it from
Debian, it wouldn’t work either (mismatching ABI between irssi and the
plugin), but there never have been any user bug reports about this.

Given the low user interest and breakage that is not currently planned to
be fixed upstream (
https://github.com/robustirc/irssi-robustirc/commit/6c5a9d01f61dac8698cd993c44b525c5246c4890),
I think it would be best to remove this package from Debian entirely.

On Sat, 16 Jul 2022 at 16:02, Lucas Nussbaum  wrote:

> Source: irssi-plugin-robustirc
> Version: 0.6-4
> Severity: serious
> Justification: FTBFS
> Tags: bookworm sid ftbfs
> User: lu...@debian.org
> Usertags: ftbfs-20220716 ftbfs-bookworm
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
>
>
> Relevant part (hopefully):
> > cd /<>/obj-x86_64-linux-gnu/src/core && /usr/bin/cc
> -DUOFF_T_LONG -Drobustirc_core_EXPORTS -I/usr/include/yajl
> -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/<>/src/core
> -I/<>/src/core/robustsession -I/<>/src/fe-common
> -I/usr/include/irssi -I/usr/include/irssi/src
> -I/usr/include/irssi/src/fe-common/core -I/usr/include/irssi/src/core
> -I/usr/include/irssi/src/irc/core -g -O2
> -ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat
> -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
> -fPIC   -pthread -std=gnu99 -MD -MT
> src/core/CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o -MF
> CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o.d -o
> CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o -c
> /<>/src/core/robustsession/robustsession.c
> > /<>/src/core/robustsession/robustsession.c: In function
> ‘get_messages_timeout’:
> > /<>/src/core/robustsession/robustsession.c:268:17: warning:
> unused variable ‘server’ [-Wunused-variable]
> >   268 | SERVER_REC *server = request->server;
> >   | ^~
> > /<>/src/core/robustsession/robustsession.c: In function
> ‘socket_recv_cb’:
> > /<>/src/core/robustsession/robustsession.c:543:34: warning:
> unused parameter ‘data’ [-Wunused-parameter]
> >   543 | static void socket_recv_cb(void *data, GIOChannel *source, int
> condition) {
> >   |~~^~~~
> > /<>/src/core/robustsession/robustsession.c:543:64: warning:
> unused parameter ‘condition’ [-Wunused-parameter]
> >   543 | static void socket_recv_cb(void *data, GIOChannel *source, int
> condition) {
> >   |
> ^
> > /<>/src/core/robustsession/robustsession.c: In function
> ‘socket_callback’:
> > /<>/src/core/robustsession/robustsession.c:595:26: warning:
> implicit declaration of function ‘g_io_channel_new’; did you mean
> ‘i_io_channel_new’? [-Wimplicit-function-declaration]
> >   595 | GIOChannel *handle = g_io_channel_new(s);
> >   |  ^~~~
> >   |  i_io_channel_new
> > /<>/src/core/robustsession/robustsession.c:595:26: warning:
> initialization of ‘GIOChannel *’ {aka ‘struct _GIOChannel *’} from ‘int’
> makes pointer from integer without a cast [-Wint-conversion]
> > /<>/src/core/robustsession/robustsession.c:599:25: error:
> ‘G_INPUT_READ’ undeclared (first use in this function); did you mean
> ‘I_INPUT_READ’?
> >   599 | condition = G_INPUT_READ;
> >   | ^~~~
> >   | I_INPUT_READ
> > /<>/src/core/robustsession/robustsession.c:599:25: note:
> each undeclared identifier is reported only once for each function it
> appears in
> > /<>/src/core/robustsession/robustsession.c:602:25: error:
> ‘G_INPUT_WRITE’ undeclared (first use in this function); did you mean
> ‘I_INPUT_WRITE’?
> >   602 | condition = G_INPUT_WRITE;
> >   | ^
> >   | I_INPUT_WRITE
> > /<>/src/core/robustsession/robustsession.c:608:11: warning:
> implicit declaration of function ‘g_input_add’; did you mean ‘i_input_add’?
> [-Wimplicit-function-declaration]
> >   608 | *id = g_input_add(handle, condition, socket_recv_cb, NULL);
> >   |   ^~~
> >   |   i_input_add
> > /<>/src/core/robustsession/robustsession.c:575:34: warning:
> unused parameter ‘easy’ [-Wunused-parameter]
> >   575 | static int socket_callback(CURL *easy, curl_socket_t s, int
> what, void *userp, void *socketp) {
> >   |~~^~~~
> > /<>/src/core/robustsession/robustsession.c:575:73: warning:
> unused parameter ‘userp’ [-Wunused-parameter]
> >   575 | static int socket_callback(CURL *easy, curl_socket_t s, int
> what, void *userp, void 

Bug#1015080: irssi-plugin-robustirc: FTBFS: robustsession.c:599:25: error: ‘G_INPUT_READ’ undeclared (first use in this function); did you mean ‘I_INPUT_READ’?

2022-07-16 Thread Lucas Nussbaum
Source: irssi-plugin-robustirc
Version: 0.6-4
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20220716 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> cd /<>/obj-x86_64-linux-gnu/src/core && /usr/bin/cc 
> -DUOFF_T_LONG -Drobustirc_core_EXPORTS -I/usr/include/yajl 
> -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/<>/src/core 
> -I/<>/src/core/robustsession -I/<>/src/fe-common 
> -I/usr/include/irssi -I/usr/include/irssi/src 
> -I/usr/include/irssi/src/fe-common/core -I/usr/include/irssi/src/core 
> -I/usr/include/irssi/src/irc/core -g -O2 -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
> -D_FORTIFY_SOURCE=2 -Wall -Wextra -fPIC   -pthread -std=gnu99 -MD -MT 
> src/core/CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o -MF 
> CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o.d -o 
> CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o -c 
> /<>/src/core/robustsession/robustsession.c
> /<>/src/core/robustsession/robustsession.c: In function 
> ‘get_messages_timeout’:
> /<>/src/core/robustsession/robustsession.c:268:17: warning: 
> unused variable ‘server’ [-Wunused-variable]
>   268 | SERVER_REC *server = request->server;
>   | ^~
> /<>/src/core/robustsession/robustsession.c: In function 
> ‘socket_recv_cb’:
> /<>/src/core/robustsession/robustsession.c:543:34: warning: 
> unused parameter ‘data’ [-Wunused-parameter]
>   543 | static void socket_recv_cb(void *data, GIOChannel *source, int 
> condition) {
>   |~~^~~~
> /<>/src/core/robustsession/robustsession.c:543:64: warning: 
> unused parameter ‘condition’ [-Wunused-parameter]
>   543 | static void socket_recv_cb(void *data, GIOChannel *source, int 
> condition) {
>   |
> ^
> /<>/src/core/robustsession/robustsession.c: In function 
> ‘socket_callback’:
> /<>/src/core/robustsession/robustsession.c:595:26: warning: 
> implicit declaration of function ‘g_io_channel_new’; did you mean 
> ‘i_io_channel_new’? [-Wimplicit-function-declaration]
>   595 | GIOChannel *handle = g_io_channel_new(s);
>   |  ^~~~
>   |  i_io_channel_new
> /<>/src/core/robustsession/robustsession.c:595:26: warning: 
> initialization of ‘GIOChannel *’ {aka ‘struct _GIOChannel *’} from ‘int’ 
> makes pointer from integer without a cast [-Wint-conversion]
> /<>/src/core/robustsession/robustsession.c:599:25: error: 
> ‘G_INPUT_READ’ undeclared (first use in this function); did you mean 
> ‘I_INPUT_READ’?
>   599 | condition = G_INPUT_READ;
>   | ^~~~
>   | I_INPUT_READ
> /<>/src/core/robustsession/robustsession.c:599:25: note: each 
> undeclared identifier is reported only once for each function it appears in
> /<>/src/core/robustsession/robustsession.c:602:25: error: 
> ‘G_INPUT_WRITE’ undeclared (first use in this function); did you mean 
> ‘I_INPUT_WRITE’?
>   602 | condition = G_INPUT_WRITE;
>   | ^
>   | I_INPUT_WRITE
> /<>/src/core/robustsession/robustsession.c:608:11: warning: 
> implicit declaration of function ‘g_input_add’; did you mean ‘i_input_add’? 
> [-Wimplicit-function-declaration]
>   608 | *id = g_input_add(handle, condition, socket_recv_cb, NULL);
>   |   ^~~
>   |   i_input_add
> /<>/src/core/robustsession/robustsession.c:575:34: warning: 
> unused parameter ‘easy’ [-Wunused-parameter]
>   575 | static int socket_callback(CURL *easy, curl_socket_t s, int what, 
> void *userp, void *socketp) {
>   |~~^~~~
> /<>/src/core/robustsession/robustsession.c:575:73: warning: 
> unused parameter ‘userp’ [-Wunused-parameter]
>   575 | static int socket_callback(CURL *easy, curl_socket_t s, int what, 
> void *userp, void *socketp) {
>   |   
> ~~^
> /<>/src/core/robustsession/robustsession.c: In function 
> ‘robustsession_send’:
> /<>/src/core/robustsession/robustsession.c:855:102: warning: 
> unused parameter ‘size_buf’ [-Wunused-parameter]
>   855 | void robustsession_send(struct t_robustsession_ctx *ctx, SERVER_REC 
> *server, const char *buffer, int size_buf) {
>   |   
>^~~~
> make[3]: *** [src/core/CMakeFiles/robustirc_core.dir/build.make:107: 
> src/core/CMakeFiles/robustirc_core.dir/robustsession/robustsession.c.o] Error 
> 1


The full build log is available from: