Bug#1017017: regression: lxc virt backend cannot attach to container

[Simon McVittie]

On Thu, 11 Aug 2022 at 10:32:35 -0300, Antonio Terceiro wrote:
> : failure: timed out waiting for testbed to start: lxc-attach: 
> autopkgtest-lxc-jdtdzt: ../src/lxc/attach.c: get_attach_context: 405 
> Connection refused - Failed to get init pid

Please could you try with
?
I'd prefer not to revert the commit completely, because if I do that,
I'll have to duplicate the same logic in autopkgtest-virt-podman.

I haven't seen this happen on autopkgtest's own Gitlab-CI, or in several
runs of its complete autopkgtest suite under qemu on my laptop.

I'm sorry 5.23 has been such a low-quality release. I had hoped that the
amount of test coverage it has had would be sufficient to avoid that,
but it seems I've reached the fail state where it takes 2 hours to get
a release out *and* the release is broken.

smcv

Bug#1017017: regression: lxc virt backend cannot attach to container

[Antonio Terceiro]

Package: autopkgtest
Version: 5.23
Severity: grave
Justification: renders package unusable


This was first noticed by a salsa-ci user:
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/270#note_328972

I then tested locally, and reproduced the same issue with the snapshot I
was running from git:

8<8<8<-
autopkgtest [08:53:39]: starting date: 2022-08-11
autopkgtest [08:53:39]: version 5.23~terceiro0
autopkgtest [08:53:39]: host lemur; command line: /usr/bin/autopkgtest 
--output-dir=/tmp/autopkgtest-HicmTIAeQ --no-built-binaries --apt-upgrade 
/home/terceiro/src/debian/ruby-team/build-area/chake_0.82-1_all.deb . -- lxc 
--sudo autopkgtest-unstable-amd64
: failure: timed out waiting for testbed to start: lxc-attach: 
autopkgtest-lxc-jdtdzt: ../src/lxc/attach.c: get_attach_context: 405 Connection 
refused - Failed to get init pid
lxc-attach: autopkgtest-lxc-jdtdzt: ../src/lxc/attach.c: lxc_attach: 1469 
Connection refused - Failed to get attach context

autopkgtest [08:55:45]: ERROR: testbed failure: unexpected eof from the testbed
8<8<8<-

I get the same with 5.23 from unstable. Reverting back to 5.22 fixed
things.

I bisected locally and found out that
6ca1a0a5350026fe32b67c0ef4a64481ede83ea0 is the first bad commit
commit 6ca1a0a5350026fe32b67c0ef4a64481ede83ea0
Author: Simon McVittie 
Date:   Mon Aug 8 10:19:20 2022 +0100

virt-lxc, virt-lxd: Factor out code to wait for container to boot

This is duplicated between the two, and soon we'll want it for podman
as well.

Signed-off-by: Simon McVittie 

 Makefile  |  2 +
 lib/VirtSubproc.py| 99 ++-
 lib/await-sysv-boot   | 30 ++
 lib/detect-init-system| 15 +++
 tests/shellcheck  |  2 +
 virt/autopkgtest-virt-lxc | 27 +
 virt/autopkgtest-virt-lxd | 26 +
 7 files changed, 149 insertions(+), 52 deletions(-)
 create mode 100755 lib/await-sysv-boot
 create mode 100755 lib/detect-init-system

which makes sense.

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (500, 
'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.18.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), 
LANGUAGE=pt_BR:pt:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages autopkgtest depends on:
ii  apt-utils   2.5.2
ii  libdpkg-perl1.21.9
ii  procps  2:3.3.17-7+b1
ii  python3 3.10.5-3
ii  python3-debian  0.1.46

Versions of packages autopkgtest recommends:
ii  autodep8  0.26
ii  fakeroot  1.29-1

Versions of packages autopkgtest suggests:
ii  docker.io20.10.14+dfsg1-1+b1
ii  fakemachine  0.0~git20210901.fc48786-1+b1
ii  lxc  1:5.0.1-1
pn  lxd  
ii  ovmf 2022.05-2
pn  ovmf-ia32
ii  podman   4.0.3+ds1-1
pn  python3-distro-info  
ii  qemu-efi-aarch64 2022.05-2
ii  qemu-efi-arm 2022.05-2
ii  qemu-system  1:7.0+dfsg-7
ii  qemu-utils   1:7.0+dfsg-7
ii  schroot  1.6.12-1
ii  util-linux   2.38.1-1
ii  vmdb20.26-1

-- no debconf information


signature.asc
Description: PGP signature