Bug#1023046: zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
Control: tags -1 + patch Hi, On Tue, Nov 22, 2022 at 02:39:34PM +1100, Dmitry Smirnov wrote: > On Sunday, 20 November 2022 6:22:10 PM AEDT Adrian Bunk wrote: > > > > golang.org/x/text/unicode/norm > > > > # golang.org/x/sys/unix > > > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires > > > > go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > > zabbix.com/pkg/procfs > > > > # golang.org/x/sys/unix > > > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires > > > > go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice > > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > This comes from the new version of golang-golang-x-sys, see also [1]. > > > > [1] > > https://tracker.debian.org/news/1384566/accepted-golang-golang-x-sys-010-1 > > bpo111-source-into-bullseye-backports/ > > Unfortunately "golang-golang-x-sys/0.1.0-1" did not fix this FTBFS. > Maybe it is because it ships "go.mod" ? I though golang-x-* upstream has a good track of api stablity when I update that package. But it turns out hmm ... Please see the attached patch. >From ff8af531f1493f8e5717f76ccdd26d68e58c527a Mon Sep 17 00:00:00 2001 From: Shengjing Zhu Date: Tue, 22 Nov 2022 12:42:11 +0800 Subject: [PATCH] bump go version to 1.17 By running `go mod tidy -go=1.17` And `go mod vendor`, then sync vendor/modules.txt to topdir. golang.org/x/sys 0.1.0 uses unsafe.Slice, and this requires go1.17. See https://github.com/golang/go/issues/46525 --- src/go/go.mod | 27 ++--- src/go/go.sum | 12 --- vendor/modules.txt | 50 +++--- 3 files changed, 58 insertions(+), 31 deletions(-) diff --git a/src/go/go.mod b/src/go/go.mod index a49e83b..4b1899a 100644 --- a/src/go/go.mod +++ b/src/go/go.mod @@ -1,6 +1,6 @@ module zabbix.com -go 1.16 +go 1.17 require ( git.zabbix.com/ap/plugin-support v0.0.0-20220608100211-35b8bffd7ad0 @@ -15,7 +15,6 @@ require ( github.com/go-ole/go-ole v1.2.4 github.com/go-sql-driver/mysql v1.5.0 github.com/goburrow/modbus v0.1.0 - github.com/goburrow/serial v0.1.0 // indirect github.com/godbus/dbus v4.1.0+incompatible github.com/godror/godror v0.20.1 github.com/jackc/pgx/v4 v4.8.2-0.20200910143026-040df1ccef85 @@ -25,8 +24,30 @@ require ( github.com/miekg/dns v1.1.43 github.com/natefinch/npipe v0.0.0-20160621034901-c1b8fa8bdcce github.com/omeid/go-yarn v0.0.1 - github.com/pkg/errors v0.9.1 // indirect golang.org/x/sys v0.0.0-20220310020820-b874c991c1a5 +) + +require ( + github.com/chromedp/sysutil v1.0.0 // indirect + github.com/go-logfmt/logfmt v0.5.0 // indirect + github.com/goburrow/serial v0.1.0 // indirect + github.com/gobwas/httphead v0.1.0 // indirect + github.com/gobwas/pool v0.2.1 // indirect + github.com/gobwas/ws v1.0.4 // indirect + github.com/jackc/chunkreader/v2 v2.0.1 // indirect + github.com/jackc/pgconn v1.6.5-0.20200905181414-0d4f029683fc // indirect + github.com/jackc/pgio v1.0.0 // indirect + github.com/jackc/pgpassfile v1.0.0 // indirect + github.com/jackc/pgproto3/v2 v2.0.4 // indirect + github.com/jackc/pgservicefile v0.0.0-20200714003250-2b9c44734f2b // indirect + github.com/jackc/pgtype v1.4.3-0.20200905161353-e7d2b057a716 // indirect + github.com/jackc/puddle v1.1.2-0.20200821025810-91d0159cc97a // indirect + github.com/josharian/intern v1.0.0 // indirect + github.com/mailru/easyjson v0.7.6 // indirect + github.com/pkg/errors v0.9.1 // indirect + golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9 // indirect + golang.org/x/net v0.0.0-20210226172049-e18ecbb05110 // indirect + golang.org/x/text v0.3.3 // indirect golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d // indirect gopkg.in/yaml.v2 v2.2.8 // indirect diff --git a/src/go/go.sum b/src/go/go.sum index 52f1940..717a47f 100644 --- a/src/go/go.sum +++ b/src/go/go.sum @@ -1,17 +1,5 @@ -git.zabbix.com/ap/plugin-support v0.0.0-20220524072909-7233a93fe116 h1:IGbQPDh/U7UHSM0M4h2k/wdRjyO3zG8uq4Dx+gej4y8= -git.zabbix.com/ap/plugin-support v0.0.0-20220524072909-7233a93fe116/go.mod
Processed: Re: Bug#1023046: zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
Processing control commands: > tags -1 + patch Bug #1023046 [src:zabbix] zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod) Added tag(s) patch. -- 1023046: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023046 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1023046: zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
On Sunday, 20 November 2022 6:22:10 PM AEDT Adrian Bunk wrote: > > > golang.org/x/text/unicode/norm > > > # golang.org/x/sys/unix > > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires > > > go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > zabbix.com/pkg/procfs > > > # golang.org/x/sys/unix > > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires > > > go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice > > > requires go1.17 or later (-lang was set to go1.16; check go.mod) > This comes from the new version of golang-golang-x-sys, see also [1]. > > [1] > https://tracker.debian.org/news/1384566/accepted-golang-golang-x-sys-010-1 > bpo111-source-into-bullseye-backports/ Unfortunately "golang-golang-x-sys/0.1.0-1" did not fix this FTBFS. Maybe it is because it ships "go.mod" ? -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- Without doubt you are not sane. -- Tage Danielsson --- COVID-19: The Trouble With PCR Tests https://swprs.org/the-trouble-with-pcr-tests/ signature.asc Description: This is a digitally signed message part.
Bug#1023046: zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
On Sat, Oct 29, 2022 at 04:51:19PM +, Mathias Gibbens wrote: > Source: zabbix > Version: 1:6.0.9+dfsg-1.1 > Severity: serious > Justification: FTBFS > Tags: bookworm sid ftbfs > > While rebuilding the reverse build dependencies of another golang > package I'm updating, I noticed that zabbix fails to build in a clean > sid chroot. I suspect this was likely caused by the recent update of > the golang-golang-x-sys package, but I haven't investigated further. > > > on.compileArch=`go env GOARCH` -X main.applicationName=zabbix_web_service" > > -o bin zabbix.com/cmd/zabbix_web_service > > > > [snip] > > > > golang.org/x/text/unicode/norm > > # golang.org/x/sys/unix > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 > > or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) > > zabbix.com/pkg/procfs > > # golang.org/x/sys/unix > > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 > > or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) > > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires > > go1.17 or later (-lang was set to go1.16; check go.mod) This comes from the new version of golang-golang-x-sys, see also [1]. cu Adrian [1] https://tracker.debian.org/news/1384566/accepted-golang-golang-x-sys-010-1bpo111-source-into-bullseye-backports/
Bug#1023046: zabbix: FTBFS: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
Source: zabbix Version: 1:6.0.9+dfsg-1.1 Severity: serious Justification: FTBFS Tags: bookworm sid ftbfs While rebuilding the reverse build dependencies of another golang package I'm updating, I noticed that zabbix fails to build in a clean sid chroot. I suspect this was likely caused by the recent update of the golang-golang-x-sys package, but I haven't investigated further. > on.compileArch=`go env GOARCH` -X main.applicationName=zabbix_web_service" -o > bin zabbix.com/cmd/zabbix_web_service > > [snip] > > golang.org/x/text/unicode/norm > # golang.org/x/sys/unix > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 > or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) > zabbix.com/pkg/procfs > # golang.org/x/sys/unix > vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 > or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) > vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires > go1.17 or later (-lang was set to go1.16; check go.mod) signature.asc Description: This is a digitally signed message part